Akhilailla/fix properties type object no definition false negatives #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 24, 2024 12:27
… into akhilailla/fix_PropertiesTypeObjectNoDefinition-_false_negatives Pull master changes
AkhilaIlla
requested review from
bdefoy,
konrad-jamrozik,
mikeharder,
rkmanda,
tejaswiMinnu and
weshaggard
as code owners
bdefoy
reviewed
Jun 25, 2024
packages/rulesets/src/spectral/functions/properties-type-object-no-definition.ts
Show resolved
Hide resolved
tejaswiMinnu
approved these changes
Aug 13, 2024
Contributor
tejaswiMinnu
left a comment
tejaswiMinnu
left a comment
There was a problem hiding this comment.
The reason this issue wasn't detected is because the rule is currently only in the staging environment. I have a PBI in this sprint to update the rules in the production environment.
AkhilaIlla
deleted the
akhilailla/fix_PropertiesTypeObjectNoDefinition-_false_negatives
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocking comment related to property of type object not having definition is added manually: (Azure/azure-rest-api-specs#28891 (comment))
This PR validates if the false negative mentioned in https://msazure.visualstudio.com/One/_workitems/edit/28199177 (Azure/azure-rest-api-specs#28891 (comment)) is being flagged.
Also, found that no jobs ran until a couple of comments on the PR. Either the checks didnt run & hence didnt flag the error or the builds arent showing up now.
