Skip to content

Fix version for DnsResolver and add mapping for new modules #17232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
VeryEarly merged 3 commits into from
Feb 23, 2022
Merged

Fix version for DnsResolver and add mapping for new modules #17232

VeryEarly merged 3 commits into from
Feb 23, 2022

Conversation

@VeryEarly
Copy link
Collaborator

@VeryEarly VeryEarly commented Feb 23, 2022

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly VeryEarly self-assigned this Feb 23, 2022
BethanyZhou
BethanyZhou approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VeryEarly VeryEarly merged commit 1d22467 into Azure:release-2022-03-01 Feb 23, 2022
@VeryEarly VeryEarly deleted the yabo/release-2022-03-01 branch February 23, 2022 04:03
BethanyZhou pushed a commit to BethanyZhou/azure-powershell that referenced this pull request Feb 23, 2022
@VeryEarly @BethanyZhou
Fix version for DnsResolver and add mapping for new modules (Azure#17232
90c7c5d 
)

* fix dnsresolver version

* add mapping for new modules

* remove regex for quota/dnsresolver in mapping rule
BethanyZhou added a commit that referenced this pull request Feb 23, 2022
@BethanyZhou @VeryEarly
Continued NextPageLink when listing key vaults from ARM API (#17235)
6756fa3 
* Continued NextPageLink when listing key vaults from ARM API

* fix

* Fix version for DnsResolver and add mapping for new modules (#17232)

* fix dnsresolver version

* add mapping for new modules

* remove regex for quota/dnsresolver in mapping rule

Co-authored-by: Yabo Hu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BethanyZhou BethanyZhou BethanyZhou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@VeryEarly VeryEarly

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VeryEarly @BethanyZhou