Skip to content

Add into DNS Resolver new functionality for DNS Security Policy as part of 2023-07-01-preview release #26452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vidai-msft merged 12 commits into from
Nov 8, 2024
Merged

Add into DNS Resolver new functionality for DNS Security Policy as part of 2023-07-01-preview release #26452

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c9b474e
Add DNS Security Policy changes for 2023-07-01 preview version
jamesvoongms Oct 23, 2024
e953ab8
Use full github link
jamesvoongms Oct 23, 2024
abce0f0
Add custom and test changes
jamesvoongms Oct 23, 2024
d7e8d8e
Change back to repo
jamesvoongms Oct 23, 2024
9e4460f
Fix README for require statement
jamesvoongms Oct 28, 2024
6709ce6
Revert noprofile change and change folder path to forward slash
jamesvoongms Oct 29, 2024
4efa1b8
Add condition to skip vnet creation on record on tests
jamesvoongms Nov 1, 2024
af6c620
Fix old test files
jamesvoongms Nov 5, 2024
71887e6
Fix comment
jamesvoongms Nov 5, 2024
ae9785a
Fix recording of vnet link tests
jamesvoongms Nov 6, 2024
b57f17b
Add breaking changes exception as the systemdata is now moved into co…
jamesvoongms Nov 6, 2024
2c3e58a
Fix last test file recording
jamesvoongms Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add condition to skip vnet creation on record on tests
  • Loading branch information
@jamesvoongms
jamesvoongms committed Nov 1, 2024
commit 4efa1b86862ed838ce27cd4b441d41010b0b00a6
24 changes: 18 additions & 6 deletions ...DnsResolver/DnsResolver.Autorest/test/Get-AzDnsResolverPolicyVirtualNetworkLink.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,17 @@ Describe 'Get-AzDnsResolverPolicyVirtualNetworkLink' {
$virtualNetworkName = "psvirtualnetworkforlinknameafa9789a";
$resourceGroupName = "powershell-test-rg-debug-get";
$location = "westus2";
$subscriptionId = "91ab65d2-c73f-4768-89d0-b061815f258b";
$virtualNetworkId = "/subscriptions/$subscriptionId/resourceGroups/$resourceGroupName/providers/Microsoft.Network/virtualNetworks/$virtualNetworkName"

$defaultSubnet = New-AzVirtualNetworkSubnetConfig -Name "default" -AddressPrefix "10.0.0.0/24"
$vnet = New-AzVirtualNetwork -Name $virtualNetworkName -ResourceGroupName $resourceGroupName -Location $location -AddressPrefix "10.0.0.0/16" -Subnet $defaultSubnet
if ($TestMode -eq "Record")
{
$defaultSubnet = New-AzVirtualNetworkSubnetConfig -Name "default" -AddressPrefix "10.0.0.0/24"
$vnet = New-AzVirtualNetwork -Name $virtualNetworkName -ResourceGroupName $resourceGroupName -Location $location -AddressPrefix "10.0.0.0/16" -Subnet $defaultSubnet
}

$resolverPolicy = New-AzDnsResolverPolicy -Name $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location
$resolverPolicyLink = New-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location -VirtualNetworkId $vnet.Id
$resolverPolicyLink = New-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location -VirtualNetworkId $virtualNetworkId

# ACT
$dnsResolverPolicyLink = Get-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName
Expand All @@ -42,11 +48,17 @@ Describe 'Get-AzDnsResolverPolicyVirtualNetworkLink' {
$virtualNetworkName = "psvirtualnetworkforlinkname7sadjfa";
$resourceGroupName = "powershell-test-rg-debug-get";
$location = "westus2";
$subscriptionId = "91ab65d2-c73f-4768-89d0-b061815f258b";
$virtualNetworkId = "/subscriptions/$subscriptionId/resourceGroups/$resourceGroupName/providers/Microsoft.Network/virtualNetworks/$virtualNetworkName"

$defaultSubnet = New-AzVirtualNetworkSubnetConfig -Name "default" -AddressPrefix "10.0.0.0/24"
$vnet = New-AzVirtualNetwork -Name $virtualNetworkName -ResourceGroupName $resourceGroupName -Location $location -AddressPrefix "10.0.0.0/16" -Subnet $defaultSubnet
if ($TestMode -eq "Record")
{
$defaultSubnet = New-AzVirtualNetworkSubnetConfig -Name "default" -AddressPrefix "10.0.0.0/24"
$vnet = New-AzVirtualNetwork -Name $virtualNetworkName -ResourceGroupName $resourceGroupName -Location $location -AddressPrefix "10.0.0.0/16" -Subnet $defaultSubnet
}

$resolverPolicy = New-AzDnsResolverPolicy -Name $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location
$resolverPolicyLink = New-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location -VirtualNetworkId $vnet.Id
$resolverPolicyLink = New-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location -VirtualNetworkId $virtualNetworkId

# ACT
$dnsResolverPolicyLinks = Get-AzDnsResolverPolicyVirtualNetworkLink -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName
Expand Down
12 changes: 9 additions & 3 deletions ...DnsResolver/DnsResolver.Autorest/test/New-AzDnsResolverPolicyVirtualNetworkLink.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,19 @@ Describe 'New-AzDnsResolverPolicyVirtualNetworkLink' {
$virtualNetworkName = "psvirtualnetworkforlinkname0j0cdzg";
$resourceGroupName = "powershell-test-rg-debug-new";
$location = "westus2";
$subscriptionId = "91ab65d2-c73f-4768-89d0-b061815f258b";
$virtualNetworkId = "/subscriptions/$subscriptionId/resourceGroups/$resourceGroupName/providers/Microsoft.Network/virtualNetworks/$virtualNetworkName"

$defaultSubnet = New-AzVirtualNetworkSubnetConfig -Name "default" -AddressPrefix "10.0.0.0/24"
$vnet = New-AzVirtualNetwork -Name $virtualNetworkName -ResourceGroupName $resourceGroupName -Location $location -AddressPrefix "10.0.0.0/16" -Subnet $defaultSubnet
if ($TestMode -eq "Record")
{
$defaultSubnet = New-AzVirtualNetworkSubnetConfig -Name "default" -AddressPrefix "10.0.0.0/24"
$vnet = New-AzVirtualNetwork -Name $virtualNetworkName -ResourceGroupName $resourceGroupName -Location $location -AddressPrefix "10.0.0.0/16" -Subnet $defaultSubnet
}

$resolverPolicy = New-AzDnsResolverPolicy -Name $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location

# ACT
$resolverPolicyLink = New-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location -VirtualNetworkId $vnet.Id
$resolverPolicyLink = New-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location -VirtualNetworkId $virtualNetworkId

# ASSERT
{ Get-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName } | Should -Not -Throw
Expand Down
25 changes: 19 additions & 6 deletions ...Resolver/DnsResolver.Autorest/test/Remove-AzDnsResolverPolicyVirtualNetworkLink.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,17 @@ Describe 'Remove-AzDnsResolverPolicyVirtualNetworkLink' {
$resourceGroupName = "powershell-test-rg-debug-remove";
$location = "westus2";

$defaultSubnet = New-AzVirtualNetworkSubnetConfig -Name "default" -AddressPrefix "10.0.0.0/24"
$vnet = New-AzVirtualNetwork -Name $virtualNetworkName -ResourceGroupName $resourceGroupName -Location $location -AddressPrefix "10.0.0.0/16" -Subnet $defaultSubnet
$subscriptionId = "91ab65d2-c73f-4768-89d0-b061815f258b";
$virtualNetworkId = "/subscriptions/$subscriptionId/resourceGroups/$resourceGroupName/providers/Microsoft.Network/virtualNetworks/$virtualNetworkName"

if ($TestMode -eq "Record")
{
$defaultSubnet = New-AzVirtualNetworkSubnetConfig -Name "default" -AddressPrefix "10.0.0.0/24"
$vnet = New-AzVirtualNetwork -Name $virtualNetworkName -ResourceGroupName $resourceGroupName -Location $location -AddressPrefix "10.0.0.0/16" -Subnet $defaultSubnet
}

$resolverPolicy = New-AzDnsResolverPolicy -Name $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location
$resolverPolicyLink = New-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location -VirtualNetworkId $vnet.Id
$resolverPolicyLink = New-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location -VirtualNetworkId $virtualNetworkId

# ACT
$updatedDnsResolverPolicyLink = Remove-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName
Expand All @@ -42,11 +49,17 @@ Describe 'Remove-AzDnsResolverPolicyVirtualNetworkLink' {
$virtualNetworkName = "psvirtualnetworkforlinkname353hj35";
$resourceGroupName = "powershell-test-rg-debug-remove";
$location = "westus2";
$subscriptionId = "91ab65d2-c73f-4768-89d0-b061815f258b";
$virtualNetworkId = "/subscriptions/$subscriptionId/resourceGroups/$resourceGroupName/providers/Microsoft.Network/virtualNetworks/$virtualNetworkName"

$defaultSubnet = New-AzVirtualNetworkSubnetConfig -Name "default" -AddressPrefix "10.0.0.0/24"
$vnet = New-AzVirtualNetwork -Name $virtualNetworkName -ResourceGroupName $resourceGroupName -Location $location -AddressPrefix "10.0.0.0/16" -Subnet $defaultSubnet
if ($TestMode -eq "Record")
{
$defaultSubnet = New-AzVirtualNetworkSubnetConfig -Name "default" -AddressPrefix "10.0.0.0/24"
$vnet = New-AzVirtualNetwork -Name $virtualNetworkName -ResourceGroupName $resourceGroupName -Location $location -AddressPrefix "10.0.0.0/16" -Subnet $defaultSubnet
}

$resolverPolicy = New-AzDnsResolverPolicy -Name $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location
$resolverPolicyLink = New-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location -VirtualNetworkId $vnet.Id
$resolverPolicyLink = New-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location -VirtualNetworkId $virtualNetworkId

# ACT - ASSERT
Get-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName | Remove-AzDnsResolverPolicyVirtualNetworkLink
Expand Down
12 changes: 9 additions & 3 deletions ...Resolver/DnsResolver.Autorest/test/Update-AzDnsResolverPolicyVirtualNetworkLink.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,17 @@ Describe 'Update-AzDnsResolverPolicyVirtualNetworkLink' {
$virtualNetworkName = "psvirtualnetworkforlinknamef2rcmjh";
$resourceGroupName = "powershell-test-rg-debug-update";
$location = "westus2";
$subscriptionId = "91ab65d2-c73f-4768-89d0-b061815f258b";
$virtualNetworkId = "/subscriptions/$subscriptionId/resourceGroups/$resourceGroupName/providers/Microsoft.Network/virtualNetworks/$virtualNetworkName"

if ($TestMode -eq "Record")
{
$defaultSubnet = New-AzVirtualNetworkSubnetConfig -Name "default" -AddressPrefix "10.0.0.0/24"
$vnet = New-AzVirtualNetwork -Name $virtualNetworkName -ResourceGroupName $resourceGroupName -Location $location -AddressPrefix "10.0.0.0/16" -Subnet $defaultSubnet
}

$defaultSubnet = New-AzVirtualNetworkSubnetConfig -Name "default" -AddressPrefix "10.0.0.0/24"
$vnet = New-AzVirtualNetwork -Name $virtualNetworkName -ResourceGroupName $resourceGroupName -Location $location -AddressPrefix "10.0.0.0/16" -Subnet $defaultSubnet
$resolverPolicy = New-AzDnsResolverPolicy -Name $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location
$resolverPolicyLink = New-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location -VirtualNetworkId $vnet.Id
$resolverPolicyLink = New-AzDnsResolverPolicyVirtualNetworkLink -Name $dnsResolverPolicyLinkName -DnsResolverPolicyName $dnsResolverPolicyName -ResourceGroupName $resourceGroupName -Location $location -VirtualNetworkId $virtualNetworkId
$tag = GetRandomHashtable -size 5

# ACT
Expand Down