[Storage] When download blob with parameter AbsoluteUri, not allow in… #26599

VeryEarly · 2024-11-05T03:58:25Z

…put parameter Context (#26585)

[Storage] fix Get-AzStorageBlobContent download from uri without sas and access key #26316: When download blob with parameter AbsoluteUri (alias Uri, BlobUri), not allow input parameter Context together.
Add static exception
revise change log

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- For autorest-based development mode, include the changelog in the PR description.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

…put parameter Context (Azure#26585) * [Storage] fix Azure#26316: When download blob with parameter AbsoluteUri (alias Uri, BlobUri), not allow input parameter Context together. * Add static exception * revise change log

azure-client-tools-bot-prd · 2024-11-05T03:58:27Z

️✔️Az.Accounts

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Compute

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.EventHub

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Az.IotHub

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00 % Test coverage for the module cannot be lower than 50%.

⚠️ - MacOS

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

⚠️PowerShell Core - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 0.00% Test coverage for the module cannot be lower than 50%.

️✔️Az.KeyVault

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.ManagedServiceIdentity

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Monitor

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Network

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.OperationalInsights

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.PrivateDns

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.RedisCache

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Search

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Test

️✔️ - Linux

️✔️ - MacOS

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Az.Sql

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Az.Storage

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️Breaking Change Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Signature Check

⚠️PowerShell Core - Windows

Type Cmdlet Description Remediation

⚠️ Get-AzStorageAccountMigration Get-AzStorageAccountMigration Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzStorageAccountMigration Get-AzStorageAccountMigration changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️Windows PowerShell - Windows

Type Cmdlet Description Remediation

⚠️ Get-AzStorageAccountMigration Get-AzStorageAccountMigration Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzStorageAccountMigration Get-AzStorageAccountMigration changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️Help Example Check

⚠️PowerShell Core - Windows

Type Cmdlet Example Line RuleName Description Extent Remediation

⚠️ Get-AzStorageBlobContent 5 1 Unassigned_Variable Get-AzStorageBlobContent -Uri $blobUri is a null-valued parameter value. -Uri Assign value for $blobUri.

⚠️Windows PowerShell - Windows

Type Cmdlet Example Line RuleName Description Extent Remediation

⚠️ Get-AzStorageBlobContent 5 1 Unassigned_Variable Get-AzStorageBlobContent -Uri $blobUri is a null-valued parameter value. -Uri Assign value for $blobUri.

️✔️Help File Existence Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️File Change Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

️✔️UX Metadata Check

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 41.76 % Test coverage for the module cannot be lower than 50%.

⚠️ - MacOS

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 41.76% Test coverage for the module cannot be lower than 50%.

⚠️PowerShell Core - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 41.76% Test coverage for the module cannot be lower than 50%.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 41.76% Test coverage for the module cannot be lower than 50%.

⚠️Az.StorageSync

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 76.00 % 80.00% Test coverage cannot be lower than the number of the last release.

⚠️ - MacOS

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 76.00% 80.00% Test coverage cannot be lower than the number of the last release.

⚠️PowerShell Core - Windows

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 76.00% 80.00% Test coverage cannot be lower than the number of the last release.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Last Coverage Description

⚠️ Test Coverage Less Than 80% 76.00% 80.00% Test coverage cannot be lower than the number of the last release.

⚠️Az.Synapse

️✔️Build

️✔️PowerShell Core - Windows

️✔️Windows PowerShell - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 48.80 % Test coverage for the module cannot be lower than 50%.

⚠️ - MacOS

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 48.80% Test coverage for the module cannot be lower than 50%.

⚠️PowerShell Core - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 48.80% Test coverage for the module cannot be lower than 50%.

⚠️Windows PowerShell - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 48.80% Test coverage for the module cannot be lower than 50%.

src/Storage/Storage.Management/ChangeLog.md

tools/StaticAnalysis/Exceptions/Az.Storage/BreakingChangeIssues.csv

github-actions · 2024-11-07T07:35:40Z

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

According to our policy, breaking changes can only take place during major release and they must be preannounced.
Please follow our guide on the detailed steps.
Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

vidai-msft

LGTM

#26599) * [Storage] When download blob with parameter AbsoluteUri, not allow input parameter Context (#26585) * [Storage] fix #26316: When download blob with parameter AbsoluteUri (alias Uri, BlobUri), not allow input parameter Context together. * Add static exception * revise change log * resolve merge --------- Co-authored-by: Wei Wei <[email protected]> Co-authored-by: Vincent Dai <[email protected]>

VeryEarly self-assigned this Nov 5, 2024

blueww reviewed Nov 5, 2024

View reviewed changes

src/Storage/Storage.Management/ChangeLog.md Show resolved Hide resolved

blueww reviewed Nov 5, 2024

View reviewed changes

tools/StaticAnalysis/Exceptions/Az.Storage/BreakingChangeIssues.csv Show resolved Hide resolved

resolve merge

9642ba4

vidai-msft unassigned VeryEarly Nov 7, 2024

vidai-msft added the Contains Breaking Change This PR contains breaking change label Nov 7, 2024

vidai-msft added this to the Az 13.0.0 (2024-11-19)❗Breaking change release❗ milestone Nov 7, 2024

Merge branch 'main' into yabo/sync-main-26585

aa8cc69

vidai-msft approved these changes Nov 7, 2024

View reviewed changes

vidai-msft added the Waiting for CI label Nov 7, 2024

vidai-msft merged commit 1653719 into Azure:main Nov 7, 2024

VeryEarly deleted the yabo/sync-main-26585 branch November 7, 2024 12:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Storage] When download blob with parameter AbsoluteUri, not allow in… #26599

[Storage] When download blob with parameter AbsoluteUri, not allow in… #26599

Uh oh!

VeryEarly commented Nov 5, 2024

Uh oh!

azure-client-tools-bot-prd bot commented Nov 5, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 7, 2024

Uh oh!

vidai-msft left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[Storage] When download blob with parameter AbsoluteUri, not allow in… #26599

[Storage] When download blob with parameter AbsoluteUri, not allow in… #26599

Uh oh!

Conversation

VeryEarly commented Nov 5, 2024

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Nov 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 7, 2024

Uh oh!

vidai-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

azure-client-tools-bot-prd bot commented Nov 5, 2024 •

edited

Loading