Skip to content

Conversation

@jamesvoongms
Copy link
Member

Description

PR just adds the examples missing for new commandlets generated in the below PR:
#26452

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 13, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.DnsResolver
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzDnsForwardingRulesetForwardingRule Get-AzDnsForwardingRulesetForwardingRule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDnsForwardingRulesetForwardingRule Get-AzDnsForwardingRulesetForwardingRule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDnsForwardingRulesetVirtualNetworkLink Get-AzDnsForwardingRulesetVirtualNetworkLink Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDnsForwardingRulesetVirtualNetworkLink Get-AzDnsForwardingRulesetVirtualNetworkLink changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDnsResolverDomainList Get-AzDnsResolverDomainList Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDnsResolverDomainList Get-AzDnsResolverDomainList changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDnsResolverInboundEndpoint Get-AzDnsResolverInboundEndpoint Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDnsResolverInboundEndpoint Get-AzDnsResolverInboundEndpoint changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDnsResolverOutboundEndpoint Get-AzDnsResolverOutboundEndpoint Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDnsResolverOutboundEndpoint Get-AzDnsResolverOutboundEndpoint changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDnsResolverPolicyDnsSecurityRule Get-AzDnsResolverPolicyDnsSecurityRule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDnsResolverPolicyDnsSecurityRule Get-AzDnsResolverPolicyDnsSecurityRule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzDnsResolverPolicyVirtualNetworkLink Get-AzDnsResolverPolicyVirtualNetworkLink Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzDnsResolverPolicyVirtualNetworkLink Get-AzDnsResolverPolicyVirtualNetworkLink changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzDnsResolverIPConfigurationObject New-AzDnsResolverIPConfigurationObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzDnsResolverTargetDnsServerObject New-AzDnsResolverTargetDnsServerObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.DnsResolver. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows

@jamesvoongms jamesvoongms changed the title [DRAFT] Add examples for new DNS Resolver - DNS Resolver Policy Modules Add examples for new DNS Resolver - DNS Resolver Policy Modules Nov 13, 2024
@VeryEarly VeryEarly assigned VeryEarly and unassigned vidai-msft Nov 13, 2024
VeryEarly
VeryEarly previously approved these changes Nov 13, 2024
@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@jamesvoongms
Copy link
Member Author

Changelog:

Add 4 new DNS Resolver Policy (DNS Security Policy) resources into the commandlets

  • DNS Resolver Policy (DNS Security Policy)
  • DNS Security Rule
  • DNS Resolver Policy Link (DNS Security Policy Link)
  • DNS Resolver Domain List

vidai-msft
vidai-msft previously approved these changes Nov 13, 2024
@VeryEarly
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly assigned vidai-msft and unassigned VeryEarly Nov 13, 2024
@vidai-msft vidai-msft merged commit 0e7c0ed into Azure:generation Nov 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants