Application Insights components & webtests API schema updates #420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TianoMS
reviewed
Mar 9, 2018
| @@ -0,0 +1,657 @@ | |||
| { | |||
| "id": "https://schema.management.azure.com/schemas/2015-05-01/microsoft.insights.json#", | |||
There was a problem hiding this comment.
microsoft.insights [](start = 64, length = 18)
please be consistent in names. First letter upper case, so: "Microsoft.Insights".
TianoMS
reviewed
Mar 9, 2018
| "type": { | ||
| "type": "string", | ||
| "enum": [ | ||
| "microsoft.insights/components" |
There was a problem hiding this comment.
microsoft.insights [](start = 13, length = 18)
These one as well: first letter in upper case. Please fix all of them.
…uggestions - remove unnecessary sub-components from API as well
Member
Author
|
Updated naming and improved the schema overall by removing some extra, unneeded definitions. |
Member
Author
|
@TianoMS, any further suggestions? |
Contributor
|
@d3r3kk can you fix the file name as well? it's "microsoft.insights.json" now. |
Member
Author
|
@TianoMS you bet. All done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Application Insights webtest and components API to version 2015-05-01
Requirements: