-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #11258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 #11258
Conversation
|
Azure Pipelines successfully started running 1 pipeline(s). |
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-java - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I manually validated that all changes flagged as breaking change documentation to match actual established behavior of the api and represent documentation errors, not changes in the underlying API. |
|
Hi, @zachraMSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @zachraMSFT, one or multiple breaking change(s) is detected in your PR. Pls follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
@PhoenixHe-msft As I mentioned in my original comment, all of these changes represent updating swagger to match current API behavior, so it represents fixing KPIs showing in S360 and documentation. This means that the full review process does not apply, and we want to make these changes quickly. |
|
What steps do we need to take to make sure this review happens in a timely manner? |
|
@zachraMSFT In this case you still need to go through the process. We will have some other options for you during the review process but first you need to start the breaking change review. |
|
@PhoenixHe-msft Ok, we can start looking into it. But as I look at what's being flagged, none of them should actually be breaking. We don't generate an SDK for this, and all of the changes are only adding fields to the response. Requests are unchanged, and only one existing response property is changing at all (changing type from object to list). The errors about discriminator and properties being removed should be false positives unless there's an issue with the change. A discriminator was added to an object that did not have one, but that's just adding a "kind":"Legacy" property in what user sees. Similar with the allOf changes, it's just reorganizing and cleaning up the object organization, what is actually being generated for the user isn't changed. |
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
|
@zachraMSFT I know you have comments on your changes but please clarify it in the breaking change review meeting. Thanks. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@PhoenixHe-msft Can you merge this now? |
…on stable/2019-10-01 (Azure#11258) * Fix mistakes in swagger from actual responses * Fix swagger mismatches * Add 204 to examples * Fix example response to match actual response format * Fix errors * Remove discriminator, not returned in full response * Avoid discriminator while still not active in code * Add discriminator, it's actively used * Fix example files * Additional fix * Fix discriminator setup * Remove new properties added * Remove required property * Fix example
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.