EventGrid - Add api-version 2020-10-01-preview #11535
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger Validation Report
|
| Rule | Message |
|---|---|
| The new version adds a response code '200'. New: Microsoft.EventGrid/preview/2020-10-01-preview/EventGrid.json#L1822:11 |
|
| The new version adds a response code '200'. New: Microsoft.EventGrid/preview/2020-10-01-preview/EventGrid.json#L3142:11 |
|
| The new version adds a response code '200'. New: Microsoft.EventGrid/preview/2020-10-01-preview/EventGrid.json#L4778:11 |
|
| The new version adds a response code 'default'. New: Microsoft.EventGrid/preview/2020-10-01-preview/EventGrid.json#L5517:11 |
|
| The new version adds a response code '200'. New: Microsoft.EventGrid/preview/2020-10-01-preview/EventGrid.json#L1385:11 |
️️✔️~[Staging] Cross Version BreakingChange (Base on stable version) succeeded [Detail]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.1)
- original: stable/2020-06-01/EventGrid.json <---> new: preview/2020-10-01-preview/EventGrid.json
Swagger Generation Artifacts
|
|
Hi, @batrived Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi, @batrived your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @ChenTanyi |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
Azure CLI Extension Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js
|
azure-sdk-for-go
|
azure-sdk-for-java
|
azure-sdk-for-net
|
Trenton Generation
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-python-track2
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
This was referenced Nov 4, 2020
This was referenced Nov 4, 2020
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Contributor
Author
We have designed it with 1:N mapping of CustomLocations to KubernetesBroker in mind. Although, customLocation is not needed in Topic when kubernetesBrokerArmId is present but CustomLocations team asked to put it here as well as ARM is going to do some validations based on the customLocation property on the resource. |
Contributor
|
We discussed this scenario in the ARM API Review board and with ARC team and here is our recommendation
|
|
Hi, batrived. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ravbhatnagar
removed
the
WaitForARMFeedback
Contributor
|
No activity for a long time. please re-add ARM feedback label if you need a review from ARM. removing to reduce noise. |
|
Hi, @batrived. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
ghost
closed this
|
Hi, @batrived. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.