-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add device principal type #13799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device principal type #13799
Conversation
|
Hi, @jdhms Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isOrganizationDefault Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isApprovalRequired Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isApprovalRequiredForExtension Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isRequestorJustificationRequired Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isApproverJustificationRequired Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEscalationEnabled Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isBackup Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnabled Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isExpirationRequired Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDefaultRecipientsEnabled Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
There are no breaking changes.
- Compared Swaggers (Based on Oad v0.8.8)
️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 5 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.8.8)
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- authorization/resource-manager/readme.md#package-2021-03-01-preview-only
- authorization/resource-manager/readme.md#package-2020-10-01-preview
- authorization/resource-manager/readme.md#package-2020-08-01-preview
- authorization/resource-manager/readme.md#package-2020-04-01-preview
- authorization/resource-manager/readme.md#package-2020-04-01-preview-only
- authorization/resource-manager/readme.md#package-2020-03-01-preview
- authorization/resource-manager/readme.md#package-2018-09-01-preview
- authorization/resource-manager/readme.md#package-2018-09-01-preview-only
- authorization/resource-manager/readme.md#package-2018-07-01-preview
- authorization/resource-manager/readme.md#package-2018-07-01-preview-only
- authorization/resource-manager/readme.md#package-2018-05-01-preview
- authorization/resource-manager/readme.md#package-2018-01-01-preview
- authorization/resource-manager/readme.md#package-2018-01-01-preview-only
- authorization/resource-manager/readme.md#package-2017-10-01-preview
- authorization/resource-manager/readme.md#package-2017-10-01-preview-only
- authorization/resource-manager/readme.md#package-2015-07-01
- authorization/resource-manager/readme.md#package-2015-06-01-preview
- authorization/resource-manager/readme.md#profile-hybrid-2020-09-01
- authorization/resource-manager/readme.md#profile-hybrid-2019-03-01
- authorization/resource-manager/readme.md#package-2021-01-01-preview-only
| Rule | Message |
|---|---|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-03-01-preview-only", "details":"Schema 'AccessReviewDecisionUserIdentity' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2021-03-01-preview-only", "details":"Schema 'AccessReviewDecisionServicePrincipalIdentity' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2018-05-01-preview", "details":"Schema 'UserDecisionTarget' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"authorization/resource-manager/readme.md", "tag":"package-2018-05-01-preview", "details":"Schema 'ServicePrincipalDecisionTarget' has an allOf list with an empty object schema as a parent, removing it." |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
fc02392 to
43c4d2a
Compare
|
Hi @jdhms, Your PR has some issues. Please fix the CI sequentially by following the order of
|
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.