Skip to content

Conversation

@jdhms
Copy link
Contributor

@jdhms jdhms commented Apr 6, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@jdhms jdhms requested a review from stankovski as a code owner April 6, 2021 20:35
@openapi-workflow-bot
Copy link

Hi, @jdhms Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 6, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isOrganizationDefault
    Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isApprovalRequired
    Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isApprovalRequiredForExtension
    Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isRequestorJustificationRequired
    Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isApproverJustificationRequired
    Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEscalationEnabled
    Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isBackup
    Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isEnabled
    Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isExpirationRequired
    Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDefaultRecipientsEnabled
    Location: azure-rest-api-specs/blob/99095a4aab608ff1928517d617c709ec988aabb6/undefined#Lundefined
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️[Staging] Cross Version BreakingChange (Base on preview version) succeeded [Detail] [Expand]
    There are no breaking changes.

    ️⚠️[Staging] Cross Version BreakingChange (Base on stable version): 5 Warnings warning [Detail]
    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/{resourceProviderNamespace}/{parentResourcePath}/{resourceType}/{resourceName}/providers/Microsoft.Authorization/roleAssignments' removed or restructured?
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L37:5
    ⚠️ 1008 - ModifiedOperationId The operation id has been changed from 'RoleAssignments_List' to 'RoleAssignments_ListForSubscription'. This will impact generated code.
    New: Microsoft.Authorization/preview/2020-10-01-preview/authorization-RoleAssignmentsCalls.json#L38:7
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L451:7
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '200'.
    New: Microsoft.Authorization/preview/2020-10-01-preview/authorization-RoleAssignmentsCalls.json#L246:11
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '200'.
    New: Microsoft.Authorization/preview/2020-10-01-preview/authorization-RoleAssignmentsCalls.json#L459:11
    ⚠️ 1034 - AddedRequiredProperty The new version has new required property 'roleDefinitionId, principalId' that was not found in the old version.
    New: Microsoft.Authorization/preview/2020-10-01-preview/authorization-RoleAssignmentsCalls.json#L715:9
    Old: Microsoft.Authorization/stable/2015-07-01/authorization-RoleAssignmentsCalls.json#L594:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️[Staging] SDK Track2 Validation: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ PreCheck/EmptyParentSchemaWarning "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2021-03-01-preview-only",
    "details":"Schema 'AccessReviewDecisionUserIdentity' has an allOf list with an empty object schema as a parent,
    removing it."
    ⚠️ PreCheck/EmptyParentSchemaWarning "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2021-03-01-preview-only",
    "details":"Schema 'AccessReviewDecisionServicePrincipalIdentity' has an allOf list with an empty object schema as a parent,
    removing it."
    ⚠️ PreCheck/EmptyParentSchemaWarning "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2018-05-01-preview",
    "details":"Schema 'UserDecisionTarget' has an allOf list with an empty object schema as a parent,
    removing it."
    ⚠️ PreCheck/EmptyParentSchemaWarning "readme":"authorization/resource-manager/readme.md",
    "tag":"package-2018-05-01-preview",
    "details":"Schema 'ServicePrincipalDecisionTarget' has an allOf list with an empty object schema as a parent,
    removing it."
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 6, 2021

    Swagger Generation Artifacts

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a2c473d. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	go run ./tools/generator/main.go ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️authorization/mgmt/2015-07-01/authorization [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `ProviderOperationsMetadataClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
      info	[Changelog] - Function `ProviderOperationsMetadataClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
      info	[Changelog] - Function `ProviderOperationsMetadataClient.Get` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
      info	[Changelog] - Function `ProviderOperationsMetadataClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
      info	[Changelog] - Function `ProviderOperationsMetadataClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New struct `ErrorAdditionalInfo`
      info	[Changelog] - New struct `ErrorDetail`
      info	[Changelog] - New struct `ErrorResponse`
      info	[Changelog]
      info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
      info	[Changelog]
    • ️✔️preview/authorization/mgmt/2020-04-01-preview/authorization [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Struct `CustomErrorResponse` has been removed
      info	[Changelog]
      info	[Changelog] Total 2 breaking change(s), 0 additive change(s).
      info	[Changelog]
    • ️✔️preview/authorization/mgmt/2018-09-01-preview/authorization [View full logs]  [Release SDK Changes]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New struct `ErrorAdditionalInfo`
      info	[Changelog] - New struct `ErrorDetail`
      info	[Changelog] - New struct `ErrorResponse`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
      info	[Changelog]
    • ️✔️preview/authorization/mgmt/2018-07-01-preview/authorization [View full logs]  [Release SDK Changes]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New struct `ErrorAdditionalInfo`
      info	[Changelog] - New struct `ErrorDetail`
      info	[Changelog] - New struct `ErrorResponse`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
      info	[Changelog]
    • ️✔️preview/authorization/mgmt/2018-01-01-preview/authorization [View full logs]  [Release SDK Changes]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New struct `ErrorAdditionalInfo`
      info	[Changelog] - New struct `ErrorDetail`
      info	[Changelog] - New struct `ErrorResponse`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 6 additive change(s).
      info	[Changelog]
    • ️✔️preview/authorization/mgmt/2017-10-01-preview/authorization [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `ProviderOperationsMetadataClient.GetPreparer` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
      info	[Changelog] - Function `ProviderOperationsMetadataClient.ListComplete` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
      info	[Changelog] - Function `ProviderOperationsMetadataClient.ListPreparer` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
      info	[Changelog] - Function `ProviderOperationsMetadataClient.Get` parameter(s) have been changed from `(context.Context, string, string, string)` to `(context.Context, string, string)`
      info	[Changelog] - Function `ProviderOperationsMetadataClient.List` parameter(s) have been changed from `(context.Context, string, string)` to `(context.Context, string)`
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New struct `ErrorAdditionalInfo`
      info	[Changelog] - New struct `ErrorDetail`
      info	[Changelog] - New struct `ErrorResponse`
      info	[Changelog]
      info	[Changelog] Total 5 breaking change(s), 6 additive change(s).
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a2c473d. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-04-09 02:15:03 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-authorization-generated"
      cmderr	[generate.py] 2021-04-09 02:15:03 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
      cmderr	[generate.py] 2021-04-09 02:15:03 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/authorization/azure-resourcemanager-authorization-generated --java.namespace=com.azure.resourcemanager.authorization.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
      cmderr	[generate.py] 2021-04-09 02:15:31 INFO [CI][Success] Write to ci.yml
      cmderr	[generate.py] 2021-04-09 02:15:31 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-04-09 02:15:31 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-04-09 02:15:31 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-04-09 02:15:31 INFO [POM][Skip] pom already has module sdk/authorization
      cmderr	[generate.py] 2021-04-09 02:15:31 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-authorization-generated [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-04-09 02:18:58 DEBUG Got artifact_id: azure-resourcemanager-authorization-generated
      cmderr	[Inst] 2021-04-09 02:18:58 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-04-09 02:18:58 DEBUG Got artifact: azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-04-09 02:18:58 DEBUG Match jar package: azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar
      cmderr	[Inst] 2021-04-09 02:18:58 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13799/azure-sdk-for-java/azure-resourcemanager-authorization-generated/azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-authorization-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-authorization-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️🔄 azure-sdk-for-net inProgress [Detail]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a2c473d. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
    • ️✔️@azure/arm-authorization [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/authorizationManagementClient.js → ./dist/arm-authorization.js...
      cmderr	[npmPack] created ./dist/arm-authorization.js in 216ms
    ️⚠️ azure-sdk-for-python warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a2c473d. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️azure-mgmt-authorization [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model RoleAssignmentCreateParameters has a new parameter delegated_managed_identity_resource_id
      info	[Changelog]   - Model RoleAssignment has a new parameter created_by
      info	[Changelog]   - Model RoleAssignment has a new parameter updated_by
      info	[Changelog]   - Model RoleAssignment has a new parameter created_on
      info	[Changelog]   - Model RoleAssignment has a new parameter updated_on
      info	[Changelog]   - Model RoleAssignment has a new parameter delegated_managed_identity_resource_id
      info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalStepsOperations
      info	[Changelog]   - Added operation group AccessReviewInstancesOperations
      info	[Changelog]   - Added operation group AccessReviewInstanceDecisionsOperations
      info	[Changelog]   - Added operation group Operations
      info	[Changelog]   - Added operation group RoleAssignmentApprovalStepsOperations
      info	[Changelog]   - Added operation group RoleAssignmentApprovalStepOperations
      info	[Changelog]   - Added operation group AccessReviewInstanceOperations
      info	[Changelog]   - Added operation group AccessReviewDefaultSettingsOperations
      info	[Changelog]   - Added operation group AccessReviewInstancesAssignedForMyApprovalOperations
      info	[Changelog]   - Added operation group RoleAssignmentApprovalOperations
      info	[Changelog]   - Added operation group AccessReviewScheduleDefinitionsOperations
      info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalStepOperations
      info	[Changelog]   - Added operation group ScopeRoleAssignmentApprovalOperations
      info	[Changelog]   - Added operation group AccessReviewScheduleDefinitionsAssignedForMyApprovalOperations
      info	[Changelog]   - Added operation group AccessReviewInstanceMyDecisionsOperations
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Failed [Logs]Release - Generate from a2c473d. Schema Automation 14.0.0
      warn	Skip initScript due to not configured
      command	npx n 12
      command	autorest --use=@autorest/[email protected] --version=3.0.6374 --azureresourceschema --multiapi --title=none --pass-thru:subset-reducer --azureresourceschema-folder=/home/vsts/work/1/s/azure-resource-manager-schemas/azure-resource-manager-schemas ../../azure-rest-api-specs/specification/authorization/resource-manager/readme.md
      cmdout	[Autorest] WARNING: Skipping path '/{roleId}': Unable to locate '/providers/' segment
      cmderr	[Autorest] Failure during batch task - {"tag":"schema-authorization-2020-03-01-preview"} -- Error: Could not read 'file:///home/vsts/work/1/s/azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-03-01-preview/authorization-ClassicAdminCalls.json'..
      cmderr	[Autorest]   Error: Could not read 'file:///home/vsts/work/1/s/azure-rest-api-specs/specification/authorization/resource-manager/Microsoft.Authorization/preview/2020-03-01-preview/authorization-ClassicAdminCalls.json'.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas/azure-resource-manager-schemas]: autorest
      warn	Skip package processing as generation is failed
    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @jdhms jdhms changed the title Auth 2020 10 01 preview Add device principal type Apr 6, 2021
    @openapi-workflow-bot
    Copy link

    Hi @jdhms, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff.

    TaskHow to fixPrioritySupport (Microsoft alias)
    AvocadoFix-AvocadoHighruowan
    Semantic validationFix-SemanticValidation-ErrorHighraychen, jianyxi
    Model validationFix-ModelValidation-ErrorHighraychen,jianyxi
    LintDiffFix-LintDiffhighjianyxi, ruoxuan
    If you need further help, please feedback via swagger feedback."

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants