Skip to content

extract AutomationRules to new file #15075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leniatgh merged 11 commits into from
Jul 6, 2021
Merged

extract AutomationRules to new file #15075

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5b352b4
extract AutomationRules to new file
moranraz Jul 4, 2021
debd1a9
fix errors
moranraz Jul 4, 2021
50437ed
change ResourceWithEtag
moranraz Jul 4, 2021
5e63d2c
update readme
moranraz Jul 5, 2021
9f04a23
change resource and subscriptionId
moranraz Jul 5, 2021
1dd2079
add bracket
moranraz Jul 5, 2021
1eec4cc
.
moranraz Jul 5, 2021
dea0336
.
moranraz Jul 5, 2021
2a90598
.
moranraz Jul 5, 2021
0c2ec33
revert common definitons
moranraz Jul 5, 2021
ff9585f
.
moranraz Jul 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update readme
  • Loading branch information
@moranraz
moranraz committed Jul 5, 2021
commit 5e63d2c4b8572d004820222e263e36c9461e8824
14 changes: 3 additions & 11 deletions ...source-manager/Microsoft.SecurityInsights/preview/2019-01-01-preview/AutomationRules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/SubscriptionId"
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ResourceGroupName"
Expand Down Expand Up @@ -99,7 +99,7 @@
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/SubscriptionId"
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ResourceGroupName"
Expand Down Expand Up @@ -145,7 +145,7 @@
"$ref": "#/parameters/ApiVersion"
},
{
"$ref": "#/parameters/SubscriptionId"
"$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/SubscriptionIdParameter"
},
{
"$ref": "#/parameters/ResourceGroupName"
Expand Down Expand Up @@ -280,14 +280,6 @@
"type": "string",
"x-ms-parameter-location": "method"
},
"SubscriptionId": {
"description": "Azure subscription ID",
"in": "path",
"name": "subscriptionId",
"pattern": "^[0-9A-Fa-f]{8}-([0-9A-Fa-f]{4}-){3}[0-9A-Fa-f]{12}$",
"required": true,
"type": "string"
},
"WorkspaceName": {
"description": "The name of the workspace.",
"in": "path",
Expand Down
4 changes: 4 additions & 0 deletions specification/securityinsights/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,10 @@ directive:
from: Microsoft.SecurityInsights/preview/2019-01-01-preview/SecurityInsights.json
where: $.definitions.AutomationRule
reason: The AutomationRule does not support list by subscription. It's not a top-level resource. To get the AutomationRule, we should have a subscription as well as a resource group and Log Analytics workspace.
- suppress: R4017
from: Microsoft.SecurityInsights/preview/2019-01-01-preview/AutomationRules.json
where: $.definitions.AutomationRule
reason: The AutomationRule does not support list by subscription. It's not a top-level resource. To get the AutomationRule, we should have a subscription as well as a resource group and Log Analytics workspace.
```

---
Expand Down