Skip to content

Conversation

@felixwa
Copy link
Contributor

@felixwa felixwa commented Aug 25, 2017

Mark id/kind/type fields as readOnly to make "AutoRest --azure-validator
--openapi-type=arm" happy.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

Mark id/kind/type fields as readOnly to make "AutoRest --azure-validator
--openapi-type=arm" happy.
@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/cognitiveservices/resource-manager/readme.md
Before the PR: Warning(s): 4 Error(s): 1
After the PR: Warning(s): 4 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@felixwa
Copy link
Contributor Author

felixwa commented Aug 25, 2017

This PR fixes an Error (can be seen from Linter Azure bot):

Before the PR: Warning(s): 4 Error(s): 1
After the PR: Warning(s): 4 Error(s): 0

@balajikris
Copy link
Contributor

Notice that this will be a breaking change for the SDKs, if you had shipped the existing schema as SDK packages. Make sure to version the newly generated packages appropriately to reflect the breaking change.

@balajikris
Copy link
Contributor

while at it, can you also fix this failure in examples validation? : https://travis-ci.org/Azure/azure-rest-api-specs/jobs/268246587

@felixwa
Copy link
Contributor Author

felixwa commented Aug 28, 2017

@balajikris , the validate-example issue (the type can be null) has been there for a while and last time @veronicagg mentioned that is because the issue of the validation tool. See: #798
Since the issue is still open I don't think I can fix it now.

@balajikris balajikris merged commit a155b5c into Azure:current Aug 28, 2017
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link

@AutorestCI
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants