-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Cognitive Services] Mark id/kind/type fields as readOnly #1589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Mark id/kind/type fields as readOnly to make "AutoRest --azure-validator --openapi-type=arm" happy.
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues Send feedback and make AutoRest Linter Azure Bot smarter day by day! Thanks for your co-operation. |
|
This PR fixes an Error (can be seen from Linter Azure bot): Before the PR: Warning(s): 4 Error(s): 1 |
|
Notice that this will be a breaking change for the SDKs, if you had shipped the existing schema as SDK packages. Make sure to version the newly generated packages appropriately to reflect the breaking change. |
|
while at it, can you also fix this failure in examples validation? : https://travis-ci.org/Azure/azure-rest-api-specs/jobs/268246587 |
|
@balajikris , the validate-example issue (the type can be null) has been there for a while and last time @veronicagg mentioned that is because the issue of the validation tool. See: #798 |
|
No modification for AutorestCI/azure-sdk-for-node |
Mark id/kind/type fields as readOnly to make "AutoRest --azure-validator
--openapi-type=arm" happy.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger