Skip to content

Conversation

@sonathan
Copy link
Contributor

@sonathan sonathan commented Aug 31, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@msftclas
Copy link

@sonathan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/recoveryservices/resource-manager/readme.md
Before the PR: Warning(s): 28 Error(s): 40
After the PR: Warning(s): 28 Error(s): 40

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@sonathan
Copy link
Contributor Author

@veronicagg Here is the updated PR for following: #1453

Copy link
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sonathan for re-sending this PR.
We had already reviewed all content, so looks good.
Just one left over question from the other PR, which I added inline.
After confirmation on that, it can be approved and merged.
Thanks!

"description": "Blob duration.",
"format": "date-time",
"type": "string",
"readOnly": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonathan per our conversation regarding this property, should thedescription be updated to include more info on what the field is expected to look? Per your comment in the referred, closed PR:
"As this field is in Response and Shoebox creates blobs in customer storage account every hour. The value PT1H indicates blobs per hour. "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. Updated now.

@veronicagg veronicagg assigned veronicagg and unassigned sarangan12 Aug 31, 2017
@veronicagg
Copy link
Contributor

Updating assignment, since I already reviewed this PR, this was just reopening it.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/recoveryservices/resource-manager/readme.md
Before the PR: Warning(s): 28 Error(s): 40
After the PR: Warning(s): 28 Error(s): 40

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@sonathan
Copy link
Contributor Author

sonathan commented Sep 5, 2017

@veronicagg Please let me know if there are still any pending changes that needs to be done before merging. Thanks a lot.

@veronicagg veronicagg merged commit f21daff into Azure:current Sep 5, 2017
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

1 similar comment
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link

@AutorestCI
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants