-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Updating Operations API to support Python's AutoRest #1619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ns.json with correct API-Version
|
@sonathan, |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues Send feedback and make AutoRest Linter Azure Bot smarter day by day! Thanks for your co-operation. |
|
@veronicagg Here is the updated PR for following: #1453 |
veronicagg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sonathan for re-sending this PR.
We had already reviewed all content, so looks good.
Just one left over question from the other PR, which I added inline.
After confirmation on that, it can be approved and merged.
Thanks!
| "description": "Blob duration.", | ||
| "format": "date-time", | ||
| "type": "string", | ||
| "readOnly": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sonathan per our conversation regarding this property, should thedescription be updated to include more info on what the field is expected to look? Per your comment in the referred, closed PR:
"As this field is in Response and Shoebox creates blobs in customer storage account every hour. The value PT1H indicates blobs per hour. "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. Updated now.
|
Updating assignment, since I already reviewed this PR, this was just reopening it. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues Send feedback and make AutoRest Linter Azure Bot smarter day by day! Thanks for your co-operation. |
|
@veronicagg Please let me know if there are still any pending changes that needs to be done before merging. Thanks a lot. |
|
No modification for AutorestCI/azure-sdk-for-node |
1 similar comment
|
No modification for AutorestCI/azure-sdk-for-node |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger