-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Rename appliance to managed application #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@vivsriaus You have marked this PR do not merge. Is that still valid? Do you want this PR merge? |
1 similar comment
|
@vivsriaus You have marked this PR do not merge. Is that still valid? Do you want this PR merge? |
|
@sarangan12 we're still waiting to finalize the api on our service end. I should be able to get back on this by early next week. Please keep the PR active for now. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues Send feedback and make AutoRest Linter Azure Bot smarter day by day! Thanks for your co-operation. |
|
@ravbhatnagar fyi |
… into AddApplianceNew
|
@vivsriaus Please take a look at https://travis-ci.org/Azure/azure-rest-api-specs/builds/274775514?utm_source=github_status&utm_medium=notification Under allowed failures, specifically look at linter, model and semantic validations. The errors must be fixed for the approval of this PR. Please fix the errors and update the PR |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues Send feedback and make AutoRest Linter Azure Bot smarter day by day! Thanks for your co-operation. |
|
@sarangan12 Not sure why this error shows up. I don't see duplicate paths in my file. { code: 'SEMANTIC_VALIDATION_ERROR', |
|
There are no microsoft.solutions errors in model, and in linter, all the errors are for the older file, not for the new one. Can you please take a look? @sarangan12 |
| @@ -0,0 +1,43 @@ | |||
| { | |||
| "parameters": { | |||
| "subscriptionId": "subid", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not full name? subscriptionId?
|
No modification for AutorestCI/azure-sdk-for-node |
Rename appliance to managed application, and update api version
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger