Skip to content

Conversation

@vivsriaus
Copy link
Contributor

@vivsriaus vivsriaus commented Sep 5, 2017

Rename appliance to managed application, and update api version

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@sarangan12
Copy link
Contributor

@vivsriaus You have marked this PR do not merge. Is that still valid? Do you want this PR merge?

1 similar comment
@sarangan12
Copy link
Contributor

@vivsriaus You have marked this PR do not merge. Is that still valid? Do you want this PR merge?

@vivsriaus
Copy link
Contributor Author

@sarangan12 we're still waiting to finalize the api on our service end. I should be able to get back on this by early next week. Please keep the PR active for now.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/resources/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@vivsriaus vivsriaus changed the title [do not merge] Rename appliance to managed application Rename appliance to managed application Sep 13, 2017
@vivsriaus
Copy link
Contributor Author

@ravbhatnagar fyi

@sarangan12
Copy link
Contributor

@vivsriaus Please take a look at https://travis-ci.org/Azure/azure-rest-api-specs/builds/274775514?utm_source=github_status&utm_medium=notification

Under allowed failures, specifically look at linter, model and semantic validations. The errors must be fixed for the approval of this PR.

Please fix the errors and update the PR

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/resources/resource-manager/readme.md
Before the PR: Warning(s): 28 Error(s): 56
After the PR: Warning(s): 28 Error(s): 56

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@vivsriaus
Copy link
Contributor Author

@sarangan12 Not sure why this error shows up. I don't see duplicate paths in my file.

{ code: 'SEMANTIC_VALIDATION_ERROR',
id: 'OAV119',
message: 'The spec /home/travis/build/Azure/azure-rest-api-specs/specification/resources/resource-manager/Microsoft.Solutions/2017-09-01/managedapplications.json has semantic validation errors.',
innerErrors:
[ { code: 'EQUIVALENT_PATH',
message: 'Equivalent path already exists: /{applicationDefinitionId}',
path: [ 'paths', '/{applicationDefinitionId}' ] } ] }

@vivsriaus
Copy link
Contributor Author

There are no microsoft.solutions errors in model, and in linter, all the errors are for the older file, not for the new one. Can you please take a look? @sarangan12

@@ -0,0 +1,43 @@
{
"parameters": {
"subscriptionId": "subid",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not full name? subscriptionId?

@AutorestCI
Copy link

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants