Skip to content

Rename SKUs to help Autorest generating a good name #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amarzavery merged 3 commits into from
Sep 11, 2017
Merged

Rename SKUs to help Autorest generating a good name #1650

amarzavery merged 3 commits into from
Sep 11, 2017

Conversation

@lmazuel
Copy link
Member

@lmazuel lmazuel commented Sep 8, 2017 •
edited by azuresdkci
Loading

Fix bad naming with Autorest:

  • SKUs gives sk_us_operations
  • Skus gives skus_operations

@lmazuel lmazuel mentioned this pull request Sep 8, 2017
Closed
amarzavery
amarzavery reviewed Sep 8, 2017
View reviewed changes
specification/storage/resource-manager/Microsoft.Storage/2017-06-01/storage.json Outdated
"/subscriptions/{subscriptionId}/providers/Microsoft.Storage/skus": {
"get": {
"tags": [
"SKU"
Copy link
Contributor

@amarzavery amarzavery Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skus

specification/storage/resource-manager/Microsoft.Storage/2017-06-01/storage.json Outdated
"operationId": "Skus_List",
"description": "Lists the available SKUs supported by Microsoft.Storage for given subscription.",
"x-ms-examples": {
"SKUList": { "$ref": "./examples/SKUList.json" }
Copy link
Contributor

@amarzavery amarzavery Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SkuList.

To be consistent.

Copy link
Member Author

@lmazuel lmazuel Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the tags to Skus is this enough? I would prefer the s, for consistency with StorageAccounts

@azuresdkciprbot
Copy link

azuresdkciprbot commented Sep 8, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/storage/resource-manager/readme.md
Before the PR: Warning(s): 12 Error(s): 0
After the PR: Warning(s): 12 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@amarzavery amarzavery merged commit 87c3a2d into Azure:current Sep 11, 2017
@amarzavery
Copy link
Contributor

amarzavery commented Sep 11, 2017

@JasonYang-MSFT - The PR has been merged. Please regenerate the node sdk for storage management and update the existing PR.

@AutorestCI
Copy link

AutorestCI commented Sep 11, 2017

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Sep 11, 2017
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 11, 2017

Build Status Azure/azure-sdk-for-python#1428

@AutorestCI AutorestCI mentioned this pull request Sep 11, 2017
Merged
@AutorestCI
Copy link

AutorestCI commented Sep 11, 2017

Build Status Azure/azure-sdk-for-ruby#965

@JasonYang-MSFT JasonYang-MSFT mentioned this pull request Sep 12, 2017
Merged
8 tasks
@lmazuel lmazuel deleted the skusfix branch November 8, 2017 18:39
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@fengzhou-msft
Merge pull request #1650 from samsaha-ms/dev-elastic-Microsoft.Elasti…
6b3397f 
…c-2020-07-01--preview

Review request for Microsoft.Elastic to add version preview/2020-07-01-preview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JasonYang-MSFT JasonYang-MSFT JasonYang-MSFT approved these changes

+1 more reviewer

@amarzavery amarzavery amarzavery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jhendrixMSFT jhendrixMSFT

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lmazuel @azuresdkciprbot @amarzavery @AutorestCI @JasonYang-MSFT @msftclas @jhendrixMSFT