-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Compute] AZ, Vmss rolling upgrade, Vmss patch and Vm instance view APIs #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "description": "The expand expression to apply on the operation.", | ||
| "enum": [ | ||
| "instanceView" | ||
| "InstanceView" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that there are breaking changes in enum values. The casing has been changed and the api-version has also not been bumped. However @ravbhatnagar from ARM team has signed off over here. Hence I am signing off as well.
|
Hi @hyonholee - There are model validation failures https://travis-ci.org/Azure/azure-rest-api-specs/jobs/278746508#L625. Can you please fix that? Either the examples are wrong or the spec is incorrect. |
|
@anuchandy - Please review. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: 💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡 AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
@hyonholee - Looks like there is an incorrect json in one of the examples edited by you. https://travis-ci.org/Azure/azure-rest-api-specs/jobs/279629634#L680 |
| "name": "myVM" | ||
| } | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hyonholee - Remove the trailing comma. That makes an incorrect json.
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: 💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡 AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
No modification for AutorestCI/azure-sdk-for-node |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger