Skip to content

Conversation

@hyonholee
Copy link
Contributor

@hyonholee hyonholee commented Sep 22, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@hyonholee hyonholee changed the title Compute AZ, Vmss rolling upgrade, Vmss patch and Vm instance view APIs [Compute] Compute AZ, Vmss rolling upgrade, Vmss patch and Vm instance view APIs Sep 22, 2017
@hyonholee hyonholee changed the title [Compute] Compute AZ, Vmss rolling upgrade, Vmss patch and Vm instance view APIs [Compute] AZ, Vmss rolling upgrade, Vmss patch and Vm instance view APIs Sep 22, 2017
@olydis olydis assigned amarzavery and unassigned olydis Sep 22, 2017
"description": "The expand expression to apply on the operation.",
"enum": [
"instanceView"
"InstanceView"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that there are breaking changes in enum values. The casing has been changed and the api-version has also not been bumped. However @ravbhatnagar from ARM team has signed off over here. Hence I am signing off as well.

@amarzavery
Copy link
Contributor

Hi @hyonholee - There are model validation failures https://travis-ci.org/Azure/azure-rest-api-specs/jobs/278746508#L625. Can you please fix that? Either the examples are wrong or the spec is incorrect.

@amarzavery
Copy link
Contributor

@anuchandy - Please review.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 116 Error(s): 31
After the PR: Warning(s): 135 Error(s): 36

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@amarzavery
Copy link
Contributor

@hyonholee - Looks like there is an incorrect json in one of the examples edited by you. https://travis-ci.org/Azure/azure-rest-api-specs/jobs/279629634#L680

"name": "myVM"
}
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyonholee - Remove the trailing comma. That makes an incorrect json.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 116 Error(s): 31
After the PR: Warning(s): 135 Error(s): 36

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link

@AutorestCI
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants