-
Notifications
You must be signed in to change notification settings - Fork 5.6k
CSharp namespace for resource-manager, move data-plane API specs to resource-manager, remove UsageMetrics API from the spec #1886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…zure#1838: move data-plane API specs to resource-manager, Azure#1839: remove UsageMetrics API from the spec
|
Related PR #1840. |
|
@gucalder could you login to Travic-CI, at least once, so we start the CI? |
|
I just did. Travis responded this: We've successfully synchronized your details from GitHub. |
|
@gucalder thanks. It looks like the CI is triggered after I reopened the PR. |
|
Great. Thank you! |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
|
The errors reported are known:
|
|
@sergey-shandar Any concerns here? I need a new SDK for Python and CLI (FYI @troydai ) |
|
@gucalder the changes are LGTM. Have you tried to generate C# SDK with this changes? |
|
I generated the code from the branch: Seems good to me, I see no obvious reason to do not merge. |
|
No modification for AutorestCI/azure-sdk-for-node |
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
Fixing issues
•#1837: [Monitor] The namespace for C# code of resource-manager folder is incorrect fix cSharp namespace for resource-manager,
•#1838: [Monitor] Move the specs in the folder data-plane to the resource-manager folder : move data-plane API specs to resource-manager,
•#1839: remove UsageMetrics API from the spec
api-versionin the path should match theapi-versionin the spec).Quality of Swagger