Skip to content

Conversation

@gucalder
Copy link
Contributor

@gucalder gucalder commented Oct 18, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.

Fixing issues
#1837: [Monitor] The namespace for C# code of resource-manager folder is incorrect fix cSharp namespace for resource-manager,
#1838: [Monitor] Move the specs in the folder data-plane to the resource-manager folder : move data-plane API specs to resource-manager,
#1839: remove UsageMetrics API from the spec

  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

…zure#1838: move data-plane API specs to resource-manager, Azure#1839: remove UsageMetrics API from the spec
@sergey-shandar
Copy link
Contributor

Related PR #1840.

@sergey-shandar
Copy link
Contributor

@gucalder could you login to Travic-CI, at least once, so we start the CI?

@gucalder
Copy link
Contributor Author

I just did. Travis responded this: We've successfully synchronized your details from GitHub.
We will redirect you to your profile in a few seconds.

@sergey-shandar
Copy link
Contributor

@gucalder thanks. It looks like the CI is triggered after I reopened the PR.

@gucalder
Copy link
Contributor Author

Great. Thank you!

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/monitor/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 4
After the PR: Warning(s): 0 Error(s): 4

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@gucalder
Copy link
Contributor Author

gucalder commented Oct 20, 2017

The errors reported are known:

  • Three are due to a incorrect firing of a rule when checking the "odata.type" property for polymorphic types.
  • The other error is that we are missing the PATCH in one of our APIs. The team in charge has planned to specify it (it is already implemented in their backend) in November/December if I am not wrong.

@lmazuel
Copy link
Member

lmazuel commented Oct 23, 2017

@sergey-shandar Any concerns here? I need a new SDK for Python and CLI (FYI @troydai )

@sergey-shandar
Copy link
Contributor

@gucalder the changes are LGTM. Have you tried to generate C# SDK with this changes?

@lmazuel
Copy link
Member

lmazuel commented Oct 23, 2017

I generated the code from the branch:
Azure/azure-sdk-for-python#1563

Seems good to me, I see no obvious reason to do not merge.

@sergey-shandar sergey-shandar merged commit 01f6b08 into Azure:current Oct 24, 2017
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link

@AutorestCI
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants