Skip to content

Redis API changes to support zones #1915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veronicagg merged 10 commits into from
Nov 2, 2017
Merged

Redis API changes to support zones #1915

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4841dd5
Create 2017-10-01 API version placeholder
hrishikeshpathak Oct 26, 2017
9eec3d7
Changes for 2017-10-01 API version: Support for Availability Zones
hrishikeshpathak Oct 26, 2017
0660817
Fix Travis CI build error. Add location and sku to the update request
hrishikeshpathak Oct 26, 2017
89fec95
fix Travis CI linter errors.
hrishikeshpathak Oct 26, 2017
9977344
Fix more travis ci errors. Remvoe location from patchschedules and Re…
hrishikeshpathak Oct 26, 2017
61e0e37
change the RedisForceRebootResponse property to camel case
hrishikeshpathak Nov 1, 2017
ad4f5cd
Fix the response body in the example
hrishikeshpathak Nov 1, 2017
2c2a2ec
Update readme.md file to include the new package, add suppression for…
hrishikeshpathak Nov 2, 2017
948f4c5
Add suppression correctly
hrishikeshpathak Nov 2, 2017
60a1872
Remove tabs add spaces
hrishikeshpathak Nov 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add suppression correctly
  • Loading branch information
@hrishikeshpathak
hrishikeshpathak committed Nov 2, 2017
commit 948f4c52318a1b345ff57ea9ef7454460d99fcd4
17 changes: 13 additions & 4 deletions specification/redis/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,6 @@ csharp:
namespace: Microsoft.Azure.Management.Redis
output-folder: $(csharp-sdks-folder)/RedisCache/Management.Redis/Generated
clear-output-folder: true
directive:
- from: Microsoft.Azure.Management.Redis
suppress:
- R3006
```


Expand Down Expand Up @@ -139,3 +135,16 @@ Please also specify `--go-sdk-folder=<path to the root directory of your azure-s
``` yaml $(tag) == 'package-2015-08' && $(go)
output-folder: $(go-sdk-folder)/services/redis/mgmt/2015-08-01/cache
```

# Validation

## Suppression

``` yaml
directive:
- suppress: R3006 # Model definition 'RedisResource' has extra properties ['zones']."
where:
- $.definitions.RedisResource.properties
from: redis.json
reason: zones properties will be allowed in subsequent version of the linter tool
```