Skip to content

Remove x-ms-external property for Redis 2022-05-01 and 2021-06-01 API versions #20837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akning-ms merged 2 commits into from
Oct 5, 2022
Merged

Remove x-ms-external property for Redis 2022-05-01 and 2021-06-01 API versions #20837

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
141ac94
remove x-ms-external tag for 2022-05-01 API version
austintolani Sep 22, 2022
6346d5c
remove x-ms-external tag for 2021-06-01 API version
austintolani Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove x-ms-external tag for 2021-06-01 API version
  • Loading branch information
@austintolani
austintolani committed Sep 22, 2022
commit 6346d5cba6cc3d44fcca572cbbe63850ee2257ad
3 changes: 1 addition & 2 deletions specification/redis/resource-manager/Microsoft.Cache/stable/2021-06-01/redis.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2812,8 +2812,7 @@
{
"$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/OperationStatusResult"
}
],
"x-ms-external": true
Copy link
Contributor

@akning-ms akning-ms Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to remove this?

Copy link
Contributor Author

@austintolani austintolani Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akning-ms its inclusion is creating problems when generating our .NET SDK. It seems like it should have never been set in the first place.

Copy link
Contributor

@akning-ms akning-ms Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it seems caused GO & JS breaking change. @tadelesh @qiaozha to confirm

Copy link
Member

@tadelesh tadelesh Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Go breaking is from code generator and could be ignored.

Copy link
Member

@TimLovellSmith TimLovellSmith Oct 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiaozha is the JS breaking change OK also?

]
}
},
"parameters": {
Expand Down