Add Ip Tags into Swagger #2145

chandrasekarsrinivasan · 2017-12-13T18:02:44Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azuresdkciprbot · 2017-12-13T18:08:04Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 85
After the PR: Warning(s): 0 Error(s): 85

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

jhendrixMSFT · 2017-12-13T18:42:19Z

specification/network/resource-manager/Microsoft.Network/2017-11-01/publicIpAddress.json

          "$ref": "#/definitions/PublicIPAddressDnsSettings",
          "description": "The FQDN of the DNS record associated with the public IP address."
        },
+        "ipTags": {


Was this simply an omission in the original swagger and the service already supports this?

The service supports and the 2017-11-01 is not shipped yet.

@jhendrixMSFT some context:

Not deployed yet (this is a feature branch PR). Deployment planned for tomorrow

This is new features that made it right in time
As you imagine since I'm answering, we are working to get SDK/CLI ready for tomorrow :)

azuresdkciprbot · 2017-12-13T19:59:40Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 85
After the PR: Warning(s): 0 Error(s): 85

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

jhendrixMSFT · 2017-12-13T23:35:42Z

@lmazuel the python build keeps failing, could you take a look?

lmazuel · 2017-12-13T23:53:48Z

@jhendrixMSFT Seems Travis is not fast enough, and generating the entire set of API of Network is longer than 10 minutes... Since Autorest does not write anything in output, Travis thinks it's a deadlock.
No suggestion right now :/
But the PR can be merged, since I tested it manually and it works.

jhendrixMSFT · 2017-12-13T23:55:26Z

@lmazuel ok thanks for letting me know. Unfortunately there is some issue with permissions and I cannot merge, are you able to?

lmazuel · 2017-12-13T23:55:28Z

@jhendrixMSFT Eventually, this will move to a WebApp, and the problem will be gone. It's in progress.

lmazuel · 2017-12-13T23:55:54Z

@jhendrixMSFT Yes I can :)

AutorestCI · 2017-12-13T23:59:02Z

No modification for AutorestCI/azure-sdk-for-node

AutorestCI · 2017-12-14T00:03:43Z

Azure/azure-sdk-for-ruby#1185

* [Network-2017-11-01] Pull latest from current (#2039) * Video Swagger API: update example response json to remove special invalid special characters (#2015) * Add Video Search API Swagger * Video Swagger API: update example response json to remove special invalid special characters * take changes from azure-rest-spec-pr, make Microsoft.Subscription tenant level rp (#1984) * Fix bad merge. (#2022) * Add list apis for sql backup LTR policies & vaults (#2006) * Add list LTR vaults & policies * Added pageable * Change output folder for Search SDKs (#2023) * update output folders in readmes * rename with bing in name * App Model for Tumbling window trigger (#2028) * App model for tumbling window trigger * Addressed CR comments * Renamed retry to count in RetryPolicy * swagger definition for 26 RFI connectors (#2016) * Updated OMS data plane C# namespace & output-folder (#2021) * Update Azure Batch enum to use "values" - also some documentation updates (#2008) * Enum fixes * Improve DataDisks documentation * Update NATPool port range documentation * [Compute] Update Sku APIs (#2034) * Initial commit of 2017-12-01 compute.json * Changes for new API version 2017-12-01 compute.json * Add Compute SKU APIs * Add swagger spec for spell check API (#1997) * Add swagger spec for spell check API * Add Examples to spec * Remove redundant forward slash in path. Specify array from body parameters. * Fix oav errors * Remove x-Bing_Apis-SDK * Change spec to reflect what objects we want to expose in the response. * Fix operationId name to avoid conflict with "SpellCheck" schema. * Add X-BingApis-SDK back. * Remove Unintentional change Packages.json change here was unintentionally added to this review * Add 2017-11-01 folder in microsoft.network (#2019) * Video Swagger API: update example response json to remove special invalid special characters (#2015) * Add Video Search API Swagger * Video Swagger API: update example response json to remove special invalid special characters * take changes from azure-rest-spec-pr, make Microsoft.Subscription tenant level rp (#1984) * Fix bad merge. (#2022) * Add 2017-11-01 folder in microsoft.network * Add Ip Tags into Swagger (#2145) * add iptags for publicip in 2017-11-01 * read me changes for 2017-11-01 * Add Python conf for Network 2017-11-01 * Complete Python conf for 2017-11-01 * Updated LB InboundNatPool API (#2150) * Revert "[Network-2017-11-01] Pull latest from current (#2039)" This reverts commit a0257f9. * Moving to stable folder to account for refactoring changes in dec 2017

chandrasekarsrinivasan added 2 commits November 29, 2017 11:29

add iptags for publicip in 2017-11-01

e5b2185

read me changes for 2017-11-01

ab5cfb0

azuresdkci assigned jhendrixMSFT Dec 13, 2017

jhendrixMSFT reviewed Dec 13, 2017

View reviewed changes

jhendrixMSFT approved these changes Dec 13, 2017

View reviewed changes

lmazuel added 2 commits December 13, 2017 11:01

Add Python conf for Network 2017-11-01

0d21dfa

Complete Python conf for 2017-11-01

ee38da0

lmazuel merged commit 7b086c4 into Azure:Network-2017-11-01 Dec 13, 2017

AutorestCI mentioned this pull request Dec 14, 2017

Automatic PR from RestAPI-PR2145 Azure/azure-sdk-for-ruby#1185

Closed

Add Ip Tags into Swagger #2145

Add Ip Tags into Swagger #2145

Uh oh!

Conversation

chandrasekarsrinivasan commented Dec 13, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

azuresdkciprbot commented Dec 13, 2017

Uh oh!

jhendrixMSFT Dec 13, 2017

Choose a reason for hiding this comment

Uh oh!

chandrasekarsrinivasan Dec 13, 2017

Choose a reason for hiding this comment

Uh oh!

lmazuel Dec 13, 2017

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Dec 13, 2017

Uh oh!

jhendrixMSFT commented Dec 13, 2017

Uh oh!

lmazuel commented Dec 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhendrixMSFT commented Dec 13, 2017

Uh oh!

lmazuel commented Dec 13, 2017

Uh oh!

lmazuel commented Dec 13, 2017

Uh oh!

AutorestCI commented Dec 13, 2017

Uh oh!

AutorestCI commented Dec 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chandrasekarsrinivasan commented Dec 13, 2017 •

edited by azuresdkci

Loading

lmazuel commented Dec 13, 2017 •

edited

Loading