Examples for Disks/Images

[gatneil]

No description provided.

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/compute/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 32
After the PR: Warning(s): 0 Error(s): 39

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[gatneil]

The new “errors” are that there is no minimum/maximum example for the new examples. I request an exception for 3 reasons:

1. This hasn't actually made the number of errors go up. These APIs were always missing minimum/maximum examples; it's just that before this PR there were no examples at all for those API, so the lack of minimum/maximum examples wasn't being reported before.
2. I don’t think it really makes sense to have maximum/minimum examples for these examples since they would be invalid (e.g. both the syntax for creating image from blob and the syntax for creating image from snapshot; this would be an invalid request).
3. This wasn’t in scope for these examples :)

[sergey-shandar]

@gatneil thank you for providing examples. Could you also add code '200' as a response to examples?

[gatneil]

@sergey-shandar the scope for this round of adding examples is to get parity with the existing documentation so we can autogen the rest api docs from swagger. If we could move forward with this PR for now, this would be awesome so we can light up autogen of rest api docs without further delay.

[AutorestCI]

This commit was treated and no generation was made for Python

[AutorestCI]

Swagger to SDK encountered an unknown error: (Azure/azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 29, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 180, in rest_handle_action
    return rest_pull_close(body, github_con, restapi_repo, sdk_pr_target_repo, sdkbase)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 306, in rest_pull_close
    rest_pr.create_issue_comment("Was unable to create SDK %s PR for this closed PR.", sdkid)
TypeError: create_issue_comment() takes 2 positional arguments but 3 were given

[AutorestCI]

Did a commit to SDK for Python:
Azure/azure-sdk-for-python@ea11ff8