[Hub Generated] Review request for Microsoft.ConfidentialLedger to add version preview/2023-01-26-preview #23551

musabbir · 2023-04-13T19:57:54Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. - MAY 2023
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. May 2023
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

This reverts commit 68dc36a.

This reverts commit dff3fb4.

This reverts commit 39f7474.

openapi-workflow-bot · 2023-04-13T19:57:58Z

Hi, @musabbir Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-04-13T19:58:01Z

Swagger Validation Report

️🔄BreakingChange inProgress [Detail]

️🔄Breaking Change(Cross-Version) inProgress [Detail]

️⌛CredScan pending [Detail]

️🔄LintDiff inProgress [Detail]

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️🔄ApiReadinessCheck inProgress [Detail]

️🔄~[Staging] ServiceAPIReadinessTest inProgress [Detail]

️🔄SwaggerAPIView inProgress [Detail]

️🔄CadlAPIView inProgress [Detail]

️🔄TypeSpecAPIView inProgress [Detail]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️🔄SemanticValidation inProgress [Detail]

️⌛PoliCheck pending [Detail]

️🔄PrettierCheck inProgress [Detail]

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️🔄Lint(RPaaS) inProgress [Detail]

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️⌛PR Summary pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-13T19:58:02Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/confidentialledger/armconfidentialledger - Approved - 2.0.0-beta.1

+	Struct `ResourceLocation` has been removed
+	Struct `Tags` has been removed

❌azure-sdk-for-python-track2 - track2_azure-mgmt-confidentialledger - Approved - 2.0.0b1

+	Model LedgerProperties no longer has parameter ledger_storage_account
+	Parameter location of model ConfidentialLedger is now required

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs]Release - Generate from 975b6ed. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:671
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 671 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.ConfidentialLedger [View full logs] [Release SDK Changes]
- Azure.ResourceManager.ConfidentialLedger.1.1.0-alpha.20230418.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 975b6ed. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.4
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-confidentialledger [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group ConfidentialLedgerOperationsMixin
info	[Changelog]   - Added operation group ManagedCCFOperations
info	[Changelog]   - Model LedgerProperties has a new parameter running_state
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model LedgerProperties no longer has parameter ledger_storage_account
info	[Changelog]   - Parameter location of model ConfidentialLedger is now required

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 975b6ed. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.
cmderr	[generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.test.TestBase - Test Mode: PLAYBACK, Name: ledgerDeleteTest
cmderr	[generate.py] [ForkJoinPool-1-worker-5] INFO com.azure.core.test.TestBase - Test Mode: PLAYBACK, Name: ledgerCreateTest
cmderr	[generate.py] [ForkJoinPool-1-worker-5] INFO com.azure.core.test.InterceptorManager - ==> Playback file path: /mnt/vss/_work/1/s/azure-sdk-for-java/sdk/confidentialledger/azure-resourcemanager-confidentialledger/target/test-classes/session-records/ConfidentialLedgerManagementTest.ledgerCreateTest.json
cmderr	[generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.test.InterceptorManager - ==> Playback file path: /mnt/vss/_work/1/s/azure-sdk-for-java/sdk/confidentialledger/azure-resourcemanager-confidentialledger/target/test-classes/session-records/ConfidentialLedgerManagementTest.ledgerDeleteTest.json
cmderr	[generate.py] [ForkJoinPool-1-worker-5] INFO com.azure.core.implementation.AccessTokenCache - Acquired a new access token.
cmderr	[generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.implementation.AccessTokenCache - Acquired a new access token.

️✔️azure-resourcemanager-confidentialledger [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 975b6ed. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/confidentialledger/armconfidentialledger [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Struct `ResourceLocation` has been removed
info	[Changelog] - Struct `Tags` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New enum type `LanguageRuntime` with values `LanguageRuntimeCPP`, `LanguageRuntimeJS`
info	[Changelog] - New enum type `RunningState` with values `RunningStateActive`, `RunningStatePaused`, `RunningStatePausing`, `RunningStateResuming`, `RunningStateUnknown`
info	[Changelog] - New function `*ClientFactory.NewManagedCCFClient() *ManagedCCFClient`
info	[Changelog] - New function `NewManagedCCFClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ManagedCCFClient, error)`
info	[Changelog] - New function `*ManagedCCFClient.BeginCreate(context.Context, string, string, ManagedCCF, *ManagedCCFClientBeginCreateOptions) (*runtime.Poller[ManagedCCFClientCreateResponse], error)`
info	[Changelog] - New function `*ManagedCCFClient.BeginDelete(context.Context, string, string, *ManagedCCFClientBeginDeleteOptions) (*runtime.Poller[ManagedCCFClientDeleteResponse], error)`
info	[Changelog] - New function `*ManagedCCFClient.Get(context.Context, string, string, *ManagedCCFClientGetOptions) (ManagedCCFClientGetResponse, error)`
info	[Changelog] - New function `*ManagedCCFClient.NewListByResourceGroupPager(string, *ManagedCCFClientListByResourceGroupOptions) *runtime.Pager[ManagedCCFClientListByResourceGroupResponse]`
info	[Changelog] - New function `*ManagedCCFClient.NewListBySubscriptionPager(*ManagedCCFClientListBySubscriptionOptions) *runtime.Pager[ManagedCCFClientListBySubscriptionResponse]`
info	[Changelog] - New function `*ManagedCCFClient.BeginUpdate(context.Context, string, string, ManagedCCF, *ManagedCCFClientBeginUpdateOptions) (*runtime.Poller[ManagedCCFClientUpdateResponse], error)`
info	[Changelog] - New struct `CertificateTags`
info	[Changelog] - New struct `DeploymentType`
info	[Changelog] - New struct `ManagedCCF`
info	[Changelog] - New struct `ManagedCCFList`
info	[Changelog] - New struct `ManagedCCFProperties`
info	[Changelog] - New struct `MemberIdentityCertificate`
info	[Changelog] - New struct `TrackedResource`
info	[Changelog] - New field `RunningState` in struct `LedgerProperties`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 32 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 975b6ed. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-confidentialledger [View full logs] [Release SDK Changes]

azure-arm-confidentialledger-1.3.0-beta.1.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group ManagedCCFOperations
info	[Changelog]   - Added Interface CertificateTags
info	[Changelog]   - Added Interface DeploymentType
info	[Changelog]   - Added Interface ManagedCCF
info	[Changelog]   - Added Interface ManagedCCFCreateOptionalParams
info	[Changelog]   - Added Interface ManagedCCFDeleteOptionalParams
info	[Changelog]   - Added Interface ManagedCCFGetOptionalParams
info	[Changelog]   - Added Interface ManagedCCFList
info	[Changelog]   - Added Interface ManagedCCFListByResourceGroupNextOptionalParams
info	[Changelog]   - Added Interface ManagedCCFListByResourceGroupOptionalParams
info	[Changelog]   - Added Interface ManagedCCFListBySubscriptionNextOptionalParams
info	[Changelog]   - Added Interface ManagedCCFListBySubscriptionOptionalParams
info	[Changelog]   - Added Interface ManagedCCFProperties
info	[Changelog]   - Added Interface ManagedCCFUpdateOptionalParams
info	[Changelog]   - Added Interface MemberIdentityCertificate
info	[Changelog]   - Added Interface TrackedResource
info	[Changelog]   - Added Type Alias LanguageRuntime
info	[Changelog]   - Added Type Alias ManagedCCFCreateResponse
info	[Changelog]   - Added Type Alias ManagedCCFGetResponse
info	[Changelog]   - Added Type Alias ManagedCCFListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias ManagedCCFListByResourceGroupResponse
info	[Changelog]   - Added Type Alias ManagedCCFListBySubscriptionNextResponse
info	[Changelog]   - Added Type Alias ManagedCCFListBySubscriptionResponse
info	[Changelog]   - Added Type Alias RunningState
info	[Changelog]   - Interface LedgerProperties has a new optional parameter runningState
info	[Changelog]   - Added Enum KnownLanguageRuntime
info	[Changelog]   - Added Enum KnownRunningState

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 975b6ed. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.confidentialledger.DefaultTag [View full logs] [Release SDK Changes]
- Az.ConfidentialLedger.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-13T19:58:03Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/confidentialledger/armconfidentialledger	https://apiview.dev/Assemblies/Review/80a6b40dea4f4369a39f95b0ce74ddd4
.Net	Azure.ResourceManager.ConfidentialLedger	https://apiview.dev/Assemblies/Review/b7f156555e4f4888be0e4c573f77c26e
Java	azure-resourcemanager-confidentialledger	https://apiview.dev/Assemblies/Review/954dfe1e02a14bd9b44c5fe018188cd5
JavaScript	@azure/arm-confidentialledger	Create ApiView failed. Please ask PR assignee for help

openapi-pipeline-app · 2023-04-13T20:01:44Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Rule	Message
`❌` Runtime Exception	"new":"https://github.com/Azure/azure-rest-api-specs/blob/138ef48f56b802307929f69431a0b632af6c099e/specification/confidentialledger/resource-manager/Microsoft.ConfidentialLedger/preview/2023-01-26-preview/confidentialledger.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/confidentialledger/resource-manager/Microsoft.ConfidentialLedger/preview/2023-01-26-preview/confidentialledger.json", "details":"incompatible properties : tags "

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-preview-2023-01	package-preview-2023-01(138ef48)	package-preview-2023-01(main)

The following errors/warnings exist before current PR submission:

Rule	Message
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.ConfidentialLedger/preview/2023-01-26-preview/confidentialledger.json#L448
⚠️ AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.ConfidentialLedger/preview/2023-01-26-preview/confidentialledger.json#L635

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

haolingdong-msft · 2023-04-14T01:53:48Z

@tadelesh @raych1 , please help to review go breaking change. thanks.

haolingdong-msft · 2023-04-14T01:54:09Z

@msyyc , please help review python breaking changes. thanks.

tadelesh · 2023-04-14T03:16:19Z

Approved as it is a preview version within one year.

openapi-workflow-bot · 2023-04-14T09:32:27Z

Hi @musabbir, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

musabbir · 2023-04-17T05:21:17Z

Hi @musabbir, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

This is not a real breaking change. This PR is fixing an issue with the preview version that has not even been released yet.
There is no customer impact since the preview version has not even been released yet.

…d version preview/2023-01-26-preview (Azure#23551) * Move runningState property to LedgerProperties * Update examples * remove TAGS * Remove Tag def * remove all tags * Revert "remove all tags" This reverts commit 68dc36a. * Revert "Remove Tag def" This reverts commit dff3fb4. * Revert "Revert "Remove Tag def"" This reverts commit 39f7474. * Bring tags back * Remove Tags again --------- Co-authored-by: Musabbir Khan <[email protected]>

Musabbir Khan added 8 commits April 13, 2023 11:49

Move runningState property to LedgerProperties

fb6c65a

Update examples

e1bd1d8

remove TAGS

0d0a31d

Remove Tag def

dff3fb4

remove all tags

68dc36a

Revert "remove all tags"

1a15d85

This reverts commit 68dc36a.

Revert "Remove Tag def"

39f7474

This reverts commit dff3fb4.

Revert "Revert "Remove Tag def""

186fea8

This reverts commit 39f7474.

AzureRestAPISpecReview added resource-manager RPaaS labels Apr 13, 2023

azure-sdk mentioned this pull request Apr 13, 2023

[AutoPR sdk/resourcemanager/confidentialledger/armconfidentialledger] [Hub Generated] Review request for Microsoft.ConfidentialLedger to add version preview/2023-01-26-preview azure-sdk/azure-sdk-for-go#5286

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Go label Apr 13, 2023

azure-sdk mentioned this pull request Apr 13, 2023

[AutoPR track2_azure-mgmt-confidentialledger] [Hub Generated] Review request for Microsoft.ConfidentialLedger to add version preview/2023-01-26-preview azure-sdk/azure-sdk-for-python#3299

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Apr 13, 2023

musabbir marked this pull request as ready for review April 13, 2023 20:14

openapi-assignment-bot bot assigned haolingdong-msft Apr 13, 2023

Musabbir Khan added 2 commits April 13, 2023 14:03

Bring tags back

f0f3945

Remove Tags again

138ef48

tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Apr 14, 2023

msyyc added the Approved-SdkBreakingChange-Python label Apr 14, 2023

haolingdong-msft approved these changes Apr 14, 2023

View reviewed changes

haolingdong-msft added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Apr 14, 2023

konrad-jamrozik mentioned this pull request Apr 14, 2023

[Breaking Change] Swagger BreakingChange validation failure with runtime exception: incompatible properties : tags Azure/azure-sdk-tools#5981

Open

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 17, 2023

raych1 assigned v-xuto Apr 18, 2023

haolingdong-msft merged commit 975b6ed into main Apr 18, 2023

haolingdong-msft deleted the musabbir-confidentialledger-Microsoft.ConfidentialLedger-2023-01-26-preview branch April 18, 2023 07:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Hub Generated] Review request for Microsoft.ConfidentialLedger to add version preview/2023-01-26-preview #23551

[Hub Generated] Review request for Microsoft.ConfidentialLedger to add version preview/2023-01-26-preview #23551

Uh oh!

musabbir commented Apr 13, 2023 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented Apr 13, 2023

Uh oh!

openapi-pipeline-app bot commented Apr 13, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Apr 13, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Apr 13, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Apr 13, 2023 •

edited

Loading

Uh oh!

haolingdong-msft commented Apr 14, 2023

Uh oh!

haolingdong-msft commented Apr 14, 2023

Uh oh!

tadelesh commented Apr 14, 2023

Uh oh!

openapi-workflow-bot bot commented Apr 14, 2023

Uh oh!

musabbir commented Apr 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

[Hub Generated] Review request for Microsoft.ConfidentialLedger to add version preview/2023-01-26-preview #23551

[Hub Generated] Review request for Microsoft.ConfidentialLedger to add version preview/2023-01-26-preview #23551

Uh oh!

Conversation

musabbir commented Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot bot commented Apr 13, 2023

Uh oh!

openapi-pipeline-app bot commented Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

openapi-pipeline-app bot commented Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

haolingdong-msft commented Apr 14, 2023

Uh oh!

haolingdong-msft commented Apr 14, 2023

Uh oh!

tadelesh commented Apr 14, 2023

Uh oh!

openapi-workflow-bot bot commented Apr 14, 2023

Uh oh!

musabbir commented Apr 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

musabbir commented Apr 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 13, 2023 •

edited

Loading