Adding examples and fixing the DSC related lint issues #2415
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,6 +107,11 @@ | |
| "externalDocs": { | ||
| "url": "http://aka.ms/azureautomationsdk/dsccompilationjoboperations" | ||
| }, | ||
| "x-ms-examples": { | ||
| "Get a DSC Compilation job": { | ||
| "$ref": "./examples/getCompilationJob.json" | ||
|
||
| } | ||
| }, | ||
| "parameters": [ | ||
| { | ||
| "$ref": "./definitions.json#/parameters/ResourceGroupNameParameter" | ||
|
|
@@ -159,6 +164,11 @@ | |
| "externalDocs": { | ||
| "url": "http://aka.ms/azureautomationsdk/compilationjoboperations" | ||
| }, | ||
| "x-ms-examples": { | ||
| "List DSC Compilation job in Automation Account": { | ||
| "$ref": "./examples/listCompilationJobsByAutomationAccount.json" | ||
| } | ||
| }, | ||
| "parameters": [ | ||
| { | ||
| "$ref": "./definitions.json#/parameters/ResourceGroupNameParameter" | ||
|
|
@@ -203,6 +213,63 @@ | |
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/compilationjobs/{jobId}/streams/": { | ||
|
||
| "get": { | ||
| "tags": [ | ||
| "DscCompilationJob" | ||
| ], | ||
| "operationId": "DscCompilationJobStream_ListByJob", | ||
| "description": "Retrieve all the job streams for the compilation Job.", | ||
| "externalDocs": { | ||
| "url": "http://aka.ms/azureautomationsdk/jobstreamoperations" | ||
| }, | ||
| "x-ms-examples": { | ||
| "List DSC Compilation job streams": { | ||
| "$ref": "./examples/compilationJobStreamList.json" | ||
| } | ||
| }, | ||
| "parameters": [ | ||
| { | ||
| "$ref": "./definitions.json#/parameters/ResourceGroupNameParameter" | ||
| }, | ||
| { | ||
| "name": "automationAccountName", | ||
| "in": "path", | ||
| "required": true, | ||
| "type": "string", | ||
| "description": "The automation account name." | ||
| }, | ||
| { | ||
| "name": "jobId", | ||
| "in": "path", | ||
| "required": true, | ||
| "type": "string", | ||
| "format": "uuid", | ||
| "description": "The job id." | ||
| }, | ||
| { | ||
| "$ref": "./definitions.json#/parameters/SubscriptionIdParameter" | ||
| }, | ||
| { | ||
| "$ref": "./definitions.json#/parameters/ApiVersionParameter" | ||
| } | ||
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "OK", | ||
| "schema": { | ||
| "$ref": "./definitions.json#/definitions/JobStreamListResult" | ||
| } | ||
| }, | ||
| "default": { | ||
| "description": "Automation error response describing why the operation failed.", | ||
| "schema": { | ||
| "$ref": "./definitions.json#/definitions/ErrorResponse" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Automation/automationAccounts/{automationAccountName}/compilationjobs/{jobId}/streams/{jobStreamId}": { | ||
| "get": { | ||
| "tags": [ | ||
|
|
@@ -213,6 +280,11 @@ | |
| "externalDocs": { | ||
| "url": "http://aka.ms/azureautomationsdk/jobstreamoperations" | ||
| }, | ||
| "x-ms-examples": { | ||
| "Get a DSC Compilation job stream by job stream id": { | ||
| "$ref": "./examples/compilationJobStreamByJobStreamId.json" | ||
| } | ||
| }, | ||
| "parameters": [ | ||
| { | ||
| "$ref": "./definitions.json#/parameters/ResourceGroupNameParameter" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| { | ||
| "parameters": { | ||
| "subscriptionId": "subid", | ||
| "resourceGroupName": "rg", | ||
| "automationAccountName": "myAutomationAccount33", | ||
| "api-version": "2015-10-31", | ||
| "jobId": "836d4e06-2d88-46b4-8500-7febd4906838", | ||
| "jobStreamId": "836d4e06-2d88-46b4-8500-7febd4906838_00636481062421684835_00000000000000000008" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "headers": {}, | ||
| "body": { | ||
| "id": "/subscriptions/subid/resourceGroups/rg/providers/Microsoft.Automation/automationAccounts/myAutomationAccount33/compilationjobs/836d4e06-2d88-46b4-8500-7febd4906838/streams/836d4e06-2d88-46b4-8500-7febd4906838_00636481062421684835_00000000000000000008", | ||
| "properties": { | ||
| "jobStreamId": "836d4e06-2d88-46b4-8500-7febd4906838:00636481062421684835:00000000000000000001", | ||
| "summary": "", | ||
| "time": "2017-12-05T21:30:42.1684835+00:00", | ||
| "streamType": "Output", | ||
| "streamText": "", | ||
| "value": { | ||
| "value": "", | ||
| "PSComputerName": "localhost", | ||
| "PSShowComputerName": true, | ||
| "PSSourceJobInstanceId": "836d4e06-2d88-46b4-8500-7febd4906838" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch!
You're changing
enumvalues here.Did the service change, or was this an error in the spec before? If this is a service change, we're potentially breaking an API.
As it is, this means that current clients are incorrect. Is this so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Spec was incorrect here and I just changed it to reflect what we are sending from the service. And we are in the process of releasing new Automation SDKs based on Swagger and are still in preview mode.
Our last stable release of SDK was based on Hyak.