Skip to content

Conversation

@subhrob
Copy link
Contributor

@subhrob subhrob commented May 26, 2023

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @subhrob Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 26, 2023

    Swagger Validation Report

    ️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    FailoverGroups.json 2022-11-01-preview(14ceeba) 2022-11-01-preview(main)
    Rule Message
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L410:9
    Old: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L410:9
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L417:11
    Old: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L417:11
    1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L689:5
    Old: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L692:5
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️❌LintDiff: 2 Errors, 0 Warnings failed [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-preview-2022-11 package-preview-2022-11(14ceeba) package-preview-2022-11(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Rule Message Related RPC [For API reviewers]
    ResourceNameRestriction The resource name parameter 'serverName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L403
    RPC-Uri-V1-05
    ResourceNameRestriction The resource name parameter 'failoverGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L403
    RPC-Uri-V1-05


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'serverName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L19
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L51
    ResourceNameRestriction The resource name parameter 'serverName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L65
    ResourceNameRestriction The resource name parameter 'failoverGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L65
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L104
    ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L114
    ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L114
    PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'FailoverGroups_CreateOrUpdate' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema'
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L114
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L161
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L164
    DeleteOperationAsyncResponseValidation An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L181
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L216
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L219
    ProvisioningStateSpecifiedForLROPatch 200 response schema in long running PATCH operation is missing ProvisioningState property. A LRO PATCH operations 200 response schema must have ProvisioningState specified.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L274
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L280
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L283
    ResourceNameRestriction The resource name parameter 'serverName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L295
    ResourceNameRestriction The resource name parameter 'failoverGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L295
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L296
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L334
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L337
    ResourceNameRestriction The resource name parameter 'serverName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L349
    ResourceNameRestriction The resource name parameter 'failoverGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L349
    PostOperationAsyncResponseValidation An async POST operation must set long running operation options 'x-ms-long-running-operation-options'
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L350
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L388
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L391
    DefaultErrorResponseSchema the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L438
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L26
    ⚠️ RequiredReadOnlySystemData The response of operation:'FailoverGroups_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L66
    ⚠️ ParameterNotDefinedInGlobalParameters Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition
    Location: Microsoft.Sql/preview/2022-11-01-preview/FailoverGroups.json#L72
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 26, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️🔄 azure-sdk-for-python-track2 inProgress [Detail]
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from c9fd307. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:800
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 800 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.Sql [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c9fd307. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-sql-generated [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c9fd307. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/sql/armsql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog] - New struct `BenchmarkReference`
      info	[Changelog] - New struct `DatabaseKey`
      info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentBaselineSet`
      info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentBaselineSetListResult`
      info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentBaselineSetProperties`
      info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentRuleBaseline`
      info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentRuleBaselineInput`
      info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentRuleBaselineInputProperties`
      info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentRuleBaselineListInput`
      info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentRuleBaselineListInputProperties`
      info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentRuleBaselineListResult`
      info	[Changelog] - New struct `DatabaseSQLVulnerabilityAssessmentRuleBaselineProperties`
      info	[Changelog] - New struct `DatabaseVulnerabilityAssessmentRuleBaselineAutoGenerated`
      info	[Changelog] - New struct `DatabaseVulnerabilityAssessmentRuleBaselinePropertiesAutoGenerated`
      info	[Changelog] - New struct `DistributedAvailabilityGroupSetRole`
      info	[Changelog] - New struct `EndpointDependency`
      info	[Changelog] - New struct `EndpointDetail`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtection`
      info	[Changelog] - New struct `ManagedDatabaseAdvancedThreatProtectionListResult`
      info	[Changelog] - New struct `ManagedDatabaseMoveDefinition`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationListResult`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationResult`
      info	[Changelog] - New struct `ManagedDatabaseMoveOperationResultProperties`
      info	[Changelog] - New struct `ManagedDatabaseRestoreDetailsBackupSetProperties`
      info	[Changelog] - New struct `ManagedDatabaseRestoreDetailsUnrestorableFileProperties`
      info	[Changelog] - New struct `ManagedDatabaseStartMoveDefinition`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtection`
      info	[Changelog] - New struct `ManagedInstanceAdvancedThreatProtectionListResult`
      info	[Changelog] - New struct `ManagedInstanceDtc`
      info	[Changelog] - New struct `ManagedInstanceDtcListResult`
      info	[Changelog] - New struct `ManagedInstanceDtcProperties`
      info	[Changelog] - New struct `ManagedInstanceDtcSecuritySettings`
      info	[Changelog] - New struct `ManagedInstanceDtcTransactionManagerCommunicationSettings`
      info	[Changelog] - New struct `ManagedLedgerDigestUploads`
      info	[Changelog] - New struct `ManagedLedgerDigestUploadsListResult`
      info	[Changelog] - New struct `ManagedLedgerDigestUploadsProperties`
      info	[Changelog] - New struct `ManagedServerDNSAlias`
      info	[Changelog] - New struct `ManagedServerDNSAliasAcquisition`
      info	[Changelog] - New struct `ManagedServerDNSAliasCreation`
      info	[Changelog] - New struct `ManagedServerDNSAliasListResult`
      info	[Changelog] - New struct `ManagedServerDNSAliasProperties`
      info	[Changelog] - New struct `NSPConfigAccessRule`
      info	[Changelog] - New struct `NSPConfigAccessRuleProperties`
      info	[Changelog] - New struct `NSPConfigAssociation`
      info	[Changelog] - New struct `NSPConfigNetworkSecurityPerimeterRule`
      info	[Changelog] - New struct `NSPConfigPerimeter`
      info	[Changelog] - New struct `NSPConfigProfile`
      info	[Changelog] - New struct `NSPProvisioningIssue`
      info	[Changelog] - New struct `NSPProvisioningIssueProperties`
      info	[Changelog] - New struct `NetworkSecurityPerimeterConfiguration`
      info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationListResult`
      info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationProperties`
      info	[Changelog] - New struct `OutboundEnvironmentEndpoint`
      info	[Changelog] - New struct `OutboundEnvironmentEndpointCollection`
      info	[Changelog] - New struct `PhaseDetails`
      info	[Changelog] - New struct `QueryCheck`
      info	[Changelog] - New struct `RefreshExternalGovernanceStatusOperationResult`
      info	[Changelog] - New struct `RefreshExternalGovernanceStatusOperationResultProperties`
      info	[Changelog] - New struct `Remediation`
      info	[Changelog] - New struct `ScheduleItem`
      info	[Changelog] - New struct `ServerConfigurationOption`
      info	[Changelog] - New struct `ServerConfigurationOptionListResult`
      info	[Changelog] - New struct `ServerConfigurationOptionProperties`
      info	[Changelog] - New struct `ServerUsageProperties`
      info	[Changelog] - New struct `StartStopManagedInstanceSchedule`
      info	[Changelog] - New struct `StartStopManagedInstanceScheduleListResult`
      info	[Changelog] - New struct `StartStopManagedInstanceScheduleProperties`
      info	[Changelog] - New struct `SynapseLinkWorkspace`
      info	[Changelog] - New struct `SynapseLinkWorkspaceInfoProperties`
      info	[Changelog] - New struct `SynapseLinkWorkspaceListResult`
      info	[Changelog] - New struct `SynapseLinkWorkspaceProperties`
      info	[Changelog] - New struct `UpdateVirtualClusterDNSServersOperation`
      info	[Changelog] - New struct `UpsertManagedServerOperationStepWithEstimatesAndDuration`
      info	[Changelog] - New struct `VaRule`
      info	[Changelog] - New struct `VirtualClusterDNSServersProperties`
      info	[Changelog] - New struct `VulnerabilityAssessment`
      info	[Changelog] - New struct `VulnerabilityAssessmentListResult`
      info	[Changelog] - New struct `VulnerabilityAssessmentPolicyProperties`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanForSQLError`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanListResult`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanRecordForSQL`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanRecordForSQLListResult`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanRecordForSQLProperties`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanResultProperties`
      info	[Changelog] - New struct `VulnerabilityAssessmentScanResults`
      info	[Changelog] - New field `NextLink` in struct `DataMaskingRuleListResult`
      info	[Changelog] - New field `AdministratorLogin`, `AdministratorLoginPassword`, `AuthenticationType`, `DatabaseEdition`, `MaxSizeBytes`, `NetworkIsolation`, `ServiceObjectiveName` in struct `DatabaseExtensionsProperties`
      info	[Changelog] - New field `OperationPhaseDetails` in struct `DatabaseOperationProperties`
      info	[Changelog] - New field `AvailabilityZone`, `EncryptionProtector`, `Keys`, `ManualCutover`, `PerformCutover`, `PreferredEnclaveType` in struct `DatabaseProperties`
      info	[Changelog] - New field `EncryptionProtector`, `Keys`, `ManualCutover`, `PerformCutover`, `PreferredEnclaveType` in struct `DatabaseUpdateProperties`
      info	[Changelog] - New field `Expand`, `Filter` in struct `DatabasesClientGetOptions`
      info	[Changelog] - New field `InstanceRole` in struct `DistributedAvailabilityGroupProperties`
      info	[Changelog] - New field `ZonePinning` in struct `EditionCapability`
      info	[Changelog] - New field `ZonePinning` in struct `ElasticPoolEditionCapability`
      info	[Changelog] - New field `AvailabilityZone`, `MinCapacity`, `PreferredEnclaveType` in struct `ElasticPoolProperties`
      info	[Changelog] - New field `AvailabilityZone`, `MinCapacity`, `PreferredEnclaveType` in struct `ElasticPoolUpdateProperties`
      info	[Changelog] - New field `NextLink` in struct `GeoBackupPolicyListResult`
      info	[Changelog] - New field `BlobURI`, `PrivateEndpointConnections`, `QueuedTime` in struct `ImportExportExtensionsOperationResultProperties`
      info	[Changelog] - New field `SecondaryType` in struct `InstanceFailoverGroupProperties`
      info	[Changelog] - New field `CrossSubscriptionRestorableDroppedDatabaseID`, `CrossSubscriptionSourceDatabaseID`, `CrossSubscriptionTargetManagedInstanceID`, `IsLedgerOn`, `StorageContainerIdentity` in struct `ManagedDatabaseProperties`
      info	[Changelog] - New field `CurrentBackupType`, `CurrentRestorePlanSizeMB`, `CurrentRestoredSizeMB`, `DiffBackupSets`, `FullBackupSets`, `LogBackupSets`, `NumberOfFilesQueued`, `NumberOfFilesRestored`, `NumberOfFilesRestoring`, `NumberOfFilesSkipped`, `NumberOfFilesUnrestorable`, `Type` in struct `ManagedDatabaseRestoreDetailsProperties`
      info	[Changelog] - New anonymous field `DatabaseVulnerabilityAssessmentRuleBaselineAutoGenerated` in struct `ManagedDatabaseVulnerabilityAssessmentRuleBaselinesClientCreateOrUpdateResponse`
      info	[Changelog] - New anonymous field `DatabaseVulnerabilityAssessmentRuleBaselineAutoGenerated` in struct `ManagedDatabaseVulnerabilityAssessmentRuleBaselinesClientGetResponse`
      info	[Changelog] - New field `RequiredZoneNames` in struct `ManagedInstancePrivateLinkProperties`
      info	[Changelog] - New field `VirtualClusterID` in struct `ManagedInstanceProperties`
      info	[Changelog] - New field `GroupIDs` in struct `PrivateEndpointConnectionProperties`
      info	[Changelog] - New field `NextLink` in struct `RecoverableDatabaseListResult`
      info	[Changelog] - New field `Keys` in struct `RecoverableDatabaseProperties`
      info	[Changelog] - New field `Expand`, `Filter` in struct `RecoverableDatabasesClientGetOptions`
      info	[Changelog] - New field `PartnerDatabaseID` in struct `ReplicationLinkProperties`
      info	[Changelog] - New field `Keys` in struct `RestorableDroppedDatabaseProperties`
      info	[Changelog] - New field `Expand`, `Filter` in struct `RestorableDroppedDatabasesClientGetOptions`
      info	[Changelog] - New field `IsManagedIdentityInUse` in struct `ServerDevOpsAuditSettingsProperties`
      info	[Changelog] - New field `ExternalGovernanceStatus` in struct `ServerProperties`
      info	[Changelog] - New field `ID`, `Properties`, `Type` in struct `ServerUsage`
      info	[Changelog] - New field `NextLink` in struct `ServerUsageListResult`
      info	[Changelog] - New field `ZonePinning` in struct `ServiceObjectiveCapability`
      info	[Changelog] - New field `Version` in struct `VirtualClusterProperties`
      info	[Changelog]
      info	[Changelog] Total 105 breaking change(s), 429 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from c9fd307. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-sql [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsReconcileOptionalParams
      info	[Changelog]   - Added Interface NSPConfigAccessRule
      info	[Changelog]   - Added Interface NSPConfigAccessRuleProperties
      info	[Changelog]   - Added Interface NSPConfigAssociation
      info	[Changelog]   - Added Interface NSPConfigNetworkSecurityPerimeterRule
      info	[Changelog]   - Added Interface NSPConfigPerimeter
      info	[Changelog]   - Added Interface NSPConfigProfile
      info	[Changelog]   - Added Interface NSPProvisioningIssue
      info	[Changelog]   - Added Interface NSPProvisioningIssueProperties
      info	[Changelog]   - Added Interface PhaseDetails
      info	[Changelog]   - Added Interface SensitivityLabelsListByDatabaseNextOptionalParams
      info	[Changelog]   - Added Interface SensitivityLabelsListByDatabaseOptionalParams
      info	[Changelog]   - Added Interface ServerUsagesListByServerNextOptionalParams
      info	[Changelog]   - Added Interface UpsertManagedServerOperationStepWithEstimatesAndDuration
      info	[Changelog]   - Added Type Alias DataMaskingPolicyName
      info	[Changelog]   - Added Type Alias DataMaskingRulesListByDatabaseNextResponse
      info	[Changelog]   - Added Type Alias DistributedAvailabilityGroupsSetRoleResponse
      info	[Changelog]   - Added Type Alias FailoverGroupsTryPlannedBeforeForcedFailoverResponse
      info	[Changelog]   - Added Type Alias GeoBackupPoliciesListNextResponse
      info	[Changelog]   - Added Type Alias GeoBackupPoliciesListResponse
      info	[Changelog]   - Added Type Alias InstanceRole
      info	[Changelog]   - Added Type Alias ManagedDatabaseSensitivityLabelsListByDatabaseNextResponse
      info	[Changelog]   - Added Type Alias ManagedDatabaseSensitivityLabelsListByDatabaseResponse
      info	[Changelog]   - Added Type Alias ManagedInstanceLongTermRetentionPoliciesDeleteResponse
      info	[Changelog]   - Added Type Alias ManagedInstancesStartResponse
      info	[Changelog]   - Added Type Alias ManagedInstancesStopResponse
      info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationsGetResponse
      info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationsListByServerNextResponse
      info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationsListByServerResponse
      info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationsReconcileResponse
      info	[Changelog]   - Added Type Alias Phase
      info	[Changelog]   - Added Type Alias RoleChangeType
      info	[Changelog]   - Added Type Alias SecurityAlertPolicyNameAutoGenerated
      info	[Changelog]   - Added Type Alias SensitivityLabelsListByDatabaseNextResponse
      info	[Changelog]   - Added Type Alias SensitivityLabelsListByDatabaseResponse
      info	[Changelog]   - Added Type Alias ServerUsagesListByServerNextResponse
      info	[Changelog]   - Added Type Alias Status
      info	[Changelog]   - Interface DatabaseExtensions has a new optional parameter administratorLogin
      info	[Changelog]   - Interface DatabaseExtensions has a new optional parameter administratorLoginPassword
      info	[Changelog]   - Interface DatabaseExtensions has a new optional parameter authenticationType
      info	[Changelog]   - Interface DatabaseExtensions has a new optional parameter databaseEdition
      info	[Changelog]   - Interface DatabaseExtensions has a new optional parameter maxSizeBytes
      info	[Changelog]   - Interface DatabaseExtensions has a new optional parameter networkIsolation
      info	[Changelog]   - Interface DatabaseExtensions has a new optional parameter serviceObjectiveName
      info	[Changelog]   - Interface DatabaseOperation has a new optional parameter operationPhaseDetails
      info	[Changelog]   - Interface DataMaskingRuleListResult has a new optional parameter nextLink
      info	[Changelog]   - Interface DistributedAvailabilityGroup has a new optional parameter instanceRole
      info	[Changelog]   - Interface EditionCapability has a new optional parameter zonePinning
      info	[Changelog]   - Interface ElasticPool has a new optional parameter availabilityZone
      info	[Changelog]   - Interface ElasticPool has a new optional parameter minCapacity
      info	[Changelog]   - Interface ElasticPool has a new optional parameter preferredEnclaveType
      info	[Changelog]   - Interface ElasticPoolEditionCapability has a new optional parameter zonePinning
      info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter availabilityZone
      info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter minCapacity
      info	[Changelog]   - Interface ElasticPoolUpdate has a new optional parameter preferredEnclaveType
      info	[Changelog]   - Interface GeoBackupPolicyListResult has a new optional parameter nextLink
      info	[Changelog]   - Interface ImportExportExtensionsOperationResult has a new optional parameter blobUri
      info	[Changelog]   - Interface ImportExportExtensionsOperationResult has a new optional parameter privateEndpointConnections
      info	[Changelog]   - Interface ImportExportExtensionsOperationResult has a new optional parameter queuedTime
      info	[Changelog]   - Interface ManagedDatabase has a new optional parameter isLedgerOn
      info	[Changelog]   - Interface ManagedDatabaseUpdate has a new optional parameter isLedgerOn
      info	[Changelog]   - Interface ManagedInstance has a new optional parameter virtualClusterId
      info	[Changelog]   - Interface ManagedInstancePrivateLinkProperties has a new optional parameter requiredZoneNames
      info	[Changelog]   - Interface ManagedInstanceUpdate has a new optional parameter virtualClusterId
      info	[Changelog]   - Interface PrivateEndpointConnection has a new optional parameter groupIds
      info	[Changelog]   - Interface ReplicationLink has a new optional parameter partnerDatabaseId
      info	[Changelog]   - Interface ServerUsageListResult has a new optional parameter nextLink
      info	[Changelog]   - Interface ServiceObjectiveCapability has a new optional parameter zonePinning
      info	[Changelog]   - Interface SqlManagementClientOptionalParams has a new optional parameter apiVersion
      info	[Changelog]   - Interface SqlVulnerabilityAssessmentScanRecord has a new optional parameter lastScanTime
      info	[Changelog]   - Added Enum KnownDataMaskingPolicyName
      info	[Changelog]   - Added Enum KnownInstanceRole
      info	[Changelog]   - Added Enum KnownPhase
      info	[Changelog]   - Added Enum KnownRoleChangeType
      info	[Changelog]   - Added Enum KnownSecurityAlertPolicyNameAutoGenerated
      info	[Changelog]   - Added Enum KnownStatus
      info	[Changelog]   - Enum KnownOperationMode has a new value Export
      info	[Changelog]   - Enum KnownOperationMode has a new value Import
      info	[Changelog]   - Enum KnownStorageCapabilityStorageAccountType has a new value Gzrs
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation group ElasticPoolActivities
      info	[Changelog]   - Removed operation group ElasticPoolDatabaseActivities
      info	[Changelog]   - Removed operation group ServerCommunicationLinks
      info	[Changelog]   - Removed operation group ServiceObjectives
      info	[Changelog]   - Removed operation Databases.listMetricDefinitions
      info	[Changelog]   - Removed operation Databases.listMetrics
      info	[Changelog]   - Removed operation ElasticPools.listMetricDefinitions
      info	[Changelog]   - Removed operation ElasticPools.listMetrics
      info	[Changelog]   - Removed operation GeoBackupPolicies.listByDatabase
      info	[Changelog]   - Operation DataMaskingPolicies.createOrUpdate has a new signature
      info	[Changelog]   - Operation DataMaskingPolicies.get has a new signature
      info	[Changelog]   - Operation DataMaskingRules.createOrUpdate has a new signature
      info	[Changelog]   - Operation DataMaskingRules.listByDatabase has a new signature
      info	[Changelog]   - Operation ManagedDatabaseVulnerabilityAssessmentRuleBaselines.createOrUpdate has a new signature
      info	[Changelog]   - Operation ManagedServerSecurityAlertPolicies.beginCreateOrUpdate has a new signature
      info	[Changelog]   - Operation ManagedServerSecurityAlertPolicies.beginCreateOrUpdateAndWait has a new signature
      info	[Changelog]   - Operation ManagedServerSecurityAlertPolicies.get has a new signature
      info	[Changelog]   - Operation OutboundFirewallRules.beginCreateOrUpdate has a new signature
      info	[Changelog]   - Operation OutboundFirewallRules.beginCreateOrUpdateAndWait has a new signature
      info	[Changelog]   - Operation ServerSecurityAlertPolicies.beginCreateOrUpdate has a new signature
      info	[Changelog]   - Operation ServerSecurityAlertPolicies.beginCreateOrUpdateAndWait has a new signature
      info	[Changelog]   - Operation ServerSecurityAlertPolicies.get has a new signature
      info	[Changelog]   - Interface ServerUsage no longer has parameter name
      info	[Changelog]   - Interface ServerUsage no longer has parameter nextResetTime
      info	[Changelog]   - Interface ServerUsage no longer has parameter resourceName
      info	[Changelog]   - Type of parameter provisioningState of interface ManagedInstance is changed from ManagedInstancePropertiesProvisioningState to ProvisioningState
      info	[Changelog]   - Type of parameter stepsList of interface ManagedInstanceOperationSteps is changed from UpsertManagedServerOperationStep[] to UpsertManagedServerOperationStepWithEstimatesAndDuration[]
      info	[Changelog]   - Type of parameter provisioningState of interface ManagedInstanceUpdate is changed from ManagedInstancePropertiesProvisioningState to ProvisioningState
      info	[Changelog]   - Class SqlManagementClient no longer has parameter elasticPoolActivities
      info	[Changelog]   - Class SqlManagementClient no longer has parameter elasticPoolDatabaseActivities
      info	[Changelog]   - Class SqlManagementClient no longer has parameter serverCommunicationLinks
      info	[Changelog]   - Class SqlManagementClient no longer has parameter serviceObjectives
      info	[Changelog]   - Removed Enum KnownManagedInstancePropertiesProvisioningState
      info	[Changelog]   - Removed Enum KnownPrimaryAggregationType
      info	[Changelog]   - Removed Enum KnownServiceObjectiveName
      info	[Changelog]   - Removed Enum KnownUnitDefinitionType
      info	[Changelog]   - Removed Enum KnownUnitType
      info	[Changelog]   - Removed Enum KnownUpsertManagedServerOperationStepStatus
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from c9fd307. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh] WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from c9fd307. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.sql.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.sql.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the SQL label May 26, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 26, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/sql/armsql https://apiview.dev/Assemblies/Review/7d4b6f131b0f441db4666f8ea0664308
    JavaScript @azure/arm-sql https://apiview.dev/Assemblies/Review/4056e1ab7e394ff6868284dcb6b72e2a

    Copy link
    Member

    @ericshape ericshape left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM for urgent revert.
    Name resource name restriction could refuse downstream clients usage
    @qiaozha Please help merge it ASAP

    @openapi-workflow-bot
    Copy link

    Hi @subhrob, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi @subhrob, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @subhrob subhrob changed the title Remove pattern restrictions not to break downstream clients Remove pattern restrictions not to prevent regression in downstream clients May 26, 2023
    @subhrob subhrob changed the title Remove pattern restrictions not to prevent regression in downstream clients Remove pattern restrictions to prevent regression in downstream clients May 26, 2023
    @subhrob subhrob changed the title Remove pattern restrictions to prevent regression in downstream clients Remove pattern restrictions to prevent regression for old servers not matching the pattern May 26, 2023
    @qiaozha qiaozha added Approved-LintDiff Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 labels May 26, 2023
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-LintDiff BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure resource-manager SQL

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    5 participants