Azure migrate GA and public preview rest api specs. #2446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
Automation for azure-sdk-for-pythonNothing to generate for azure-sdk-for-python |
mcardosos
reviewed
Feb 9, 2018
| "2017-11-11-preview" | ||
| ] | ||
| }, | ||
| "contentType": { |
Contributor
There was a problem hiding this comment.
contentType [](start = 5, length = 11)
Is there a case in which this would be different than application/json?
Contributor
Author
There was a problem hiding this comment.
It would always be application/json.
Removing contentType parameter.
mcardosos
reviewed
Feb 9, 2018
| "user_impersonation" | ||
| ] | ||
| } | ||
| ], |
Contributor
There was a problem hiding this comment.
This can be moved. It can be right at the start of the file
Contributor
There was a problem hiding this comment.
BTW, this applies to all operations in this swagger
In reply to: 167111503 [](ancestors = 167111503)
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "produces": [ | ||
| "application/json" | ||
| ], |
Contributor
There was a problem hiding this comment.
Since this was already added globally, it is not needed to override
Contributor
There was a problem hiding this comment.
Same here, this applies to all operations on this swagger. If the consumes/produces was already defined globally with the same value, it is not needed to override it on every operation.
In reply to: 167111806 [](ancestors = 167111806)
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Get all projects.", | ||
| "description": "Get all the projects in the resource group.", | ||
| "operationId": "Projects_List", |
Contributor
There was a problem hiding this comment.
Projects_List [](start = 24, length = 13)
This can be a pageable operation
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Get all machines in the project", | ||
| "description": "Get data of all the machines available in the project. Returns a json array of objects of type 'machine' defined in Models section.", | ||
| "operationId": "Machines_ListByProject", |
Contributor
There was a problem hiding this comment.
Machines_ListByProject [](start = 24, length = 22)
Looks like a pageable operation
mcardosos
reviewed
Feb 9, 2018
| "type": "object", | ||
| "description": "Dictionary of disks attached to the machine. Key is ID of disk. Value is a disk object", | ||
| "readOnly": true, | ||
| "properties": { |
Contributor
There was a problem hiding this comment.
properties [](start = 11, length = 10)
It is bet not to define objects inline, so you can get a better code generation
Contributor
Author
There was a problem hiding this comment.
Its a dictionary, so we should not create a separate object for this.
Also, https://swagger.io/docs/specification/data-models/dictionaries/ is applicable for OpenAPI 3 only, while Azure-Rest-api-specs is version 2.0.
I think its ok to define dictionary inline.
Contributor
There was a problem hiding this comment.
It can be defined like in the link. For example, here is an example from another RP:
mcardosos
reviewed
Feb 9, 2018
| "type": "object", | ||
| "description": "Dictionary of network adapters attached to the machine. Key is ID of disk. Value is a network adapter object", | ||
| "readOnly": true, | ||
| "properties": { |
Contributor
There was a problem hiding this comment.
properties [](start = 11, length = 10)
Same here, it is better not to define objects inline
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Get all groups", | ||
| "description": "Get all groups created in the project. Returns a json array of objects of type 'group' as specified in the Models section.", | ||
| "operationId": "Groups_ListByProject", |
Contributor
There was a problem hiding this comment.
Groups_ListByProject [](start = 24, length = 20)
Pageable?
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Get all assessments created in the project.", | ||
| "description": "Get all assessments created in the project.\n\nReturns a json array of objects of type 'assessment' as specified in Models section.\n", | ||
| "operationId": "Assessments_ListByProject", |
Contributor
There was a problem hiding this comment.
Assessments_ListByProject [](start = 24, length = 25)
Pageable?
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Get all assessments created for the specified group.", | ||
| "description": "Get all assessments created for the specified group.\n\nReturns a json array of objects of type 'assessment' as specified in Models section.\n", | ||
| "operationId": "Assessments_ListByGroup", |
Contributor
There was a problem hiding this comment.
Assessments_ListByGroup [](start = 24, length = 23)
Pageable?
mcardosos
reviewed
Feb 9, 2018
| "description": "Hyperlink to download report.", | ||
| "readOnly": true | ||
| }, | ||
| "expirationTime": { |
mcardosos
reviewed
Feb 9, 2018
| "type": "object", | ||
| "description": "Dictionary of disks attached to the machine. Key is ID of disk. Value is a disk object", | ||
| "readOnly": true, | ||
| "properties": { |
Contributor
There was a problem hiding this comment.
properties [](start = 11, length = 10)
Here too, it is bet not to define stuff inline
mcardosos
reviewed
Feb 9, 2018
| "type": "object", | ||
| "description": "Dictionary of network adapters attached to the machine. Key is name of the adapter. Value is a network adapter object", | ||
| "readOnly": true, | ||
| "properties": { |
Contributor
There was a problem hiding this comment.
properties [](start = 11, length = 10)
Same, it is better with its own definition
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Get assessed machines for assessment.", | ||
| "description": "Get list of machines that assessed as part of the specified assessment. Returns a json array of objects of type 'assessedMachine' as specified in the Models section.\n\nWhenever an assessment is created or updated, it goes under computation. During this phase, the 'status' field of Assessment object reports 'Computing'.\nDuring the period when the assessment is under computation, the list of assessed machines is empty and no assessed machines are returned by this call.\n", | ||
| "operationId": "AssessedMachines_ListByAssessment", |
Contributor
There was a problem hiding this comment.
AssessedMachines_ListByAssessment [](start = 24, length = 33)
Pageable?
mcardosos
reviewed
Feb 9, 2018
| "description": "Name of the operation.", | ||
| "readOnly": true | ||
| }, | ||
| "display": { |
Contributor
There was a problem hiding this comment.
display [](start = 9, length = 7)
It is better for stuff to have its own definition, instead of defining inline
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Get the specified project.", | ||
| "description": "Get the project with the specified name.", | ||
| "operationId": "GetProject", |
Contributor
There was a problem hiding this comment.
GetProject [](start = 24, length = 10)
Maybe Project_Get?
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Create or update project.", | ||
| "description": "Create a project with specified name. If a project already exists, update it.", | ||
| "operationId": "CreateProject", |
Contributor
There was a problem hiding this comment.
CreateProject [](start = 24, length = 13)
Project_Create might be better
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Update project.", | ||
| "description": "Update a project with specified name. Supports partial updates, for example only tags can be provided.", | ||
| "operationId": "UpdateProject", |
Contributor
There was a problem hiding this comment.
UpdateProject [](start = 24, length = 13)
Project_Update?
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Delete the project", | ||
| "description": "Delete the project. Deleting non-existent project is a no-operation.", | ||
| "operationId": "DeleteProject", |
Contributor
There was a problem hiding this comment.
DeleteProject [](start = 24, length = 13)
Project_Delete?
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Get shared keys for the project.", | ||
| "description": "Gets the Log Analytics Workspace ID and Primary Key for the specified project.", | ||
| "operationId": "KeysPost", |
Contributor
There was a problem hiding this comment.
KeysPost [](start = 24, length = 8)
How does Project_GetKeys sound?
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Get a specific machine.", | ||
| "description": "Get the machine with the specified name. Returns a json object of type 'machine' defined in Models section.", | ||
| "operationId": "GetMachine", |
Contributor
There was a problem hiding this comment.
GetMachine [](start = 24, length = 10)
What about Machine_Get?
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Get a specific group.", | ||
| "description": "Get information related to a specific group in the project. Returns a json object of type 'group' as specified in the models section.", | ||
| "operationId": "GetGroup", |
Contributor
There was a problem hiding this comment.
GetGroup [](start = 24, length = 8)
Group_Get?
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Create a new group with specified settings. If group with the name provided already exists, then the existing group is updated.", | ||
| "description": "Create a new group by sending a json object of type 'group' as given in Models section as part of the Request Body. The group name in a project is unique. Labels can be applied on a group as part of creation.\n\nIf a group with the groupName specified in the URL already exists, then this call acts as an update.\n\nThis operation is Idempotent.\n", | ||
| "operationId": "CreateGroup", |
Contributor
There was a problem hiding this comment.
CreateGroup [](start = 24, length = 11)
Group_Create?
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Delete the group", | ||
| "description": "Delete the group from the project. The machines remain in the project. Deleting a non-existent group results in a no-operation.\n\nA group is an aggregation mechanism for machines in a project. Therefore, deleting group does not delete machines in it.\n", | ||
| "operationId": "DeleteGroup", |
Contributor
There was a problem hiding this comment.
DeleteGroup [](start = 24, length = 11)
Group_Delete?
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Get an assessment.", | ||
| "description": "Get an existing assessment with the specified name. Returns a json object of type 'assessment' as specified in Models section.", | ||
| "operationId": "GetAssessment", |
Contributor
There was a problem hiding this comment.
GetAssessment [](start = 24, length = 13)
Assessments_Get?
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Create or Update assessment.", | ||
| "description": "Create a new assessment with the given name and the specified settings. Since name of an assessment in a project is a unique identiefier, if an assessment with the name provided already exists, then the existing assessment is updated.\n\nAny PUT operation, resulting in either create or update on an assessment, will cause the assessment to go in a \"InProgress\" state. This will be indicated by the field 'computationState' on the Assessment object. During this time no other PUT operation will be allowed on that assessment object, nor will a Delete operation. Once the computation for the assessment is complete, the field 'computationState' will be updated to 'Ready', and then other PUT or DELETE operations can happen on the assessment.\n\nWhen assessment is under computation, any PUT will lead to a 400 - Bad Request error.\n", | ||
| "operationId": "CreateAssessment", |
Contributor
There was a problem hiding this comment.
CreateAssessment [](start = 24, length = 16)
Assessments_Create?
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Deletes an assessment from the project.", | ||
| "description": "Delete an assessment from the project. The machines remain in the assessment. Deleting a non-existent assessment results in a no-operation.\n\nWhen an assessment is under computation, as indicated by the 'computationState' field, it cannot be deleted. Any such attempt will return a 400 - Bad Request.\n", | ||
| "operationId": "DeleteAssessment", |
Contributor
There was a problem hiding this comment.
DeleteAssessment [](start = 24, length = 16)
Assessments_Delete?
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Get download URL for the assessment report.", | ||
| "description": "Get the URL for downloading the assessment in a report format.", | ||
| "operationId": "DownloadUrlPost", |
Contributor
There was a problem hiding this comment.
DownloadUrlPost [](start = 24, length = 15)
WDYT about Assessments_GetReportURL?
Contributor
Author
There was a problem hiding this comment.
Updated with Assessments_GetReportDownloadUrl
mcardosos
reviewed
Feb 9, 2018
| ], | ||
| "summary": "Get an assessed machine.", | ||
| "description": "Get an assessed machine with its size & cost estimnate that was evaluated in the specified assessment.", | ||
| "operationId": "GetAssessedMachine", |
Contributor
There was a problem hiding this comment.
GetAssessedMachine [](start = 24, length = 18)
AssessedMachines_Get?
Contributor
Is this API version based on the previous one? If that is the case, please submit the PR this way...
Refers to: specification/migrate/resource-manager/Microsoft.Migrate/2018-02-02/migrate.json:5 in c14408c. [](commit_id = c14408c, deletion_comment = False) |
mcardosos
suggested changes
Feb 9, 2018
Contributor
mcardosos
left a comment
mcardosos
left a comment
There was a problem hiding this comment.
Added some comments.
Also, CI detects semantic validation errors. I can take a better look after the semantic errors have been fixed.
Contributor
|
Also, adding @ravbhatnagar from ARM for review. |
mcardosos
added
the
WaitForARMFeedback
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
Contributor
|
Good :) Only missing issue is how dictionaries are expressed in the swagger. |
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback Thanks for your co-operation. |
Contributor
|
Looks good. This has been reviewed already. no major changes from the last review. @johanste @devigned @NiklasGustafsson - This was reviewed by the board in the past. This service is going GA. From what I can tell, there arent major changes from what was reviewed earlier. Please see if you would like to review again. |
ravbhatnagar
added
App Services
ARMSignedOff
mcardosos
reviewed
Feb 16, 2018
| "description": "Time when this machine was discovered by Azure Migrate agent. Date-Time represented in ISO-8601 format.", | ||
| "readOnly": true | ||
| }, | ||
| "disks": { |
Contributor
There was a problem hiding this comment.
disks [](start = 9, length = 5)
"disks": {
"type": "object",
"description": "Dictionary of disks attached to the machine. Key is ID of disk. Value is a disk object",
"readOnly": true,
"additionalProperties": {
"$ref": "#/definitions/Disk"
}
}This is enough. I don't believe that extra disk level is need. Same for the network adapters dictionary.
Contributor
Author
There was a problem hiding this comment.
This causes the example validation to fail for Machines_Get.
Contributor
There was a problem hiding this comment.
Err, no. The error has to do with incorrect examples. Please look closer.
mcardosos
approved these changes
Mar 1, 2018
Contributor
mcardosos
left a comment
mcardosos
left a comment
There was a problem hiding this comment.
Great! Thanks for the good teamwork :)
Question, is this API already deployed?
Contributor
Author
|
Thanks Mariana for looking into the specs diligently and helping us get the right swagger out. |
Automation for azure-sdk-for-nodeNothing to generate for azure-sdk-for-node |
RandalliLama
added a commit
that referenced
this pull request
Mar 16, 2018
* Add purge operations to AppInsights management plane (#2528) * Add purge to management plane API * Adding purge status operation * Change purge statue to enum * capitalize response status * [AppInsights Data Plane] Fix table schema (#2527) * Remove internal schena column * Fix row schema * Application Insights: Add Favorites and Web Test Locations APIs (#2416) * Initial addition of favorites and locations API * Complete web test locations API - favor 'web test' names/descriptions over 'synthetic monitor' as web test is more customer-centric naming - create example data for the web test api * Spelling update * Updated parameters for favorite API * Add favorites API and examples - ensure tests run against the applicationinsights folder successfully * Add collectionFormat to comma-separated tags list parameter for favorites - generating API in CSharp generated errors * Enum for favorite type should be set to modelAsString as further favorite types are possible in future. * Update suppressions to include specific instances I need suppressed (no global suppressions where possible). * Suppress some noisey test warnings from API specifications from my peers. * PR suggestions - Remove x-ms-pageable annotation from our list operation, in the service code we never paganate our data. - Add x-ms-enum annotation to one enum data type where it was missing. * Event Hub: Added missing API to respective API version Swaggers (#2457) * Added the missing API discovered in ARM_RP_Fundamentals to the respective API version swagger and review comments * added tag for 2014-09 * Update the output-folder to match azure-sdk-for-net paths in Vision package (#2529) * Added enableBatchedOperations property to ServiceBus Queue (#2534) * [Don't Merge, Service roll out 2/28/2018] Swagger For new rdbms API change for new biz model (#2414) * Add new version for mysql and pgsql * Correct readme version * Correct create properties parameter * Correct PG namespace and some other comment * Update Examples folder to examples * Correct property name cases in the examples * Corrected the ServerResult objects in CRUD samples * Correct property values for server response in samples * make createtime and lastmodifiedtime for logfileproperties to readonly * Web Python conf (#2549) * Add a directive for node and TS (#2550) * Swagger specs for all existing versions of Microsoft.PolicyInsights (#2523) * Swagger specs for all existing versions of Microsoft.PolicyInsights * Add support for --validate; make where clauses explicit in existing (approval request pending) suppressions; add new suppression for equivalent paths error (approval request pending) * Fix $top in examples; fix casing in examples * Fix two more instances of $top type in examples * Fix metadata examples by adding content type header and changing the body to a single string * Remove EQUIVALENT_PATH suppressions; add extendedProperties as additionalProperties; add @odata.count to operations; remove "type" from "rows" in first 2017-08-09-preview and add descriptions * Fix remaining examples with bad casings * Fix additionalParameters definition; fix duplicate paths * Remove redundant operations path/definitions from one of the swagger files for each version (one per namespace is sufficient as long as both files are fed into autorest as a bundle) * DataMigration py conf (#2553) * Fix recommendation resource properties, add disable recommendation APIs (#2548) * Add Billing Account resource to Billing RP. (#2517) * Add "Classic Account" ARM resource. * 1. Change classic account property name from "userPrincipalName" to "principalName" 2. Add examples * Fix API version in examples. * Add example links. * ClassicAccount->BillingAccount * Removing "uuid" - billing account name may be a concatenation of uuid and additional keys. * Remove unused parameters. * 1. Add new version to readme.md 2. Fix validation warnings * Fix descriptions. * Fix type mismatch error. * Adding missing parameter in example. * Fix ms-examples name. * Compute spec change for zone resilient images (#2551) * Compute spec change for zone resilient images * Address feedback from the previous iteration * [DO NOT MERGE]update swaggers for azure elastic pool operation (#2520) * update swaggers for azure database and elastic pool operation * update ListDatabaseOperations and ListElasticPoolOperations examples * Only update the swagger for elastic pool operations * end * remove two not needed folders. Fix the error in ListElasticPoolOperation * Update the cancel operations swagger on database and pool, and corresponding examples * fix indentation in cancelOperations.json and cancelPoolOperations.json * Update Azure Database Migration Service to add Managed Instance as target (#2531) * Copy over 2017-11-15-preview folder in preparation for adding 2018-03-15-preview api version. * Update Azure Database Migration Service to add Managed Instance as target * Take out GeoRestore option (#2559) * [Monitor] Fixing issue with metricsnamespace incorrecly specified as client level argument #2565 (#2566) * [Monitor] Make all attributes of EventData class readonly (#2254) * [Monitor] Fixing issue with metricnamespace specification as client level argument #2565 * [Azure Search] Change output path for .NET data plane SDK (#2554) This is part of a planned refactoring that will split the Azure Search .NET data plane SDK into separate packages. * Fix links in the PR template (#2571) * Remove unused API (#2564) Please note this is not a GA API and has been deprecated for a while. There is no current user for it. * Adding preview/stable to the example layout. (#2561) * Adding preview/stable to the example layout. * Fixing formatting * fixed Go SDK path for automation (#2562) * [Monitor] Fixing issue with metrics api queryparameter name (#2575) (#2577) * add databricks activity (#2568) * Swagger completeness for Redis Cache (#2537) * Default string modeled as parameter for auto generation to work correctly * Adding CheckNameAvailability and listUpgradeNotifications into swagger for redis * Fixing code review comments * remove "/" at end for list apis * Name change for notification * Fixing code review comments in PR * Fixing examples that are breaking the build * Add missing type specifier to enum definition. (#2580) * Change group name for operations path, and rename response type definition (#2563) * Swagger specs for all existing versions of Microsoft.PolicyInsights * Add support for --validate; make where clauses explicit in existing (approval request pending) suppressions; add new suppression for equivalent paths error (approval request pending) * Fix $top in examples; fix casing in examples * Fix two more instances of $top type in examples * Fix metadata examples by adding content type header and changing the body to a single string * Remove EQUIVALENT_PATH suppressions; add extendedProperties as additionalProperties; add @odata.count to operations; remove "type" from "rows" in first 2017-08-09-preview and add descriptions * Fix remaining examples with bad casings * Fix additionalParameters definition; fix duplicate paths * Remove redundant operations path/definitions from one of the swagger files for each version (one per namespace is sufficient as long as both files are fed into autorest as a bundle) * Change group name for operations path, and rename response type definition * Change group name for operations path, and rename response type definition (old API versions) * ApiManagement 2018-01-01 version spec (#2292) * Copy the 2017-03-01 files * 2018-01-01 specific changes revert x-ms-enum and update description * 202 on create or update, network status and backend flatten 202 on create or update, networkstatus backend flatten Head for ApiRevision * Fix ValidationRegex of Ids and length * Fix the TagResource contract * Make PUT operation on portalsettings resources ARM-compliant Fix examples * Removed x-ms-client-flatten * NextLinkName and fix Check Entity Exist * Bring back default responses and fix examples * [Do not merge] CDN in all languages in conf (#2514) * CDN in all languages in conf * Review from Node and Amar * Use "net" in tag and not "csharp" * Remove wrong C# comment from Readme * Update Ruby to match real repo * Fix Ruby folder * Azure migrate GA and public preview rest api specs. (#2446) * Azure migrate GA and public preview rest api specs. * Resolving PR comments and semantic errors * Modifying dictionary definition in rest api specs * Defining dictionary in data model * add delete restore points API (#2593) * fix name for backward compatibility * fix name for backward compatibility 2 * fix return type name * fix message - sdk review comment * add delete restore points API and change to async for create API * [Refactor] Client name should be more specific (#2596) As per request: Azure/azure-sdk-for-python#2048 (review) * Add DNS 2017-10-01 API version (#2558) * Add DNS 2017-10-01 API version * Copy 2017-09-01 DNS API version to 2017-10-01 * Add 2017-10-01 DNS API version * Add x-ms-client-name for recordsetnamesuffix for RecordSets_ListAllByDnsZone * Update Sql-ResourceManager readme for list and cancel database/pool operation (#2592) * Update Sql-ResourceManager readme for a previous pull request on updating list and cancel operation on database and pool * fix a type in readme * keep the default tag as unchanged for now * ApiManagement. Fix reference (#2606) * ApiManagement. Fix reference * apimdiagnostics. * syntax error fix * Sampling settings added to logger entity (#2600) * remove async keyword since mocha does not run the tests correctly. (#2609) * Build Network with Autorest.Python 3.0 (#2611) * Reorganize policyinsights; change modelAsString for x-ms-enum to true (#2599) * Swagger specs for all existing versions of Microsoft.PolicyInsights * Add support for --validate; make where clauses explicit in existing (approval request pending) suppressions; add new suppression for equivalent paths error (approval request pending) * Fix $top in examples; fix casing in examples * Fix two more instances of $top type in examples * Fix metadata examples by adding content type header and changing the body to a single string * Remove EQUIVALENT_PATH suppressions; add extendedProperties as additionalProperties; add @odata.count to operations; remove "type" from "rows" in first 2017-08-09-preview and add descriptions * Fix remaining examples with bad casings * Fix additionalParameters definition; fix duplicate paths * Remove redundant operations path/definitions from one of the swagger files for each version (one per namespace is sufficient as long as both files are fed into autorest as a bundle) * Change group name for operations path, and rename response type definition * Change group name for operations path, and rename response type definition (old API versions) * Reorganize files; change modelAsString for x-ms-enum to true Reorganize files (remove resource type based subfolders; rename conflicting example files to have resource type name; change swagger spec files and MD file based on new file locations and names); change modelAsString for x-ms-enum to true based on API review board recommendation * Dummy change to kick the CI again * update roledefinition filters to be in sync with the filters present in service (#2586) * fix the hardcoding of api version for classicadmin in sdk * fix 2017 version preview file * update filter to make it in sync with service * update filter to make it in sync with service * Fix java code generation for resources (#2613) * Add on error deployment ARM (#2560) * Add on error deployment ARM * Update readme.md file * Add provisioning state for the on error deployment * Add on error deployment examples * fix json * json formatting * Fix schema for examples * 2018-01-01 sync of api changes from 2017-03-01 (#2585) * Copy changes from 2017-03-01 to 2018-01-01 * 2018-01-01 version specific changes * [Cognitive Services] March release (add usages operation, addnew/decomission some APIs) (#2544) * March release initial checkin 1. Add usages operation; 2. Add new APIs; 3. Remove decommisioned APIs * Add WebLM back Add WebLM back * Adding ZRS support for snapshots, new apiversion 2018-04-01 (#2552) * adding disk.json zrs support for snapshots * change modelAsString to true to support new enums * adding create option restore * adding example files * adding examples folder and moving files * adding file * Update readme.md * adding 200 responses... * Adding 2 new APIs for VMSS: Redeploy and PerformMaintenance (#2589) * Fix SDK breaking change in 2017-10-01 DNS Swagger (#2612) * Fix SDK breaking change in 2017-10-01 DNS Swagger and add linter error suppressions * Add scoping to error suppressions in 2017-10-01 DNS Swagger * ApiMgmt Py conf (#2624) * Change the default tag to 2017-10 (#2516) * Add swagger for dataWarehouseUserActivities API (#2389) * Add swagger for dataWarehouseUserActivities Add swagger for dataWarehouseUserActivities * add example file add example file * correct case sensitive name datawarehouseUserActivities to dataWarehouseUserActivities * add dataWarehouseUserActivityName add dataWarehouseUserActivityName * remove "value" GET ".../activities/current" should be a get single API, so it should not have "value" * Replace tab spaces with blank spaces * add missing "body" * Reducing CI Log output Verbosity (#2619) * Reducing CI Log output Verbosity Removing "-v" option from Swagger -> SDK jobs. Updating the reporter used by `mocha` to use the "min" reporter. Documenation of available options is here: http://ricostacruz.com/mocha/#reporters * Using most up-to-date OAV * Adding back Swagger -> SDK verbosity. * Adding OperationalInsights Purge, PurgeStatus operations (#2541) * Adding OperationalInsights Purge, PurgeStatus operations * Modifying long running operation * Diagnostics and Tags are per Api Revision (#2622) * API managment: make the same description for API 2016-07-07 SubscriptionIdParameter. (#2631) * Swagger for Salesforce Marketing Cloud Connector, ServiceUri in Dynamics LS, and SSL support in MongoDB LS (#2579) * Add example for creating Revisions (#2633) * [Cognitive Services] Change type of limit/currentValue to double from integer (#2627) Change limit/currentValue to double from integer * Rename BillingAccount->EnrollmentAccount. (#2626) * Remove entities-view-parameter from swagger (#2602) * Add Microsoft.Databricks workspaces swagger (#2594) * copy of managedapplications.json * change to databricks.json * renaming. * databricks api * address comments: add patch tags, change GenericResource to TrackedResouce, add some common parameters. * move sku from TrackedResource to Workspace. * move resourceGroupName and WorkspaceName to method level * fix error response. * add listWorkspacesByResourceGroup nad listWorkspacesBySubscription. * Adding Container Exec Spec (#2584) * Adding exec api to swagger operation * fixing small syntax error * Updating correct examples for async operation * fixing ARM header field * remvoing extra async operations * Update Python version * Remove advisor Java block from CognitiveServices readme.md (#2641) * Adding changes to support Private DNS Public Preview (#2587) * Copy 2017-10-01 DNS API version to 2018-03-01-preview * Add 2018-03-01-preview DNS API version * updating examples to version 2018-03-01-preview * Adding private zone example * removing the required property on zoneType also fixing example * Adding scoping to error suppressions * Update iotdps.json (#425) * Added Tags filter for budgets and updated the api version (#2625) * Added Tags filter for budgets and updated the api version Added Tags filter for budgets and updated the api version * Updated comments Updated comments * Incorporated review comments Incorporated review comments * Incorporated review comments Incorporated review comments * Incorporated review comment Incorporated review comment * Group DPSCertificate->List with other operations (#2643) * fixing relative paths to definitons and commondefinitions.json * Update iotdps.json "operationId": "DpsCertificates_List", -> "operationId": "DpsCertificate_List", so the list operation is grouped with the others on docs * Fix generated doc structure (#2634) * Plug disks 2018-04-01 for multi api versionning (#2648) * correct tier enum for postgres (#2629) * XMSParameterLocation Fixes (#2649) * Add node config to keyvault for Swagger to SDK (#2650) * Make OSDisk in storage profile optional (#2652) * Fix SDK breaking change in 2017-10-01 DNS Swagger ref #2612 (#2656) * Allow Ruby failure on CI (#2653) * Updating Travis to enforce branch strategy (#2657) * Updating Travis to enforce branch strategy * Fixing some typos * One more shot * Negating logic * Refactor sql readme.md (#2640) * Refactor sql readme.md - Rename schema-* to package-pure-* in order to follow convention for python multi-version - Rename package-2017-10-preview to package-composite-v1. The reasons for this are explained in package-2017-03-01-preview tag. The next tag that I add in the near future will be package-composite-v2, which will represent a breaking change & major version bump for clients. - Improved description of various sections - Whitespace/header consistency * Added package-pure-2017-10 including Go support * Commented on Go api-versions * Removed bad python section * Fixed typo in 2017-10 go package * Add more enum values for Identity/type in generic resource swagger (#2617) * Add more enum values for Identity/type in generic resource swagger Resource types like "Microsoft.Compute/VirtualMachines" have more than one enum value for Identity/type. Updating generic resource swagger so it is up-to-date. * Revert changes in swagger spec for 2017 API Version * [Monitor] Fixing incorrect specification of top parameter for Metrics API (#2655) (#2662) * [Monitor] Make all attributes of EventData class readonly (#2254) * [Monitor] Fixing issue with metricnamespace specification as client level argument #2565 * [Monitor] Fixing incorrect specification of top parameter for Metrics API (#2655) * Cleaning up branchStrategy messaging (#2663) * Cleaning up branchStrategy messaging * Fixing typo * Improve Microsoft.Insights schema generation (#2632) * Improve Microsoft.Insights schema generation - Case of microsoft.insights updated to Microsoft.Insights throughout - Added schema tag to readme.md to limit the input files * Properly move folder to update case of name * Adding 2018-01-22 version for ProvisioningServices and IotHubs (#2542) * adding DPS camelCase changes, IoT Hub camelCase changes, basic sku * adding 2018-01-22 changes for dps and iothub * Add partner name for managmentparnter action response (#2665) * Adding preview version of Event Hubs Cluster to Azure REST API specs. (#2272) * Adding preview version of Event Hubs Cluster to Azure REST API specs. * Adding capacity property to EH Cluster examples. * Differentiating update semantics with patch semantics. * RP-Cluster API: Revamping namespaces enumeration in cluster. * Adding cluster sku property bag and moving capacity to sku. Also adding metricId property to the custom properties bag. * RP-Cluster: Modifiying EHCluster references to Cluster references. Adding changes to readme file as well. * RP-Cluster: Adding Event Hubs operations API to Cluster swagger. * RP-Cluster: Removing leftover EHNamespaces definitions. * Cluster: Distinguishing between Cluster and Configuration clients in operation ids. * [AKS] update list of supported VM sizes (#2668) * [AKS] update list of supported VM sizes * Sync up ACS VM sizes with AKS sizes * Fixing error in naming convention for rows and cols (#2651) * Support azureFunctionReceivers in actionGroup APIs (#2659) * [AKS] specify byte format for base64-encoded kubeconfig (#2669) * Adding API Specs for Long Term Retention V2 (#2256) * Adding API Specs for Long Term Retention V2 This change adds the swagger documentation for the Long Term Retention V2 feature along with examples for each of the APIs.. This includes the following APIs: Get an LTR Backup Get all LTR Backups under a database Get all LTR Backups under a server Get all LTR Backups under a location Delete an LTR Backup Set a database's LTR Policy Get a database's LTR Policy * Remove empty properties and update retention description This update is a response to the few comments that Anu left on the PR. It removes an empty properties entry and updates the retention descriptions to explain that they use an ISO 8601 standard. * Description and Entity Name Changes Made some slight changes to the entity names to better align with LTR V1 and added some better descriptors to some property descriptions. * Fixing Incorrect Description The weekOfYear parameter is not in an ISO 8601 format, it is just an integer between 1 and 52. Fixing that accordingly. * Remove Conflicting Definitions Need to remove backupLongTermRetentionPolicies so it doesn't conflict with the new backupLongTermRetentionPolicies. * Remove Reference to backupLongTermRetentionPolicies.json Need to remove the reference to backupLongTermRetentionPolicies.json in the readme. * Update ResourceId Updated the resource ID for longTermRetentionBackups so servers and databases are now longTermRetentionServers and longTermRetentionDatabases, respectively. This better aligns with REST. * Re-Adding LongTermRetentionPolicyGet.json LongTermRetentionPolicyGet.json was accidentally deleted in the last commit. * Fix Travis CI Errors Made some changes to the examples to fix the Travis CI errors. * Updating more references to BackupLongTermRetentionPolic(y|ies) * Re-adding backupLongTermRetentionPolicies.json * removing .travis.yml that was accidentally added * Revert "removing .travis.yml that was accidentally added" This reverts commit 3b80fa0. * Revert "Re-adding backupLongTermRetentionPolicies.json" This reverts commit b98cf6c. * undoing accidental .travis.yml * Fixing errors in model PR_ONLY=true Travis CI run * Fixing another Travis CI error * Removing .travis.yml from the change and changing LongTermRetentionPolicy to BackupLongTermRetentionPolicy to keep it consistent * resetting backupLongTermRetentionPolicies.json * Update more references of LongTermRetentionPolicy to BackupLongTermRetentionPolicy * updating readme.md comment * Add package-version for ADF (#2674) * Remove azure-validation from readme file (#2676) * Add CODEOWNERS file (#2673) This file will be used to automatically request PR reviews from SMEs on the service teams. It is autogenerated based on previous PR submitters. * Add Go tag for api management, api version 2018-01-01 (#2677) * Add Go tag for api management, api version 2018-01-01 * Generate go to preview path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger