Move ManagementGroups out of Resources to a separate folder #2469

rajshah11 · 2018-02-10T00:50:43Z

This PR moves ManagementGroups out of the Resources folder

Related PRs havings the specs and changes

Specs PRs

#2345
#2094
#1671

All minor changes

https://github.com/Azure/azure-rest-api-specs/pulls?q=is%3Apr+is%3Aclosed+author%3Arajshah11

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-02-10T00:51:42Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#1968

AutorestCI · 2018-02-10T00:52:01Z

Automation for azure-sdk-for-go

Swagger to SDK encountered a Subprocess error: (azure-sdk-for-go)

Command: profileBuilder -s list -l ./profiles/2017-03-09/defintion.txt -name 2017-03-09
Finished with return code 127
and output:

/bin/sh: 1: profileBuilder: not found

shahabhijeet · 2018-02-10T00:58:15Z

FYI @fearthecowboy this was already merged and approved earlier.

rajshah11 · 2018-02-10T01:09:31Z

Related PRs havings the specs and changes

Specs PRs

#2345
#2094
#1671

All minor changes

https://github.com/Azure/azure-rest-api-specs/pulls?q=is%3Apr+is%3Aclosed+author%3Arajshah11

rajshah11 · 2018-02-11T21:54:31Z

@fearthecowboy made this commit to incorporate the changes suggested for the earlier swagger in the latest one too.

fearthecowboy · 2018-02-12T16:31:29Z

I'm concerned about the errors reported, and the impact it has on generation of existing SDKs.

//CC: @lmazuel -- I'm assuming this impacts you too?

lmazuel · 2018-02-12T17:03:53Z

@fearthecowboy I fixed the Readme in this PR, thanks for mentionning me :). This client has not been released yet, so moving it outside of resources is not a problem for Python.
@marstr should double-check Go as well.

rajshah11 · 2018-02-12T17:07:38Z

@fearthecowboy The errors are caused by the resources folder and they were there before as well. I think they have to fix their SDKs and it's one of the reasons why we eventually decided to move out of the folder.

@lmazuel Thanks for fixing the python settings in the managementgroups readme

fearthecowboy · 2018-02-12T19:40:31Z

I'm ok with this; if @marstr is good for go then I can commit it.

…shah11/azure-rest-api-specs into management-groups-specs-move

marstr · 2018-02-12T21:05:25Z

specification/managementgroups/resource-manager/readme.md

+Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.
+
+``` yaml $(tag)=='package-2017-08' && $(go)
+output-folder: $(go-sdk-folder)/services/managementgroups/mgmt/2017-08-31-preview/managementgroups


The Go SDK has already shipped these clients to the former locations, as seen here:
Azure/azure-sdk-for-go@21b6814

Seeing as this would cause a breaking change for us, I'd like to leave the output-folder portion alone. Mind changing these to their old values?

Done. However, I can keep the new paths for the later api versions right? Thanks!

azuresdkciprbot · 2018-02-12T21:23:09Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/managementgroups/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/resources/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 71
After the PR: Warning(s): 0 Error(s): 71

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

marstr · 2018-02-12T23:21:00Z

specification/managementgroups/resource-manager/readme.md

+Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.
+
+``` yaml $(tag)=='package-2017-11' && $(go)
+output-folder: $(go-sdk-folder)/services/managementgroups/mgmt/2017-11-01-preview/managementgroups


Sorry I wasn't specific enough, please make this change to all of the go packages that you're modifying. :)

Done. Thanks

azuresdkciprbot · 2018-02-13T00:04:37Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/managementgroups/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/resources/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 71
After the PR: Warning(s): 0 Error(s): 71

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

marstr · 2018-02-13T02:37:35Z

My approval is limited to acknowledging that the paths in which these packages will be released has not changed for Go.

fearthecowboy

This is just a move,

Microsoft.Provider Hub GA api version

Move ManagementGroups out of Resources to a separate folder

50ef23a

azuresdkci assigned fearthecowboy Feb 10, 2018

Add resource-manager folder

457f726

rajshah11 added 4 commits February 9, 2018 17:36

Add python multiapi

3fb5b09

Fix bug

733ad67

Remove management groups from resources

a21fc25

Change groupId and cache control to method scope

c0ef0b8

Update readme.md to use the old version

ce5b89e

Fix Python conf

8c2f6ae

rajshah11 added 2 commits February 12, 2018 12:52

Fix Go settings

16f4982

Merge branch 'management-groups-specs-move' of https://github.com/raj…

e731940

…shah11/azure-rest-api-specs into management-groups-specs-move

marstr requested changes Feb 12, 2018

View reviewed changes

revert go sdk path for 2017-08-31

5bc0b51

marstr requested changes Feb 12, 2018

View reviewed changes

Revert go output folder

6d8ea21

AutorestCI mentioned this pull request Feb 13, 2018

[AutoPR resources/resource-manager/managementgroups/resource-manager] Move ManagementGroups out of Resources to a separate folder Azure/azure-sdk-for-python#1968

Merged

marstr approved these changes Feb 13, 2018

View reviewed changes

fearthecowboy approved these changes Feb 13, 2018

View reviewed changes

fearthecowboy merged commit 4dec5ea into Azure:master Feb 13, 2018

rajshah11 mentioned this pull request Feb 13, 2018

ManagementGroups SDK Azure/azure-sdk-for-net#4071

Merged

9 tasks

sarangan12 mentioned this pull request Feb 16, 2018

Change statusMessage property to wildcard type. #2486

Merged

10 tasks

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

Merge pull request #2469 from Azure/sanjaiga/providerhubGA_PR

14f97ac

Microsoft.Provider Hub GA api version

Move ManagementGroups out of Resources to a separate folder #2469

Move ManagementGroups out of Resources to a separate folder #2469

Uh oh!

Conversation

rajshah11 commented Feb 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR moves ManagementGroups out of the Resources folder

Related PRs havings the specs and changes

Specs PRs

All minor changes

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Feb 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Feb 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

shahabhijeet commented Feb 10, 2018

Uh oh!

rajshah11 commented Feb 10, 2018

Related PRs havings the specs and changes

Specs PRs

All minor changes

Uh oh!

rajshah11 commented Feb 11, 2018

Uh oh!

fearthecowboy commented Feb 12, 2018

Uh oh!

lmazuel commented Feb 12, 2018

Uh oh!

rajshah11 commented Feb 12, 2018

Uh oh!

fearthecowboy commented Feb 12, 2018

Uh oh!

marstr Feb 12, 2018

Choose a reason for hiding this comment

Uh oh!

rajshah11 Feb 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Feb 12, 2018

Uh oh!

marstr Feb 12, 2018

Choose a reason for hiding this comment

Uh oh!

rajshah11 Feb 12, 2018

Choose a reason for hiding this comment

Uh oh!

azuresdkciprbot commented Feb 13, 2018

Uh oh!

marstr commented Feb 13, 2018

Uh oh!

fearthecowboy left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rajshah11 commented Feb 10, 2018 •

edited

Loading

AutorestCI commented Feb 10, 2018 •

edited

Loading

AutorestCI commented Feb 10, 2018 •

edited

Loading

rajshah11 Feb 12, 2018 •

edited

Loading