Microsoft.Automation linkedWorkspace operations

[kunyuchen]

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes.
• Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

• I have read the contribution guidelines.
• My spec meets the review criteria:
  • The spec conforms to the Swagger 2.0 specification.
  • The spec follows the guidelines described in the Swagger checklist document.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.

[AutorestCI]

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 29, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 167, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 182, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 142, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 222, in generate_sdk_from_git_object
    manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 245, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch=branch)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 187, in clone_to_path
    _git_clone_to_path(https_authenticated_url, folder, branch)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/git_tools.py", line 72, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 551, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1010, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 821, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git checkout linkedWorkspace
  stderr: 'error: pathspec 'linkedWorkspace' did not match any file(s) known to git.'

[AutorestCI]

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#1959

[kunyuchen]

@vrdmr is added to the review. #Closed

[kunyuchen]

@vivlingaiah is added to the review. #Closed

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/automation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 36
After the PR: Warning(s): 0 Error(s): 36

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[olydis]

@ravbhatnagar new operations

[azuresdkciprbot]

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/automation/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 36
After the PR: Warning(s): 0 Error(s): 36

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

[kunyuchen]

@olydis Just to make sure we are on the same page - GET linkedWorkspace operation is not new. It is missing in the Swagger-based SDK. It is in the Hydra-based SDK though.

[olydis]

LGTM

[ravbhatnagar]

This is a collection GET call. It should return a value array. Also it only has id property?

[kunyuchen]

Right now, our web service returns a single linked workspace, with id property only for GET linkedWorkspace. The id property will either be null or the resource id of the linked workspace.

[kunyuchen]

The API has been out there for 1.5 years. It is not on Azure REST API documentation because of an issue we had with available operations API, which has been fixed.

[ravbhatnagar]

well, what can we do then :). This is definitely not the correct design.

[kunyuchen]

Thanks @ravbhatnagar for your feedback. I will advocate fixing the API in our next version:

GET /providers/Microsoft.Automation/automationAccounts/{automationAccountName}/linkedWorkspaces

which returns an array of linked workspaces.

Of course nothing is set in stone yet.

[ravbhatnagar]

Signing off! The API breaks the ARM RPC contract but as this has been in prod for 1.5 yrs, I dont think we should change it.

[lmazuel]

@AutorestCI rebuild azure-sdk-for-python