Skip to content

Conversation

@ofermoses
Copy link
Contributor

fixing doc of MDC alerts suppression API.
expiry time parameter has no limitation.
previous doc was wrong, fixing now to match actual logic

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 6, 2023

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 6, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
alertsSuppressionRules.json 2019-01-01-preview(24140e8) 2019-01-01-preview(main)
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2019-01-preview-only package-2019-01-preview-only(24140e8) package-2019-01-preview-only(main)
package-composite-v1 package-composite-v1(24140e8) package-composite-v1(main)
package-composite-v2 package-composite-v2(24140e8) package-composite-v2(main)
package-dotnet-sdk package-dotnet-sdk(24140e8) package-dotnet-sdk(main)
package-composite-v3 package-composite-v3(24140e8) package-composite-v3(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'alertsSuppressionRuleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L82
ResourceNameRestriction The resource name parameter 'alertsSuppressionRuleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L82
ResourceNameRestriction The resource name parameter 'alertsSuppressionRuleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L82
ResourceNameRestriction The resource name parameter 'alertsSuppressionRuleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L82
ResourceNameRestriction The resource name parameter 'alertsSuppressionRuleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L82
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L120
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L120
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L120
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L120
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L120
DeleteResponseCodes Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L160
DeleteResponseCodes Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L160
DeleteResponseCodes Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L160
DeleteResponseCodes Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L160
DeleteResponseCodes Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L160
DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L182
DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L182
DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L182
DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L182
DeleteOperationResponses The delete operation is defined without a 200 or 204 error response implementation,please add it.'
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L182
XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L297
XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L297
XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L297
XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L297
XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L297
⚠️ PreviewVersionOverOneYear The API version:2019-01-01-preview having been in a preview state over one year , please move it to GA or retire.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L6
⚠️ PreviewVersionOverOneYear The API version:2019-01-01-preview having been in a preview state over one year , please move it to GA or retire.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L6
⚠️ PreviewVersionOverOneYear The API version:2019-01-01-preview having been in a preview state over one year , please move it to GA or retire.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L6
⚠️ PreviewVersionOverOneYear The API version:2019-01-01-preview having been in a preview state over one year , please move it to GA or retire.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L6
⚠️ PreviewVersionOverOneYear The API version:2019-01-01-preview having been in a preview state over one year , please move it to GA or retire.
Location: Microsoft.Security/preview/2019-01-01-preview/alertsSuppressionRules.json#L6
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/security/resource-manager/readme.md
tag: specification/security/resource-manager/readme.md#tag-package-composite-v3
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 6, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️❌SDK Breaking Change Tracking failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-go failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-python-track2 warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-java warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-resource-manager-schemas warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-powershell failed [Detail]

Only 0 items are rendered, please refer to log for more details.

Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 6, 2023

Generated ApiView

Language Package Name ApiView Link
.Net Azure.ResourceManager.SecurityCenter https://apiview.dev/Assemblies/Review/1058420195f842cfbb509f5857b30abc
JavaScript @azure/arm-security https://apiview.dev/Assemblies/Review/23dd81ec5a944841980cfc8f5aa362c8
Java azure-resourcemanager-security https://apiview.dev/Assemblies/Review/759940fa9047484190d54ea82185730f

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 6, 2023
@zizw123 zizw123 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 6, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 6, 2023
@rkmanda rkmanda merged commit 21d0c31 into Azure:main Nov 16, 2023
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-JavaScript ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants