Skip to content

Updating Travis to enforce branch strategy #2657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marstr merged 4 commits into from
Mar 14, 2018
Merged

Updating Travis to enforce branch strategy #2657

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ab654a
Updating Travis to enforce branch strategy
marstr Mar 14, 2018
1a1d6de
Fixing some typos
marstr Mar 14, 2018
59d0da1
One more shot
marstr Mar 14, 2018
f1d6809
Negating logic
marstr Mar 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ services:
- docker
env:
matrix:
- MODE=branchStrategy
- MODE=syntax
- MODE=python
- MODE=node
Expand Down Expand Up @@ -66,6 +67,10 @@ script:
if [[ $MODE == 'java' ]]; then
$DOCKER_CMD Azure/azure-libraries-for-java -v
fi
- >-
if [[ $MODE == 'branchStrategy']]; then
[[ $TRAVIS_PULL_REQUEST && $TRAVIS_PULL_REQUEST == 'Azure/azure-rest-api-specs-pr' && $TRAVIS_BRANCH == 'master' ]]
Copy link
Contributor

@dsgouda dsgouda Mar 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Since I am new to this, should you also check $TRAVIS_BRANCH for null?

Copy link
Member Author

@marstr marstr Mar 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant stuff from here: https://docs.travis-ci.com/user/environment-variables/

TRAVIS_BRANCH:
for push builds, or builds not triggered by a pull request, this is the name of the branch.
for builds triggered by a pull request this is the name of the branch targeted by the pull request.
for builds triggered by a tag, this is the same as the name of the tag (TRAVIS_TAG).

TRAVIS_PULL_REQUEST: The pull request number if the current job is a pull request, “false” if it’s not a pull request.

TRAVIS_PULL_REQUEST_SLUG:
if the current job is a pull request, the slug (in the form owner_name/repo_name) of the repository from which the PR originated.
if the current job is a push build, this variable is empty ("").

TRAVIS_REPO_SLUG: The slug (in form: owner_name/repo_name) of the repository currently being built.

Looks like I do have a typo though! For the second clause, I meant to have it be $TRAVIS_PULL_REQUEST_SLUG not $TRAVIS_PULL_REQUEST. Looking at it again though, I'll just use $TRAVIS_REPO_SLUG.

fi
- >-
if [[ $MODE == 'syntax' ]]; then
npm test -- test/syntax.js
Expand Down