-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Runbook Linting issues fixed #2687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runbook Linting issues fixed #2687
Conversation
Automation for azure-libraries-for-javaNothing to generate for azure-libraries-for-java |
Automation for azure-sdk-for-nodeA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
|
@ravbhatnagar new response code (200) has been added. |
|
@ravbhatnagar Ping. Could you please review this PR. Thanks. |
|
Signing off from ARM. It should not be a breaking change since the 200 response is the final response. Service would be returning a 202 only. Also, there should not be any service side behavior change. Please Correct my understanding. |
|
Yes. The service only returns 202 and there is no change done in the service. The 200 is only for fixing the Error statements during the linting. |
|
@vrdmr please, resolve conflicts. |
|
@sergey-shandar Resolved. Thanks. |
| "pattern": "^[-\\w\\._]+$", | ||
| "description": "The resource group name.", | ||
| "x-ms-parameter-location": "method" | ||
| "x-ms-parameter-location": "client" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, 'ResourceGroupNameParameter` should be a parameter of a method, not a client.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are planning to remove the ResourceGroupName and AutomationAccountName and put it only in the automationClient. We can set these values easily. Our SDK is still in preview and this is helping people to simplify the code.
Fixed the 200 response issue. Fixed the linting issues related to it. Also fixed the resource group binding.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger