Skip to content

Conversation

@vrdmr
Copy link
Member

@vrdmr vrdmr commented Mar 19, 2018

Fixed the 200 response issue. Fixed the linting issues related to it. Also fixed the resource group binding.


This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@vrdmr vrdmr requested a review from a user March 19, 2018 05:21
@AutorestCI
Copy link

AutorestCI commented Mar 19, 2018

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@AutorestCI
Copy link

AutorestCI commented Mar 19, 2018

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#2483

@AutorestCI
Copy link

AutorestCI commented Mar 19, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#1959

@AutorestCI
Copy link

AutorestCI commented Mar 19, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#1444

@sergey-shandar sergey-shandar added potential-sdk-breaking-change WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 19, 2018
@sergey-shandar
Copy link
Contributor

@ravbhatnagar new response code (200) has been added.

@vrdmr vrdmr mentioned this pull request Mar 21, 2018
10 tasks
@vrdmr
Copy link
Member Author

vrdmr commented Mar 21, 2018

@ravbhatnagar Ping. Could you please review this PR. Thanks.

@ravbhatnagar
Copy link
Contributor

Signing off from ARM. It should not be a breaking change since the 200 response is the final response. Service would be returning a 202 only. Also, there should not be any service side behavior change. Please Correct my understanding.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Mar 22, 2018
@vrdmr
Copy link
Member Author

vrdmr commented Mar 22, 2018

Yes. The service only returns 202 and there is no change done in the service. The 200 is only for fixing the Error statements during the linting.

@sergey-shandar
Copy link
Contributor

@vrdmr please, resolve conflicts.

@vrdmr
Copy link
Member Author

vrdmr commented Mar 23, 2018

@sergey-shandar Resolved. Thanks.

"pattern": "^[-\\w\\._]+$",
"description": "The resource group name.",
"x-ms-parameter-location": "method"
"x-ms-parameter-location": "client"
Copy link
Contributor

@sergey-shandar sergey-shandar Mar 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, 'ResourceGroupNameParameter` should be a parameter of a method, not a client.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are planning to remove the ResourceGroupName and AutomationAccountName and put it only in the automationClient. We can set these values easily. Our SDK is still in preview and this is helping people to simplify the code.

@sergey-shandar sergey-shandar merged commit 074577a into Azure:master Mar 27, 2018
@vrdmr vrdmr deleted the runbook-longrunning-op-fix branch April 3, 2018 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants