Skip to content

Mjmadhu playwrighttesting microsoft.azure playwright service 2023 10 01 preview new #27132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
visingla-ms merged 12 commits into from
Jan 31, 2024
Merged

Mjmadhu playwrighttesting microsoft.azure playwright service 2023 10 01 preview new #27132

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
768c90c
First commit with existing version files in new version folder
mjmadhu Dec 19, 2023
0e31391
Added new ARM stable api-version for GA
mjmadhu Dec 19, 2023
cbb8728
Readme changes
mjmadhu Dec 19, 2023
e257200
Addressed review comments
mjmadhu Jan 23, 2024
a33b250
Changed data type to float as discussed in the comments
mjmadhu Jan 24, 2024
bf4799a
Added suppression rules for SwaggerLintDiff as per review comment
mjmadhu Jan 24, 2024
74f2bbe
Added suppression rules for SwaggerLintDiff as per review comment
mjmadhu Jan 24, 2024
e2919ad
Fix for suppressions not working
mjmadhu Jan 29, 2024
cd1b96a
Modified suppression syntax to the new one as per TSG.
mjmadhu Jan 29, 2024
246fe78
Added paths in suppressions
mjmadhu Jan 30, 2024
db39d21
Rectifying path for ResourceNameRestriction Suppression
mjmadhu Jan 30, 2024
95f8d07
Paths not working correctly with ResourceNameRestriction suppression
mjmadhu Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Paths not working correctly with ResourceNameRestriction suppression
  • Loading branch information
@mjmadhu
mjmadhu committed Jan 30, 2024
commit 95f8d07c1f906dc05414b4c04edd2174fde7d500
6 changes: 3 additions & 3 deletions specification/playwrighttesting/resource-manager/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ suppressions:
- code: ResourceNameRestriction
from: playwrighttesting.json
reason: We have enums defined for quota resource names which doesn't support string pattern validation.
where:
- $.paths["/subscriptions/{subscriptionId}/providers/Microsoft.AzurePlaywrightService/locations/{location}/quotas/{quotaName}"].get.parameters.3
- $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzurePlaywrightService/accounts/{accountName}/quotas/{quotaName}"].get.parameters.4
# where:
# - $.paths["/subscriptions/{subscriptionId}/providers/Microsoft.AzurePlaywrightService/locations/{location}/quotas/{quotaName}"].get.parameters.3
# - $.paths["/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzurePlaywrightService/accounts/{accountName}/quotas/{quotaName}"].get.parameters.4
- code: ProvisioningStateMustBeReadOnly
from: playwrighttesting.json
reason: Seems like a tool bug, as the visibility is set to read only in the TypeSpec already.
Expand Down