Merge branch 'main' into asaflevi/healthinsights-radiologyinsights-ap…

…i-v3

.github/PULL_REQUEST_TEMPLATE/control_plane_template.md

@@ -10,29 +10,19 @@
 
 Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
 
-![diagram](https://github.com/Azure/azure-rest-api-specs/assets/20296335/35140fb9-639e-4e44-ac4b-38b1a20dddf9)
+![diagram](https://github.com/Azure/azure-rest-api-specs/assets/20296335/9e51cff7-28f7-4ae7-99a3-0f4a116c759f)
 
 <details>
-<summary> Click here to see the details of Step 1 </summary>
-
-### Breaking changes review (Diagram Step 1)
-
-If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
-  you must follow the [breaking changes process].  
-  **IMPORTANT** This applies even if:
-- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
-- You believe there is no need for you to request breaking change approval, for any reason. 
-    Such claims must be reviewed, and the process is the same.
+<summary>Click here to see the details of Step 1, Breaking Changes review</summary>
 
+If you are in purview of Step 1 of the diagram, follow the [Breaking Changes review process].  
+**IMPORTANT!** This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
 </details>
 
 <details> 
-<summary> Click here to see the details of Step 2 </summary>
-
-### ARM API changes review (Diagram Step 2)
-
-- For help with Step 2 / "ARM review", see https://aka.ms/azsdk/pr-arm-review.
+<summary>Click here to see the details of Step 2, ARM review</summary>
 
+See https://aka.ms/azsdk/pr-arm-review.
 </details>
 
 <details>
@@ -99,4 +89,4 @@ If one or multiple validation error/warning suppression(s) is detected in your P
 [ARM review queue]: https://aka.ms/azsdk/pr-arm-review#about-the-arm-review-queue
 [public repo merge queue]: https://github.com/Azure/azure-rest-api-specs/pulls?q=is%3Aopen+is%3Apr+label%3AMergeRequested+draft%3Afalse+sort%3Acreated-asc
 [private repo merge queue]: https://github.com/Azure/azure-rest-api-specs-pr/pulls?q=is%3Aopen+is%3Apr+label%3AMergeRequested+-label%3AApproved-OkToMerge+draft%3Afalse+sort%3Acreated-asc
-[breaking changes process]: https://eng.ms/docs/cloud-ai-platform/azure-core/azure-core-pm-and-design/trusted-platform-pm-karimb/service-lifecycle-and-actions-team/service-lifecycle-actions-team/apex/media/launchingproductbreakingchanges#breaking-change-process-1
+[Breaking Changes review process]: https://eng.ms/docs/cloud-ai-platform/azure-core/azure-core-pm-and-design/trusted-platform-pm-karimb/service-lifecycle-and-actions-team/service-lifecycle-actions-team/apex/media/launchingproductbreakingchanges#breaking-change-process-1

.github/PULL_REQUEST_TEMPLATE/data_plane_template.md

@@ -58,7 +58,7 @@ The [Azure API Review Board](https://aka.ms/azsdk/onboarding/restapischedule) is
 
 ### Helpful Links
 
- * [Azure DevTools Wiki](https://aka.ms/azapi)
+ * [Schedule a data plane REST API spec review](https://aka.ms/azsdk/onboarding/restapischedule)
 
 </details>
 

.github.amrom.workers.devment.yml

@@ -12,7 +12,7 @@
       <li>
       If this PR is targeting `main` branch, then it cannot be merged, as `azure-rest-api-specs-pr` repo `main` branch 
       is mirrored from `azure-rest-api-specs` `main`` branch. <br/>
-      If you want to publish the PR to the public repo (`Azure/azure-rest-api-specs`) `main` branch, 
+      If you want to publish the PR to the public repo (`Azure/azure-rest-api-specs`) `main` branch,
       please use [OpenAPIHub Publish PR](${openapiHub}/tools/publishpullrequest?pr=${owner}/${repo}/${PRNumber}&to=${to}).
       </li><li>
       For further guidance see [Spec Repos](https://eng.ms/docs/products/azure-developer-experience/design/api-specs-pr/api-repos).
@@ -82,7 +82,21 @@
 - rule:
     type: label
     label: Approved-BreakingChange
-    booleanFilterExpression: "!(ARMSignedOff||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)&&ARMReview"
+    booleanFilterExpression: "!(ARMSignedOff||WaitForARMFeedback||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)&&ARMReview"
+    onLabeledAddLabels:
+        - WaitForARMFeedback
+
+- rule:
+    type: label
+    label: BreakingChange-Approved-*
+    booleanFilterExpression: "!(ARMSignedOff||WaitForARMFeedback||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)&&ARMReview"
+    onLabeledAddLabels:
+        - WaitForARMFeedback
+
+- rule:
+    type: label
+    label: Versioning-Approved-*
+    booleanFilterExpression: "!(ARMSignedOff||WaitForARMFeedback||ARMChangesRequested||Approved-OkToMerge||WaitForARMRevisit)&&ARMReview"
     onLabeledAddLabels:
         - WaitForARMFeedback
 

cSpell.json

@@ -45,6 +45,12 @@
         "typescript"
     ],
     "overrides": [
+        {
+            "filename": "**/specification/batch/**/*.json",
+            "words": [
+                "TVMs"
+            ]
+        },
         {
             "filename": "**/specification/databox/resource-manager/Microsoft.DataBox/stable/2018-01-01/databox.json",
             "words": [
@@ -278,6 +284,49 @@
                 "Droppeded"
             ]
         },
+        {
+            "filename": "**/specification/sql/resource-manager/Microsoft.Sql/preview/2023-08-01-preview/DistributedAvailabilityGroups.json",
+            "words": [
+                "freemium"
+            ]
+        },
+		{
+            "filename": "**/specification/sql/resource-manager/Microsoft.Sql/preview/2023-02-01-preview/ManagedInstances.json",
+            "words": [
+                "freemium"
+            ]
+        },
+		{
+            "filename": "**/specification/sql/resource-manager/Microsoft.Sql/preview/2023-05-01-preview/ManagedInstances.json",
+            "words": [
+                "freemium"
+            ]
+        },
+		{
+            "filename": "**/specification/sql/resource-manager/Microsoft.Sql/preview/2023-08-01-preview/ManagedInstances.json",
+            "words": [
+                "freemium"
+            ]
+        },
+		{
+            "filename": "**/specification/sql/resource-manager/Microsoft.Sql/preview/2023-08-01-preview/ServerTrustCertificates.json",
+            "words": [
+                "freemium"
+            ]
+        },
+		{
+            "filename": "**/specification/sql/resource-manager/Microsoft.Sql/preview/2023-08-01-preview/ManagedInstanceDtcs.json",
+            "words": [
+                "msdtcdns",
+                "msdtc's"
+            ]
+        },
+		{
+            "filename": "**/specification/sql/resource-manager/Microsoft.Sql/preview/2023-08-01-preview/TimeZones.json",
+            "words": [
+                "freemium"
+            ]
+        },
         {
             "filename": "**/specification/datafactory/resource-manager/Microsoft.DataFactory/preview/2017-09-01-preview/entityTypes/IntegrationRuntime.json",
             "words": [
@@ -831,9 +880,11 @@
             ]
         },
         {
-            "filename": "**/specification/communication/data-plane/Chat/preview/2020-09-21-preview2/communicationserviceschat.json",
+            "filename": "**/specification/communication/data-plane/Chat/**/communicationserviceschat.json",
             "words": [
-                "readreceipts"
+                "readreceipts",
+                "heic",
+                "webp"
             ]
         },
         {
@@ -892,7 +943,8 @@
             "words": [
                 "Orignal",
                 "Seleted",
-                "targetvCenterId"
+                "targetvCenterId",
+                "esxi"
             ]
         },
         {
@@ -948,6 +1000,12 @@
                 "npipe"
             ]
         },
+        {
+            "filename": "**/specification/machinelearningservices/data-plane/Microsoft.MachineLearningServices/preview/20*-preview/azure-ai-assets.json",
+            "words": [
+                "genericasset"
+            ]
+        },
         {
             "filename": "**/specification/dataprotection/resource-manager/Microsoft.DataProtection/**/dataprotection.json",
             "words": [
@@ -1000,7 +1058,23 @@
         {
             "filename": "**/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/**/*.json",
             "words": [
-                "Criterias"
+                "Criterias",
+                "nwrfc",
+                "Abap",
+                "AGRTCODES",
+                "AGRUSERS",
+                "AGRPROF",
+                "ADCP",
+                "USGRPUSER",
+                "USERADDR",
+                "DEVACCESS",
+                "AGRDEFINE",
+                "PAHI",
+                "AGRAGRS",
+                "USRSTAMP",
+                "AGRFLAGS",
+                "SNCSYSACL",
+                "USRACL"
             ]
         },
         {
@@ -1071,6 +1145,56 @@
                 "upgradingos",
                 "TVMs"
             ]
+        },
+        {
+            "filename": "**/specification/awsconnector/resource-manager/Microsoft.AwsConnector/**/*.json",
+            "words": [
+                "ACUs",
+                "AWSRDS",
+                "DCERPC",
+                "Dsse",
+                "dsse",
+                "dualstack",
+                "ENIs",
+                "Fargate",
+                "multimaster",
+                "nodegroup",
+                "Nodegroups",
+                "nondefault",
+                "ONEZONE",
+                "parallelquery",
+                "preconfigures",
+                "tierings",
+                "VPC's",
+                "wihtin"
+            ]
+        },
+        {
+           "filename": "**/specification/confidentialledger/data-plane/Microsoft.CodeTransparency/preview/**/*.json",
+           "words": [
+                "cbor",
+                "txids",
+                "operationid",
+                "scitt"
+            ]
+        },
+        {
+            "filename": "**/specification/applicationinsights/data-plane/LiveMetrics/preview/2024-04-01-preview/livemetrics.json",
+            "words": [
+                "LiveMetrics",
+                "QuickPulse",
+                "ikey",
+                "apikey",
+                "Comparand",
+                "SDK"
+            ]
+        },
+        {
+            "filename": "**/specification/cognitiveservices/data-plane/ContentSafety/**/*.json",
+            "words": [
+                "Groundedness",
+                "ungroundedness"
+            ]
         }
     ],
     "enableFiletypes": [

custom-words.txt

@@ -563,6 +563,7 @@ connectionstrings
 conntrack
 consistencygroup
 consumergroups
+containerd
 containerid
 containerinstance
 containerlogs
@@ -2238,6 +2239,7 @@ projecthilo
 propagations
 propogation
 protectable
+protobuf
 Providedal
 providerhub
 providerport

documentation/ci-fix.md

@@ -26,10 +26,12 @@
   - [`Swagger ApiDocPreview`](#swagger-apidocpreview)
   - [`TypeSpec Validation`](#typespec-validation)
     - [Run `tsv` locally](#run-tsv-locally)
+  - [APIView Failures: troubleshooting guides](#apiview-failures-troubleshooting-guides)
   - [Suppression Process](#suppression-process)
   - [Checks not covered by this guide](#checks-not-covered-by-this-guide)
   - [Obsolete checks](#obsolete-checks)
 
+
 # CI Fix Guide
 
 Short link: https://aka.ms/azsdk/ci-fix
@@ -143,7 +145,6 @@ npm install -g @azure/oad
 oad compare <old-spec-path> <new-spec-path>
 ```
 Please see [readme](https://github.com/Azure/openapi-diff/blob/main/README.md) for how to install or run tool in details.
-Or you can run it in [OpenAPI Hub](https://openapihub.azure-devex-tools.com/tools/diff).
 Refer to [Oad Docs](https://github.com/Azure/openapi-diff/tree/main/docs) for detailed description of all oad rules.
 
 ## `Swagger LintDiff` and `Swagger Lint(RPaaS)`
@@ -263,6 +264,25 @@ that the generated OpenAPI spec files were not in-sync with the TypeSpec project
 
 If none of the above helped, please reach out on [TypeSpec Discussions Teams channel].
 
+## APIView Failures: troubleshooting guides
+Various APIViews are generated as part of the Azure REST API specs PR build. Among these are TypeSpec and Swagger as well as any other language that is being generated in the run. When everything is successful you should see a comment box similar to the picture below showing the APIViews generated for TypeSpec or Swagger, plus all other languages being generated.
+
+![alt text](image-3.png)
+
+#### If an expected APIView was not generated, follow the step below to troubleshoot.
+
+- On the CI check click on `details` > `View Azure DevOps build log for more details` to view the devOps logs.
+- Investigate the CI job for the languge with error. TypeSpec and Swagger APIViews are generated as part of the `AzureRestApiSpecsPipeline` stage in the `TypeSpecAPIView` and `SwaggerAPIView` jobs respectively, while APIViews for other SDK languges are generated in their respective language jobs in the `SDK Automation` stage.
+- Ensure that all previous checks in the job are green before proceeding. 
+
+#### Diagnosing APIView failure for SDK Language (not Swagger or TypeSpec)
+1. Check for an unexpected skip of the `Publish SDK APIView Artifact to Pipeline Artifacts` and `Generate SDK APIView` step.
+2. Look in `SDK Automation` step to verify that the API token generation completed successfully.
+3. Search logs for `Read Temp File`
+4. Below `Read Temp File` find the .json object and search within to locate the `apiViewArtifact` property.
+5. If not present, the APIView parser for the language failed to generate the `APIView Token Artifacts`.
+6. Please contact [APIView Support Teams Channel] for assistance.
+
 ## Suppression Process
 
 In case there are validation errors reported against your service that you believe do not apply, we have a suppression process you can follow to permanently remove these reported errors for your specs. Refer to the [suppression guide](https://aka.ms/pr-suppressions) for detailed guidance.
@@ -286,3 +306,4 @@ Following checks have been removed from the validation toolchain as of August 20
 [aka.ms/azsdk/support/specreview-channel]: https://aka.ms/azsdk/support/specreview-channel
 [aka.ms/azsdk/support]: https://aka.ms/azsdk/support
 [TypeSpec Discussions Teams channel]: https://teams.microsoft.com/l/channel/19%3A906c1efbbec54dc8949ac736633e6bdf%40thread.skype/TypeSpec%20Discussion%20%F0%9F%90%AE?groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47
+[APIView Support Teams Channel]: https://teams.microsoft.com/l/channel/19%3A3adeba4aa1164f1c889e148b1b3e3ddd%40thread.skype/APIView?groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47

documentation/code-gen/configure-python-sdk.md

@@ -86,7 +86,7 @@ This is not used by Autorest itself.
 
 ``` yaml $(swagger-to-sdk)
 swagger-to-sdk:
-  - repo: azure-sdk-for-python-track2
+  - repo: azure-sdk-for-python
   - ...
 
 

documentation/samplefiles/readme.java.md

@@ -0,0 +1,7 @@
+## Java
+
+These settings apply only when `--java` is specified on the command line.
+
+``` yaml $(java)
+client-flattened-annotation-target: disabled
+```

documentation/samplefiles/samplereadme.md

@@ -49,7 +49,7 @@ This is not used by Autorest itself.
 
 ```yaml $(swagger-to-sdk)
 swagger-to-sdk:
-  - repo: azure-sdk-for-python-track2
+  - repo: azure-sdk-for-python
   - repo: azure-sdk-for-java
   - repo: azure-sdk-for-go
   - repo: azure-sdk-for-js
@@ -76,3 +76,7 @@ See configuration in [readme.typescript.md](./readme.typescript.md)
 ## CSharp
 
 See configuration in [readme.csharp.md](./readme.csharp.md)
+
+## Java
+
+See configuration in [readme.java.md](./readme.java.md)