Skip to content

Added GA API version for Scheduled Query Rule #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fearthecowboy merged 9 commits into from
Apr 24, 2018
Merged

Added GA API version for Scheduled Query Rule #2858

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2e4c790
Added GA API version for Scheduled Query Rule
abversqr Apr 12, 2018
d183bad
Resolving Comments
abversqr Apr 17, 2018
df40ac3
Made SKU as top level proprty and including generic error response fo…
abversqr Apr 18, 2018
7578160
Minor Changes to align implementation
abversqr Apr 23, 2018
c39fa0c
Updated Example to reflect AI instances in tags and 'dataSourceId"
abversqr Apr 23, 2018
5762ef5
made 'tags' details more descriptive
abversqr Apr 23, 2018
caabc1b
Restore Tags Description
abversqr Apr 23, 2018
ef75786
Fixed Exmaple Validation
abversqr Apr 24, 2018
fb180fb
Added Default Response payload in all APIs
abversqr Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added Default Response payload in all APIs 
Changes -
1. Added Default Response payload in all APIs
2. Made azNs description more clear
  • Loading branch information
@abversqr
abversqr committed Apr 24, 2018
commit fb180fb311d73934d0f5150f72638cc3de155ea0
20 changes: 19 additions & 1 deletion ...monitor/resource-manager/microsoft.insights/stable/2018-04-16/scheduledQueryRule_API.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,12 @@
}
],
"responses": {
Copy link
Contributor

@fearthecowboy fearthecowboy Apr 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should have a default response modeled here -- if the service fails for any reason, the client needs to be able to get the error response.

"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
},
"200": {
"description": "Successful request to delete a Log Search rule"
},
Expand Down Expand Up @@ -178,6 +184,12 @@
}
],
"responses": {
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
},
"200": {
"description": "Successful request for a list of alert rules",
"schema": {
Expand Down Expand Up @@ -216,6 +228,12 @@
}
],
"responses": {
"default": {
"description": "Error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
},
"200": {
"description": "Successful request for a list of alert rules",
"schema": {
Expand Down Expand Up @@ -376,7 +394,7 @@
"properties": {
"actionGroup": {
"type": "array",
"description": "azns notification group reference.",
"description": "Azure Group reference.",
"items": {
"type": "string"
}
Expand Down