-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Microsoft.DesktopVirtualization 2024-04-08-preview #29101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.DesktopVirtualization 2024-04-08-preview #29101
Conversation
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2024-04-03 to preview/2024-04-08-preview.
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.9) | new version | base version |
|---|---|---|
| desktopvirtualization.json | 2024-04-08-preview(1a7b4e5) | 2024-04-03(main) |
| desktopvirtualization.json | 2024-04-08-preview(1a7b4e5) | 2024-03-06-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 23 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 23 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 339 Warnings warning [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-preview-2024-04 | package-preview-2024-04(1a7b4e5) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 23 items are listed, please refer to log for more details.
The following errors/warnings exist before current PR submission:
Only 23 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
OperationsApiSchemaUsesCommonTypes |
Operations API path must follow the schema provided in the common types. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L50 |
PatchIdentityProperty |
The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L225 |
PutRequestResponseSchemeArm |
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateEndpointConnections_UpdateByWorkspace' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema' Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L386 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L386 |
PatchIdentityProperty |
The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L773 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:hour. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1041 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:minute. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1041 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:hour. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1307 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not be required, property:minute. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1307 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not have default value, property:rampUpStartVMOnConnect. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1307 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not have default value, property:peakStartVMOnConnect. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1307 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not have default value, property:rampDownStartVMOnConnect. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1307 |
PatchBodyParametersSchema |
Properties of a PATCH request body must not have default value, property:offPeakStartVMOnConnect. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1307 |
PatchIdentityProperty |
The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L1618 |
ConsistentPatchProperties |
The property 'tags' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L2007 |
ConsistentPatchProperties |
The property 'tags' in the request body either not apppear in the resource model or has the wrong level. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L2172 |
PatchIdentityProperty |
The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L2428 |
SubscriptionsAndResourceGroupCasing |
The path segment resourcegroups should be resourceGroups. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L3699 |
SubscriptionsAndResourceGroupCasing |
The path segment resourcegroups should be resourceGroups. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L3897 |
PutRequestResponseSchemeArm |
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'PrivateEndpointConnections_UpdateByHostPool' Request Model: 'parameters[5].schema' Response Model: 'responses[200].schema' Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L4858 |
PutResponseCodes |
Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L4858 |
XmsEnumValidation |
The enum types should have x-ms-enum type extension set with appropriate options. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L8948 |
| The patch operation body parameter schema should contain property 'sku'. Location: Microsoft.DesktopVirtualization/preview/2024-04-08-preview/desktopvirtualization.json#L225 |
️❌Avocado: 4 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.DesktopVirtualization/hostPools/{}/sessionHostManagements/default/operationStatuses/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/desktopvirtualization/resource-manager/readme.md json: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.DesktopVirtualization/hostPools/{}/sessionHostManagements/default/operationStatuses is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/desktopvirtualization/resource-manager/readme.md json: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.DesktopVirtualization/hostPools/{}/sessionHostConfigurations/default/operationStatuses/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/desktopvirtualization/resource-manager/readme.md json: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json |
MISSING_APIS_IN_DEFAULT_TAG |
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.DesktopVirtualization/hostPools/{}/sessionHostConfigurations/default/operationStatuses is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/desktopvirtualization/resource-manager/readme.md json: Microsoft.DesktopVirtualization/preview/2024-03-06-preview/desktopvirtualization.json |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
This is expected since it is a tracked resource |
we are mirroring Compute here, and there is only that much that we can do |
rkmanda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
/pr RequestMerge |
|
@almat-msft Although you requested to merge the PR, this cannot be done yet as there is one pending requested change which you have to close/address/etc. |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.