Skip to content

[new] Update Hibernate Public Docs to remove "Feature in Preview" #29112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rkmanda merged 8 commits into from
Jun 5, 2024
Merged

[new] Update Hibernate Public Docs to remove "Feature in Preview" #29112

rkmanda merged 8 commits into from
Jun 5, 2024

Conversation

@jaclin1111
Copy link
Contributor

@jaclin1111 jaclin1111 commented May 15, 2024

remove "feature in preview" for new hibernate feature in VM

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 15, 2024 •
edited
Loading

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 15, 2024 •
edited
Loading

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand] 
There are no breaking changes.
Compared specs (v0.10.9) new version base version
virtualMachine.json 2024-03-01(5484c14) 2024-03-01(main)
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2024-03-01 package-2024-03-01(5484c14) package-2024-03-01(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ GetCollectionResponseSchema The response in the GET collection operation 'VirtualMachineRunCommands_List' does not match the response definition in the individual GET operation 'VirtualMachineRunCommands_Get' .
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L36
❌ PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L112
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:secretUrl.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L144
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:sourceVault.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L144
❌ LroPatch202 The async patch operation should return 202.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L156
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L177
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L216
❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L245
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L306
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L344
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L457
❌ PatchResponseCodes Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L706
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:secretUrl.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L731
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:sourceVault.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L731
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:keyUrl.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L731
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:createOption.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L731
❌ LroPatch202 The async patch operation should return 202.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L759
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L783
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L822
❌ ParametersInPointGet Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L848
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L916
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L947
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L969
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L1001
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L1023
❌ ParametersInPost hibernate is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L1029
❌ LroLocationHeader A 202 response should include an Location response header.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L1062
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L1302
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L1324
❌ ParametersInPost skipShutdown is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: ComputeRP/stable/2024-03-01/virtualMachine.json#L1330
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/compute/resource-manager/readme.md
tag: specification/compute/resource-manager/readme.md#tag-package-2024-03-01
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 15, 2024 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️⚠️ azure-sdk-for-net-track2 warning [Detail]
  • ⚠️Warning in generating from f7de75b18ee084e2b4dfd794f8151097bbc82973. SDK Automation 14.0.0 
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
  • ️✔️Azure.ResourceManager.Compute [Preview SDK Changes] 
    info	[Changelog]
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from f7de75b18ee084e2b4dfd794f8151097bbc82973. SDK Automation 14.0.0 
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-compute [Preview SDK Changes]
    • azure-mgmt-compute-31.0.0.zip
    • azure_mgmt_compute-31.0.0-py3-none-any.whl
    info	[Changelog]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from f7de75b18ee084e2b4dfd794f8151097bbc82973. SDK Automation 14.0.0 
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-compute-generated [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-compute-generated-1.0.0-beta.1.jar
    • azure-resourcemanager-compute-generated-1.0.0-beta.1-sources.jar
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from f7de75b18ee084e2b4dfd794f8151097bbc82973. SDK Automation 14.0.0 
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Cannot generate changelog because the codes of local and npm may be the same.
  • ️✔️@azure/arm-compute [Preview SDK Changes]
    • azure-arm-compute-21.6.1.tgz
    info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from f7de75b18ee084e2b4dfd794f8151097bbc82973. SDK Automation 14.0.0 
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/compute/armcompute [Preview SDK Changes] 
    info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
️❌ azure-resource-manager-schemas failed [Detail]
  • ❌Code Generator Failed in generating from f7de75b18ee084e2b4dfd794f8151097bbc82973. Schema Automation 14.0.0 
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Skip package processing as generation is failed
error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from f7de75b18ee084e2b4dfd794f8151097bbc82973. SDK Automation 14.0.0 
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.compute.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented May 15, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/compute/armcompute Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java azure-resourcemanager-compute-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript @azure/arm-compute Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Swagger Microsoft.Compute Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

This was referenced May 15, 2024
Closed
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 15, 2024
This was referenced May 15, 2024
Closed
Closed
Closed
Closed
@razvanbadea-msft razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 24, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 24, 2024
@azure-sdk azure-sdk mentioned this pull request May 24, 2024
Closed
@jaclin1111
Copy link
Contributor Author

jaclin1111 commented Jun 4, 2024

/pr RequestMerge

@rkmanda rkmanda merged commit ceb3b7f into Azure:main Jun 5, 2024
Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024
@jaclin1111 @grizzlytheodore @Francisco-Gamino
Update virtualMachine.json (Azure#29112)
2c6d422 
remove "feature in preview"

Co-authored-by: Theodore Chang <[email protected]>
markcowl pushed a commit to markcowl/azure-rest-api-specs that referenced this pull request Jun 7, 2024
@jaclin1111 @grizzlytheodore @markcowl
Update virtualMachine.json (Azure#29112)
eb94607 
remove "feature in preview"

Co-authored-by: Theodore Chang <[email protected]>
markcowl pushed a commit that referenced this pull request Jun 7, 2024
@jaclin1111 @grizzlytheodore @markcowl
Update virtualMachine.json (#29112)
3a7392f 
remove "feature in preview"

Co-authored-by: Theodore Chang <[email protected]>
allenjzhang added a commit that referenced this pull request Jun 14, 2024
@allenjzhang @mikeharder
@timotheeguerin @Joanna-Yang-Art @Sherylueen @markcowl @msyyc @Alancere @weidongxu-microsoft @tadelesh @willmtemple @hsurana06 @zdelacerda-microsoft @raghumunukutla @ChenxiJiang333 @koyasu221b @jhendrixMSFT @mssfang @trrwilson @jpalvarezl @bexxx @shraddhasun @seanmcc-msft @tasherif-msft @triciarosario @jaclin1111 @grizzlytheodore @solankisamir @tomkerkhove @Mielek @m-h-s @vidishamsft @Francisco-Gamino @martinezdylan @kazrael2119 @priyjain358 @alzimmermsft @miaxzhitong @stevemunk @jimchou-dev
Update TypeSpec to latest 2024-06 release - 0.57 & 0.43 (#29440)
db63bea 
* Update package.json and scripts

* Add typespec-azure-portal-core

* Fix some deprecations from valueof PR (#29126)

* [apicenter] Regen swagger to add "title" properties

* [cognitiveservices] Use TypeSpec array (#[]) instead of tuple ([]) (#29213)

* fix

* Suppress failing rules

* Fix shouldn't have `Content-Type` header

* Pin typespec versioning to 0.57.0-dev.6

* Switch back to next tag for versioning library

* Add new networking code owner (#29281)

* Sherylueen appcomplianceautomation microsoft.app compliance automation 2024 06 27 (#28981)

* Adds base for updating Microsoft.AppComplianceAutomation from version preview/2022-11-16-preview to version 2024-06-27

* Updates readme

* Updates API version in new specs and examples

* add new stable version for Microsoft.AppComplianceAutomation

* remove the useless example file

* fix spell check

* remove query in get evidence api

* remove the singleton annotation

* fix compile error

* fix compile error of v56

* fix compile error

* fix all compile error and make the swagger align with before

* tsp prettier

* change scoping name

* upgrade the commontypes from v3 to v5

* change commonTypes version to v3

* add service-dir

* format tspconfig.yaml

* modify tspconfig.yaml

* remove custom operations

* modify re pattern of snapshot name

* make the resource x-ms-client-name properties

* format typespec

* remove suffix of snapshot

* use requestBody replace parameters

* Revert "use requestBody replace parameters"

This reverts commit e4dd975.

* tsp format

* remove dotnet from tspconfig.yaml and add azure-sdk-for-net-track2 in readme

* add sdk-suppressions.yaml

* Update tspconfig.yaml

* Update tspconfig.yaml

* rename operationid

* rename getScopingQuestions and move model reportBaseProperties to alias

---------

Co-authored-by: Yanwen Liu <[email protected]>
Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: Alancere <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>

* Microsoft.ScVmm TypeSpec onboarding (#26644)

* Init tsp for Microsoft.ScVmm

* Some changes towards passing tsv

* Updates to fix lint errors, remove unused types, regenerate examples, etc.

* Created shareable 'force' param

* Figured out the incantation to rename a file case-sensitively

* Restored string bool enums.

* Removed all examples

* Regenerate examples

* Updated ARM ID properties. Added script to sort output to compare with sorted old swagger

* Additional changes.

* Removed unused XXUpdate models, Added @secret for password,

* Fixed #8, #6, #5

* Fixed #2

* Update swagger to be in sync with previous fixes.

* Workaround for CloudCapacity readonly

* Additional fixes.

* fix ModelValidation

* update void

* VM Instance Update Properties changes

* spell check and prettier validation fix

* fix for identifier bug

* workaround for Azure/typespec-azure#449

* format

* spell and prettier check improvements

* use encodedName replace projectdName

* Add summary annotations

* summary

* update kind and void

* lro azure-async-operation

* fix

* tsp compilation warning

* TypeSpec Validation fix

* Update tspconfig.yaml

* config change

* Removed Read Only Property from Examples to fix Swagger ModelValidation

* Revert Boolean to Enum with type Union in TypeSpec

* specs-pr repo PR review changes to specs repo

* Remove sorted json file used for comparison

* Fix TypeSpec PR pipeline failure

* make extendedLocation for VM Instance read and create

* typespec validation fix

---------

Co-authored-by: Will Temple <[email protected]>
Co-authored-by: Allen Zhang <[email protected]>
Co-authored-by: Alancere <[email protected]>
Co-authored-by: Harshit Surana <[email protected]>

* Imagebuilder API Release 2024-02-01 (#28896)

* Copy files from stable/2023-07-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-02-01

Updated the API version from stable/2023-07-01 to stable/2024-02-01.

* Added tag for 2024-02-01 in readme file

* copying over 2024-02-01 changes from ADO

* Revert "copying over 2024-02-01 changes from ADO"

This reverts commit aa54d74.

* adding changes from ado

* adding autorun as custom word

* adding autorun to custom-words.txt

* fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error

* fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error

* changing type from string back to object

* changing type from string back to object

* Revert "changing type from string back to object"

This reverts commit b0b5122.

revert commit

* Revert "fixing UpdateImageTemplateVmProfile.json reference and additionalProperties error"

This reverts commit 0e52ddf.

* referencing examples file

* writing suppression for lintdiff

* removing userassignedidentity

* fixing bad version mismatch

* fixing suppression

* prettier changes

* fixing where syntax

* fixing where suppress 2

* where suppress 3

* where supress 4

* where suppress 5

* suppressing entire file

* Update readme.md to show up documentation for preview version (#29165)

* Update readme.python.md (#29309)

* Update readme.python.md

* Update readme.md

---------

Co-authored-by: Yuchao Yan <[email protected]>

* Update readme.md (#29313)

* Add info about `SDK azure-sdk-for-*` checks and `SDK azure-powershell` to `ci-fix` doc; Clean up markdownlint rules and `ci-fix` doc. (#29311)

* Update ci-fix.md: clarify that `SDK azure-powershell` is owned by `Azure.Core`. (#29318)

* Update ci-fix.md

* Update ci-fix.md

* Update ci-fix.md

* RouteMatrix 2024-06-01-preview (#29153)

* first commit

* fix

* Add operationType

* rename to pointType

* fix

* update

* Update example

* update

* update description for default value

* update description

* Remove axleCount for RouteMatrix

* Update vehicleSpec

* update description

* Update description

* remove async result

* Revert "remove async result"

This reverts commit b7b2728.

* Remove Summary

* follow azure's convention

* Remove Accept-Language for RouteMatrix

* Update retention period to 24 hours

* Add createdDateTime

* Add suppressions

* Update description

---------

Co-authored-by: Will Huang <[email protected]>
Co-authored-by: Joel Hendrix <[email protected]>

* [OAI-Assistant] Added Missing annotation and delete unnecessary  annotation (#29297)

* fixed the error

* npx tsp compile updates

---------

Co-authored-by: Travis Wilson <[email protected]>
Co-authored-by: Jose Alvarez <[email protected]>

* [OpenAI] [Inference] TSP definition updates for `v2024_05_01_preview` service release (#29182)

* Azure OpenAI: 2024-04-01-preview updates

* add audio formats

* post-merge fix incl. tool update for enum conversion to union

* minor: spellcheck fix

* refine duration encoding for word start/end

* enable serialization into azure json and rename customization class name

* Added new customBlockList filter and fields to OYD

* Adding changes to authentication for Vector Search

* Adjusted docs for OYD vector search auth models

* Added missing field and retrieved documents

* Examples added

* corrected examples api-versions in json

* Reformat

* Recompile after reformat

* PR comments: wrong plural and type precision

* Revert added tab to service spec

Co-authored-by: Shawn Fang <[email protected]>

* Added readme entry for generated openAPI doc

* Trying to improve folder structure

* Removed moved and renamed generated.json files

* Reverted last 3 commits

* Added entry for generated.json swagger in the readme

* Changed enum to nonExpandable

* Ran formatter

---------

Co-authored-by: Travis Wilson <[email protected]>
Co-authored-by: Travis Wilson <[email protected]>
Co-authored-by: Shawn Fang <[email protected]>
Co-authored-by: Shawn Fang <[email protected]>

* Add v3.2 for Speech to text (3.2p2 as base) (#28664)

* Add v3.2 for Speech to text (3.2p2 as base)

* Update swagger with new changes and updated version number

* Update readme.md with new version

* Added evaluation token errors

* Revert ttl changes for transcriptions

* Finalized api changes for GA

* Try fix avocado error

* Add new api-version 2024-02-01-preview to main (#29105)

* Add 2024-02-01-preview to main

* fix typespec errors

* remove operations.json

* fix linters

* delete unusued file

* edit readme

* remove suppressions

* Update specification/azurestackhci/Operations.Management/tspconfig.yaml

Co-authored-by: Mike Harder <[email protected]>

* Update specification/azurestackhci/AzureStackHCI.StackHCIVM.Management/tspconfig.yaml

Co-authored-by: Mike Harder <[email protected]>

* ID to id

* remove unnecessary suppress

* fix examples

* copy private folder changes

---------

Co-authored-by: Mike Harder <[email protected]>

* Storage STG 94 (#28327)

* added swagger (#28199)

* [STG94] Updated STG94 Files Readme (#28201)

* added swagger

* updated readme

* small fix

* added new blob swagger (#28245)

* added blob readme (#28246)

* Ran prettier on the 2024-08-04 files swagger file (#28358)

* Added AuthenticationErrorDetail to StorageError (#28360)

* NFS Share Snapshot (#28362)

* Added GetAccountInfo() API to Container and Blob level (#28297)

* Storage Error Codes for Copies (#28359)

* Revert "Storage Error Codes for Copies (#28359)"

This reverts commit 8b14ba4.

---------

Co-authored-by: Tamer Sherif <[email protected]>

* Storage Task Assignment Swagger Updates (#29050)

* SDK team improvements

* Report APIs contain filtering

* PR comment add more examples

* Fix example path

* Fix duplicate schema issue

---------

Co-authored-by: Tricia Rosario <[email protected]>

* Update virtualMachine.json (#29112)

remove "feature in preview"

Co-authored-by: Theodore Chang <[email protected]>

* Merge release api management 2023 09 01 preview - Active (#29184)

* Adds base for updating Microsoft.ApiManagement from version preview/2023-05-01-preview to version 2023-09-01-preview

* Updates readme

* Updates API version in new specs and examples

* feat(apim): Introduce gateway resource (#27757)

* WIP

* Update sample

* WIP

* Add GatewayNameParameter

* Clean up

* Update sample

* Add another sample

* Add sample for delete gateway

* Remove endpoints

* Fix typo

* Add list sample

* Clean up

Signed-off-by: Tom Kerkhove <[email protected]>

* Add disclaimer

Signed-off-by: Tom Kerkhove <[email protected]>

* Make it pretty 💄

Signed-off-by: Tom Kerkhove <[email protected]>

* Refer to new file

Signed-off-by: Tom Kerkhove <[email protected]>

* Add missing ApiManagementGatewayListResult

Signed-off-by: Tom Kerkhove <[email protected]>

* Update sample reference

Signed-off-by: Tom Kerkhove <[email protected]>

* Remove ApiManagementGatewayIdentity + List by operation

Signed-off-by: Tom Kerkhove <[email protected]>

* Add more sample

Signed-off-by: Tom Kerkhove <[email protected]>

* Latest version of common types

Signed-off-by: Tom Kerkhove <[email protected]>

* Remove 200 for delete

Signed-off-by: Tom Kerkhove <[email protected]>

* Formatting and re-order

Signed-off-by: Tom Kerkhove <[email protected]>

* Align with spec

Signed-off-by: Tom Kerkhove <[email protected]>

* Align sample with spec

Signed-off-by: Tom Kerkhove <[email protected]>

* Error response from common types

Signed-off-by: Tom Kerkhove <[email protected]>

* Rename SKU name

* Have seperate SKU for patch to not make it mandatory

* Remove empty required

* Improve note

* Rename schema

* Remove unused type

* sku.capacity should not be required

---------

Signed-off-by: Tom Kerkhove <[email protected]>

* Add loggers, diagnostics, certificates and backends to workspace (#27262)

* Add loggers to workspaces

* Add diagnostics to workspace

* Add certificates to workspace

* Add backends to workspaces

* Change DiagnosticContract to DiagnosticContractProperties in patch

* Revert back DiagnosticContractProperties to DiagnosticContract

* Fix CI and add files to readme

* Fix example

* remove reconnect endpoint

* Add suppressions

* Try different suppression where

* Try different suppression

* Try other suppression

* another test

* finally working suppression

* remove unwanted line

* remove secret examples (#28409)

* Modify CircuitBreaker and BackendPool Contract (#28397)

* md cb contract

* modify pool contract

* correct the limits

---------

Co-authored-by: Samir Solanki <[email protected]>

* Common Error Response (#28408)

* add operation statuses resource (#28591)

* add operation statuses resource

* fix api-version

* Add locations/operationsResults endpoint for DELETE workflow (#28808)

* add operation results

* fix spec

* operationresults

* fix file name

* feat(Workspace): Add new SkuType for Workspace (#28903)

* new skutype

* virtualNetworkType

* remove default from patch

* List skus API

* add model for sku

* caps enums

* feat)Gateway): Adding gateway config resource (#28478)

* added gateway config resource

* removing Head gateway Config call

* updates

* resolving errors

* trying to resolve more model validations

* resolving some model validations

* resolving model validations

* resoloving delete example errors

* Swagger Prettier

* prettier

* updating so patch has same response as get and put

* removing path for gateway config

* addressing comment

* addressing comments

* nit

* path updatess

* updating as per comments

* Adding workspaceLinks

* resolving some of the errors

* resolved some errors

* resolving some of the errors

* resolving some more errors

* npx prettier

* addressing comments

* updated based on comments

* lint updates

* nit updates

---------

Co-authored-by: Samir Solanki <[email protected]>

* Fix generation errors (#29207)

* fix(apim): Remove duplicate ErrorResponse schema due to move to common schema

* Gateway -> ApiGateway to prevent SDK collision with self-hosted gateway

* Revert "Gateway -> ApiGateway to prevent SDK collision with self-hosted gateway"

This reverts commit 8d4753d.

* Remove ApiManagement Prefix for GatewayConfigConnections

* Revert "Remove ApiManagement Prefix for GatewayConfigConnections"

This reverts commit 3e8197f.

* Gateway -> ApiGateway to prevent SDK collision with self-hosted gateway

* Create sdk-suppressions.yaml

---------

Signed-off-by: Tom Kerkhove <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]>
Co-authored-by: Rafał Mielowski <[email protected]>
Co-authored-by: Mahsa Sadi <[email protected]>
Co-authored-by: Vidisha Shah <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>

* Fixed typo in documentation (#29341)

* Update 2023-12-01 Microsoft.Web functionAppConfig definition (#29226)

* Rename enum to functionsDeploymentStorageType

* Update enum name to camel case

* Update enum names to camel case

* Update `securityPostureReference` in VMScaleSet API (#28891)

* update securityPostureRef properties in VMScaleSet spec

* add securityPostureReference to UpdateVMProfile definition and fix min version

* add prettier changes

* remove unsupported 'major.*' from spec

* add optional fields in security posture example

* add required fields

* correct minimum api version

* add prettier fixes

* remove extensionsSettings property

* create new Update model for security posture reference & update

* fix validation issue

* Create sdk-suppressions.yaml

* add azure-sdk-for-go suppression

* Update sdk-suppressions.yaml

---------

Co-authored-by: Dylan Martinez <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: Alancere <[email protected]>
Co-authored-by: kazrael2119 <[email protected]>

* [Microsoft.AzureStackHCI] Add 2024-04-01 for StackHCI (#29110)

* Add 2024-04-01 for StackHCI

* add missing properties

* add log collection job type

* changes in sdk suppressions

* sdk suppression changes

* Enable stream-stype serialization for Java Communication Job Router (#29328)

* Azure Map Rendering 20240401 (#27950)

* Adds base for updating Render from version stable/2022-08-01 to version 2024-04-01

* Updates readme

* Updates API version in new specs and examples

* update static map API doc

* small change on static map doc

* update tilesetId section

* add static map supported tilesetid and trafficLayer

* update range table and static image example

* fix typo

* add additional static image example

* error fix

* run prettier on static image example json

* set tilesetId as optional

* update max/min latitude/longitude table

* update Accept header for static image API

* error fix

* add explanation for Accept header

* typo

* add parameter limitation

* improve wording

* add path and pin parameter type

* fix tables

* improve on example

* typo fix

* run prettier

* wording fix

* map attribution description update

Co-authored-by: steve munk <[email protected]>

* state tile description update

Co-authored-by: steve munk <[email protected]>

* map tile description update

Co-authored-by: steve munk <[email protected]>

* map tileset description update

Co-authored-by: steve munk <[email protected]>

* map copyright caption description change

Co-authored-by: steve munk <[email protected]>

* map copyright bounding description update

Co-authored-by: steve munk <[email protected]>

* weather radar tile description update

Co-authored-by: steve munk <[email protected]>

* weather infrared tiles description update

Co-authored-by: steve munk <[email protected]>

* map copyright tile description update

Co-authored-by: steve munk <[email protected]>

* map copyright world description update

Co-authored-by: steve munk <[email protected]>

* remove pricing tiers applies

* Adds base for updating Render from version stable/2022-08-01 to version 2024-04-01

* Updates readme

* Updates API version in new specs and examples

* update static map API doc

* small change on static map doc

* update tilesetId section

* add static map supported tilesetid and trafficLayer

* update range table and static image example

* fix typo

* add additional static image example

* error fix

* run prettier on static image example json

* set tilesetId as optional

* update max/min latitude/longitude table

* update Accept header for static image API

* error fix

* add explanation for Accept header

* typo

* add parameter limitation

* improve wording

* add path and pin parameter type

* fix tables

* improve on example

* typo fix

* run prettier

* wording fix

* map attribution description update

Co-authored-by: steve munk <[email protected]>

* state tile description update

Co-authored-by: steve munk <[email protected]>

* map tile description update

Co-authored-by: steve munk <[email protected]>

* map tileset description update

Co-authored-by: steve munk <[email protected]>

* map copyright caption description change

Co-authored-by: steve munk <[email protected]>

* map copyright bounding description update

Co-authored-by: steve munk <[email protected]>

* weather radar tile description update

Co-authored-by: steve munk <[email protected]>

* weather infrared tiles description update

Co-authored-by: steve munk <[email protected]>

* map copyright tile description update

Co-authored-by: steve munk <[email protected]>

* map copyright world description update

Co-authored-by: steve munk <[email protected]>

* remove pricing tiers applies

* reduce get copyright example length

* add summary for render 20240401

* remove summary from static image

* remove please from language and view

* add package-2024-04-01 to readme

* revert back common change

* revert changes in maps readme

* \n fix

Co-authored-by: steve munk <[email protected]>

* typo fix

Co-authored-by: steve munk <[email protected]>

* typo fix for map copyright caption

Co-authored-by: steve munk <[email protected]>

* typo fix for statetile

Co-authored-by: steve munk <[email protected]>

* typo fix for map copyright world

Co-authored-by: steve munk <[email protected]>

---------

Co-authored-by: steve munk <[email protected]>
Co-authored-by: Joel Hendrix <[email protected]>

* Update directory-structure.md: clarify service, service group, uniform versioning. (#28929)

* [ACS][Communication][Chat] 2024-06-05-preview public preview API spec (#28875)

* Update for autorest lro support

* Format

* Fix issues with oracle spec from main

* Update format

* Update for latest dev version

* Fixing typespec-next for June 2024 release (#29427)

* green typespec-next

* Fix DeviceRegistry

* upgrade monitor to v4. Taking arm-id and subId uuid SDK breaking change. This should get rid of ModelValidation error

* Update package.json

---------

Signed-off-by: Tom Kerkhove <[email protected]>
Co-authored-by: Mike Harder <[email protected]>
Co-authored-by: Timothee Guerin <[email protected]>
Co-authored-by: Timothee Guerin <[email protected]>
Co-authored-by: Joanna-Yang-Art <[email protected]>
Co-authored-by: Sherylueen <[email protected]>
Co-authored-by: Yanwen Liu <[email protected]>
Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: Alancere <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
Co-authored-by: Will Temple <[email protected]>
Co-authored-by: Harshit Surana <[email protected]>
Co-authored-by: zdelacerda-microsoft <[email protected]>
Co-authored-by: raghumunukutla <[email protected]>
Co-authored-by: ChenxiJiang333 <[email protected]>
Co-authored-by: Konrad Jamrozik <[email protected]>
Co-authored-by: will <[email protected]>
Co-authored-by: Will Huang <[email protected]>
Co-authored-by: Joel Hendrix <[email protected]>
Co-authored-by: Shawn Fang <[email protected]>
Co-authored-by: Travis Wilson <[email protected]>
Co-authored-by: Jose Alvarez <[email protected]>
Co-authored-by: Travis Wilson <[email protected]>
Co-authored-by: Shawn Fang <[email protected]>
Co-authored-by: Ralf Beckers <[email protected]>
Co-authored-by: shraddhasun <[email protected]>
Co-authored-by: Sean McCullough <[email protected]>
Co-authored-by: Tamer Sherif <[email protected]>
Co-authored-by: Tricia Rosario <[email protected]>
Co-authored-by: Tricia Rosario <[email protected]>
Co-authored-by: jaclin1111 <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: Samir Solanki <[email protected]>
Co-authored-by: Tom Kerkhove <[email protected]>
Co-authored-by: Rafał Mielowski <[email protected]>
Co-authored-by: Mahsa Sadi <[email protected]>
Co-authored-by: Vidisha Shah <[email protected]>
Co-authored-by: Francisco Gamino <[email protected]>
Co-authored-by: Dylan Martinez <[email protected]>
Co-authored-by: Dylan Martinez <[email protected]>
Co-authored-by: kazrael2119 <[email protected]>
Co-authored-by: Priyanshi Jain <[email protected]>
Co-authored-by: Alan Zimmer <[email protected]>
Co-authored-by: miaxzhitong <[email protected]>
Co-authored-by: steve munk <[email protected]>
Co-authored-by: Jim Chou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkmanda rkmanda rkmanda approved these changes

@Sandido Sandido Awaiting requested review from Sandido

@dkulkarni-ms dkulkarni-ms Awaiting requested review from dkulkarni-ms

@haagha haagha Awaiting requested review from haagha haagha is a code owner

@MS-syh2qs MS-syh2qs Awaiting requested review from MS-syh2qs

+1 more reviewer

@grizzlytheodore grizzlytheodore grizzlytheodore approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jaclin1111 @grizzlytheodore @rkmanda @AzureRestAPISpecReview @razvanbadea-msft