Skip to content

Finalize the operationIds for SignalR Service #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsgouda merged 1 commit into from
Apr 23, 2018
Merged

Finalize the operationIds for SignalR Service #2925

dsgouda merged 1 commit into from
Apr 23, 2018

Conversation

@juniwang
Copy link
Member

@juniwang juniwang commented Apr 23, 2018 •
edited by azuresdkci
Loading

changes:

  • After many discussions, we finally decided to use SignalR as prefix of operation Id and schemas across all SDKs.

Tests:

  • autoreset with --azure-validator passed
  • oav validate-example and oav validate-spec passed
  • succeeds to use autotest to generate python/.NET sdk

@AutorestCI
Copy link

AutorestCI commented Apr 23, 2018 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Apr 23, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Apr 23, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2413

@AutorestCI AutorestCI mentioned this pull request Apr 23, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Apr 23, 2018 •
edited
Loading

Automation for azure-libraries-for-java

The initial PR has been merged into your service PR:
AutorestCI/azure-libraries-for-java#84

@azuresdkci azuresdkci requested a review from dsgouda April 23, 2018 02:48
@AutorestCI
Copy link

AutorestCI commented Apr 23, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkciprbot
Copy link

azuresdkciprbot commented Apr 23, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/signalr/resource-manager/readme.md

⚠️0 new Warnings.(0 total)
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

azuresdkciprbot commented Apr 23, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/signalr/resource-manager/readme.md

⚠️0 new Warnings.(1 total)
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

dsgouda
dsgouda approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit b514567 into Azure:master Apr 23, 2018
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@StanleyOverton
Update deviceupdate.json (#2925)
f25ece5 
Allowing a single dash in the middle of an Account and Instance name. 
No dash is allowed at the beginning or end of the Account or Instance name.
No double dash is allowed in the middle of the Account and Instance name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dsgouda dsgouda

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@juniwang @AutorestCI @azuresdkciprbot @dsgouda