Skip to content

Conversation

@rohinisharma
Copy link
Contributor

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    Need to update the instance info APIs to surface the physical zone property. This is part of the AZ overhaul effort app service is working on.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@rohinisharma rohinisharma requested a review from naveedaz as a code owner June 5, 2024 00:37
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 5, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 5, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
Compared specs (v0.10.9) new version base version
WebApps.json 2024-04-01(a43a7d1) 2023-12-01(main)
️🔄LintDiff inProgress [Detail]
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 5, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Pipeline Framework Failed in generating from 9fa026c1657f3f7bb3fbf29bbdcddd56d5e0e76e. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to build sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to packe sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
    cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact
    To https://github.com/azure-sdk/azure-sdk-for-net!	refs/heads/main:refs/heads/main	[remote rejected] (protected branch hook declined)DonePushing to https://github.com/azure-sdk/azure-sdk-for-netPOST git-receive-pack (9255 bytes)remote: error: GH006: Protected branch update failed for refs/heads/main.        remote: error: Cannot force-push to this branch        error: failed to push some refs to 'https://github.com/azure-sdk/azure-sdk-for-net'
  • Azure.ResourceManager.AppServiceBreaking Change Detected
    error	Fatal error: To https://github.com/azure-sdk/azure-sdk-for-net!	refs/heads/main:refs/heads/main	[remote rejected] (protected branch hook declined)DonePushing to https://github.com/azure-sdk/azure-sdk-for-netPOST git-receive-pack (9255 bytes)remote: error: GH006: Protected branch update failed for refs/heads/main.        remote: error: Cannot force-push to this branch        error: failed to push some refs to 'https://github.com/azure-sdk/azure-sdk-for-net'
    error	Fatal error: Error: To https://github.com/azure-sdk/azure-sdk-for-net!	refs/heads/main:refs/heads/main	[remote rejected] (protected branch hook declined)DonePushing to https://github.com/azure-sdk/azure-sdk-for-netPOST git-receive-pack (9255 bytes)remote: error: GH006: Protected branch update failed for refs/heads/main.        remote: error: Cannot force-push to this branch        error: failed to push some refs to 'https://github.com/azure-sdk/azure-sdk-for-net'    at Object.action (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1445:25)    at PluginStore.exec (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1494:29)    at /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1921:43    at new Promise (<anonymous>)    at GitExecutorChain.handleTaskData (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1919:16)    at GitExecutorChain.<anonymous> (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:1903:44)    at Generator.next (<anonymous>)    at fulfilled (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected]/node_modules/simple-git/dist/cjs/index.js:52:24)    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    error	The following packages are still pending:
    error		Azure.ResourceManager.AppService
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️🔄 azure-sdk-for-python inProgress [Detail]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 9fa026c1657f3f7bb3fbf29bbdcddd56d5e0e76e. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-appservice-generated [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-appservice-generated-1.0.0-beta.1-sources.jar
    • azure-resourcemanager-appservice-generated-1.0.0-beta.1.jar
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 9fa026c1657f3f7bb3fbf29bbdcddd56d5e0e76e. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/appservice/armappservice [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Function `*EnvironmentsClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *EnvironmentsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *EnvironmentsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
    info	[Changelog] - Function `*StaticSitesClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *StaticSitesClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *StaticSitesClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
    info	[Changelog] - Function `*WebAppsClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
    info	[Changelog] - Function `*WebAppsClient.BeginApproveOrRejectPrivateEndpointConnectionSlot` parameter(s) have been changed from `(context.Context, string, string, string, string, PrivateLinkConnectionApprovalRequestResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionSlotOptions)` to `(context.Context, string, string, string, string, RemotePrivateEndpointConnectionARMResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionSlotOptions)`
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `SKUNameFlexConsumption` added to enum type `SKUName`
    info	[Changelog] - New value `SiteLoadBalancingLeastRequestsWithTieBreaker` added to enum type `SiteLoadBalancing`
    info	[Changelog] - New value `SupportedTLSVersionsOne3` added to enum type `SupportedTLSVersions`
    info	[Changelog] - New enum type `AuthType` with values `AuthTypeAnonymous`, `AuthTypeSystemIdentity`, `AuthTypeUserAssigned`, `AuthTypeUserCredentials`
    info	[Changelog] - New enum type `AuthenticationType` with values `AuthenticationTypeStorageAccountConnectionString`, `AuthenticationTypeSystemAssignedIdentity`, `AuthenticationTypeUserAssignedIdentity`
    info	[Changelog] - New enum type `AzureStorageProtocol` with values `AzureStorageProtocolHTTP`, `AzureStorageProtocolNfs`, `AzureStorageProtocolSmb`
    info	[Changelog] - New enum type `FunctionsDeploymentStorageType` with values `FunctionsDeploymentStorageTypeBlobContainer`
    info	[Changelog] - New enum type `RuntimeName` with values `RuntimeNameCustom`, `RuntimeNameDotnetIsolated`, `RuntimeNameJava`, `RuntimeNameNode`, `RuntimeNamePowershell`, `RuntimeNamePython`
    info	[Changelog] - New function `*WebAppsClient.CreateOrUpdateSiteContainer(context.Context, string, string, string, SiteContainer, *WebAppsClientCreateOrUpdateSiteContainerOptions) (WebAppsClientCreateOrUpdateSiteContainerResponse, error)`
    info	[Changelog] - New function `*WebAppsClient.CreateOrUpdateSiteContainerSlot(context.Context, string, string, string, string, SiteContainer, *WebAppsClientCreateOrUpdateSiteContainerSlotOptions) (WebAppsClientCreateOrUpdateSiteContainerSlotResponse, error)`
    info	[Changelog] - New function `*WebAppsClient.DeleteSiteContainer(context.Context, string, string, string, *WebAppsClientDeleteSiteContainerOptions) (WebAppsClientDeleteSiteContainerResponse, error)`
    info	[Changelog] - New function `*WebAppsClient.DeleteSiteContainerSlot(context.Context, string, string, string, string, *WebAppsClientDeleteSiteContainerSlotOptions) (WebAppsClientDeleteSiteContainerSlotResponse, error)`
    info	[Changelog] - New function `*WebAppsClient.GetSiteContainer(context.Context, string, string, string, *WebAppsClientGetSiteContainerOptions) (WebAppsClientGetSiteContainerResponse, error)`
    info	[Changelog] - New function `*WebAppsClient.GetSiteContainerSlot(context.Context, string, string, string, string, *WebAppsClientGetSiteContainerSlotOptions) (WebAppsClientGetSiteContainerSlotResponse, error)`
    info	[Changelog] - New function `*WebAppsClient.NewListSiteContainersPager(string, string, *WebAppsClientListSiteContainersOptions) *runtime.Pager[WebAppsClientListSiteContainersResponse]`
    info	[Changelog] - New function `*WebAppsClient.NewListSiteContainersSlotPager(string, string, string, *WebAppsClientListSiteContainersSlotOptions) *runtime.Pager[WebAppsClientListSiteContainersSlotResponse]`
    info	[Changelog] - New struct `EnvironmentVariable`
    info	[Changelog] - New struct `FunctionAppConfig`
    info	[Changelog] - New struct `FunctionsAlwaysReadyConfig`
    info	[Changelog] - New struct `FunctionsDeployment`
    info	[Changelog] - New struct `FunctionsDeploymentStorage`
    info	[Changelog] - New struct `FunctionsDeploymentStorageAuthentication`
    info	[Changelog] - New struct `FunctionsRuntime`
    info	[Changelog] - New struct `FunctionsScaleAndConcurrency`
    info	[Changelog] - New struct `FunctionsScaleAndConcurrencyTriggers`
    info	[Changelog] - New struct `FunctionsScaleAndConcurrencyTriggersHTTP`
    info	[Changelog] - New struct `SiteContainer`
    info	[Changelog] - New struct `SiteContainerCollection`
    info	[Changelog] - New struct `SiteContainerProperties`
    info	[Changelog] - New struct `SiteDNSConfig`
    info	[Changelog] - New struct `VolumeMount`
    info	[Changelog] - New field `Protocol` in struct `AzureStorageInfoValue`
    info	[Changelog] - New field `DNSConfiguration` in struct `SitePatchResourceProperties`
    info	[Changelog] - New field `DNSConfiguration`, `FunctionAppConfig`, `SKU`, `VnetBackupRestoreEnabled` in struct `SiteProperties`
    info	[Changelog] - New field `PhysicalZone` in struct `WebSiteInstanceStatusProperties`
    info	[Changelog]
    info	[Changelog] Total 4 breaking change(s), 67 additive change(s).
    Present SDK breaking changes suppressions
    Function `*EnvironmentsClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *EnvironmentsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *EnvironmentsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
    Function `*StaticSitesClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *StaticSitesClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *StaticSitesClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
    Function `*WebAppsClient.BeginApproveOrRejectPrivateEndpointConnectionSlot` parameter(s) have been changed from `(context.Context, string, string, string, string, PrivateLinkConnectionApprovalRequestResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionSlotOptions)` to `(context.Context, string, string, string, string, RemotePrivateEndpointConnectionARMResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionSlotOptions)`
    Function `*WebAppsClient.BeginApproveOrRejectPrivateEndpointConnection` parameter(s) have been changed from `(context.Context, string, string, string, PrivateLinkConnectionApprovalRequestResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)` to `(context.Context, string, string, string, RemotePrivateEndpointConnectionARMResource, *WebAppsClientBeginApproveOrRejectPrivateEndpointConnectionOptions)`
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 9fa026c1657f3f7bb3fbf29bbdcddd56d5e0e76e. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-appservice [Preview SDK Changes] Breaking Change Detected
    • azure-arm-appservice-15.0.0.tgz
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added operation WebApps.createOrUpdateSiteContainer
    info	[Changelog]   - Added operation WebApps.createOrUpdateSiteContainerSlot
    info	[Changelog]   - Added operation WebApps.deleteSiteContainer
    info	[Changelog]   - Added operation WebApps.deleteSiteContainerSlot
    info	[Changelog]   - Added operation WebApps.getSiteContainer
    info	[Changelog]   - Added operation WebApps.getSiteContainerSlot
    info	[Changelog]   - Added operation WebApps.listSiteContainers
    info	[Changelog]   - Added operation WebApps.listSiteContainersSlot
    info	[Changelog]   - Added Interface EnvironmentVariable
    info	[Changelog]   - Added Interface FunctionAppConfig
    info	[Changelog]   - Added Interface FunctionsAlwaysReadyConfig
    info	[Changelog]   - Added Interface FunctionsDeployment
    info	[Changelog]   - Added Interface FunctionsDeploymentStorage
    info	[Changelog]   - Added Interface FunctionsDeploymentStorageAuthentication
    info	[Changelog]   - Added Interface FunctionsRuntime
    info	[Changelog]   - Added Interface FunctionsScaleAndConcurrency
    info	[Changelog]   - Added Interface FunctionsScaleAndConcurrencyTriggers
    info	[Changelog]   - Added Interface FunctionsScaleAndConcurrencyTriggersHttp
    info	[Changelog]   - Added Interface SiteContainer
    info	[Changelog]   - Added Interface SiteContainerCollection
    info	[Changelog]   - Added Interface SiteDnsConfig
    info	[Changelog]   - Added Interface VolumeMount
    info	[Changelog]   - Added Interface WebAppsCreateOrUpdateSiteContainerOptionalParams
    info	[Changelog]   - Added Interface WebAppsCreateOrUpdateSiteContainerSlotOptionalParams
    info	[Changelog]   - Added Interface WebAppsDeleteSiteContainerOptionalParams
    info	[Changelog]   - Added Interface WebAppsDeleteSiteContainerSlotOptionalParams
    info	[Changelog]   - Added Interface WebAppsGetSiteContainerOptionalParams
    info	[Changelog]   - Added Interface WebAppsGetSiteContainerSlotOptionalParams
    info	[Changelog]   - Added Interface WebAppsListSiteContainersNextOptionalParams
    info	[Changelog]   - Added Interface WebAppsListSiteContainersOptionalParams
    info	[Changelog]   - Added Interface WebAppsListSiteContainersSlotNextOptionalParams
    info	[Changelog]   - Added Interface WebAppsListSiteContainersSlotOptionalParams
    info	[Changelog]   - Added Type Alias AuthenticationType
    info	[Changelog]   - Added Type Alias AuthType
    info	[Changelog]   - Added Type Alias AzureStorageProtocol
    info	[Changelog]   - Added Type Alias FunctionsDeploymentStorageType
    info	[Changelog]   - Added Type Alias RuntimeName
    info	[Changelog]   - Added Type Alias WebAppsCreateOrUpdateSiteContainerResponse
    info	[Changelog]   - Added Type Alias WebAppsCreateOrUpdateSiteContainerSlotResponse
    info	[Changelog]   - Added Type Alias WebAppsGetSiteContainerResponse
    info	[Changelog]   - Added Type Alias WebAppsGetSiteContainerSlotResponse
    info	[Changelog]   - Added Type Alias WebAppsListSiteContainersNextResponse
    info	[Changelog]   - Added Type Alias WebAppsListSiteContainersResponse
    info	[Changelog]   - Added Type Alias WebAppsListSiteContainersSlotNextResponse
    info	[Changelog]   - Added Type Alias WebAppsListSiteContainersSlotResponse
    info	[Changelog]   - Interface AzureStorageInfoValue has a new optional parameter protocol
    info	[Changelog]   - Interface Site has a new optional parameter dnsConfiguration
    info	[Changelog]   - Interface Site has a new optional parameter functionAppConfig
    info	[Changelog]   - Interface Site has a new optional parameter sku
    info	[Changelog]   - Interface Site has a new optional parameter vnetBackupRestoreEnabled
    info	[Changelog]   - Interface SitePatchResource has a new optional parameter dnsConfiguration
    info	[Changelog]   - Interface WebSiteInstanceStatus has a new optional parameter physicalZone
    info	[Changelog]   - Added Enum KnownAuthenticationType
    info	[Changelog]   - Added Enum KnownAzureStorageProtocol
    info	[Changelog]   - Added Enum KnownFunctionsDeploymentStorageType
    info	[Changelog]   - Added Enum KnownRuntimeName
    info	[Changelog]   - Enum KnownSkuName has a new value FlexConsumption
    info	[Changelog]   - Enum KnownSupportedTlsVersions has a new value One3
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Operation AppServiceEnvironments.beginApproveOrRejectPrivateEndpointConnection has a new signature
    info	[Changelog]   - Operation AppServiceEnvironments.beginApproveOrRejectPrivateEndpointConnectionAndWait has a new signature
    info	[Changelog]   - Operation StaticSites.beginApproveOrRejectPrivateEndpointConnection has a new signature
    info	[Changelog]   - Operation StaticSites.beginApproveOrRejectPrivateEndpointConnectionAndWait has a new signature
    info	[Changelog]   - Operation WebApps.beginApproveOrRejectPrivateEndpointConnection has a new signature
    info	[Changelog]   - Operation WebApps.beginApproveOrRejectPrivateEndpointConnectionAndWait has a new signature
    info	[Changelog]   - Operation WebApps.beginApproveOrRejectPrivateEndpointConnectionSlot has a new signature
    info	[Changelog]   - Operation WebApps.beginApproveOrRejectPrivateEndpointConnectionSlotAndWait has a new signature
    Present SDK breaking changes suppressions
    Operation AppServiceEnvironments.beginApproveOrRejectPrivateEndpointConnection has a new signature
    Operation AppServiceEnvironments.beginApproveOrRejectPrivateEndpointConnectionAndWait has a new signature
    Operation StaticSites.beginApproveOrRejectPrivateEndpointConnection has a new signature
    Operation StaticSites.beginApproveOrRejectPrivateEndpointConnectionAndWait has a new signature
    Operation WebApps.beginApproveOrRejectPrivateEndpointConnection has a new signature
    Operation WebApps.beginApproveOrRejectPrivateEndpointConnectionAndWait has a new signature
    Operation WebApps.beginApproveOrRejectPrivateEndpointConnectionSlot has a new signature
    Operation WebApps.beginApproveOrRejectPrivateEndpointConnectionSlotAndWait has a new signature
    Please refer to https://aka.ms/azsdk/sdk-suppression for more information.
️❌ azure-resource-manager-schemas failed [Detail]
  • Code Generator Failed in generating from 9fa026c1657f3f7bb3fbf29bbdcddd56d5e0e76e. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Skip package processing as generation is failed
    error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.
️⚠️ azure-powershell warning [Detail]
  • ⚠️Warning in generating from 9fa026c1657f3f7bb3fbf29bbdcddd56d5e0e76e. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ⚠️Az.web.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 5, 2024

@rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 9, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 9, 2024
@naveedaz naveedaz merged commit 596cda7 into Azure:release-web-2024-04-01 Jun 11, 2024
@naveedaz naveedaz mentioned this pull request Sep 9, 2024
8 tasks
naveedaz added a commit that referenced this pull request Sep 26, 2024
* Release web 2024 04 01 (#28952)

* Copy files from stable/2023-12-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-04-01

Updated the API version from stable/2023-12-01 to stable/2024-04-01.

* Added tag for 2024-04-01 in readme file

* Copy files from stable/2023-12-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-04-01

Updated the API version from stable/2023-12-01 to stable/2024-04-01.

* Added tag for 2024-04-01 in readme file

* Copy files from stable/2023-12-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-04-01

Updated the API version from stable/2023-12-01 to stable/2024-04-01.

* Added tag for 2024-04-01 in readme file

* Fix RP merge issue

* Fix prettier failute

* Fix spellcheck for sitecontainers

* Fix prettier check failures

* Fix ALL prettier check failures

* Add LeastRequestsWithTieBreaker (#29128)

* Add LeastRequestsWithTieBreaker

* Change to target 2024-04-01

---------

Co-authored-by: Chris Rosenblatt <[email protected]>

* Update 2023-12-01 Microsoft.Web functionAppConfig definition (#29226) (#29350)

* Update 2023-12-01 Microsoft.Web functionAppConfig definition (#29226)

* Rename enum to functionsDeploymentStorageType

* Update enum name to camel case

* Update enum names to camel case

* Port changes to 2024-04-01 API version

* Rename storageType to FunctionsDeploymentStorageType
* Update enum name's to use amelcase casing

---------

Co-authored-by: Naveed Aziz <[email protected]>

* Add SKU property to site. Add description for supported values of kin… (#29354)

* Add SKU property to site. Add description for supported values of kind property on app

* Fix typo

* Fix prettier

* User/rohinisharma/update instance info (#29333)

* Adding parameter to Website Instance Info obj

* Prettier

---------

Co-authored-by: Rohini Sharma <[email protected]>
Co-authored-by: Naveed Aziz <[email protected]>

* [AppServices] Add AutoGeneratedDomainNameLabelScope to Websites (#29649)

* [DNL] Add AutoGeneratedDomainNameLabelScope to Websites

* fix casing

* fix prettier

* Add e2e tls to latest releases (#29904)

Co-authored-by: Chris Rosenblatt <[email protected]>

* Add updatemachinekey api (#29730)

* Add updatemachinekey api

* fix json formatting

* Change api version

* Add machinekey to allowed words

* action verb at end of address

* Change post address to conform to arm

---------

Co-authored-by: Naveed Aziz <[email protected]>

* Developer/nineela/autogenerateddomainnamelabelscope edit 2 (#30047)

* [DNL] Add AutoGeneratedDomainNameLabelScope to Websites

* Minor comment update

* Add IP Mode to Websites (#29089)

* Add IP Mode to Websites

* Target 2024-04-01

* Fix linter

---------

Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: Naveed Aziz <[email protected]>

* Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig (#30050)

* Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig (#29907)

* Set format to int32 for all number types in the functionAppConfig

* Update types to integer.

---------

Co-authored-by: Naveed Aziz <[email protected]>

* Update types to integer and set format to int32 for all number types in the functionAppConfig

---------

Co-authored-by: Naveed Aziz <[email protected]>

* Add CipherSuites object to support discoverability API (#30067)

Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: Naveed Aziz <[email protected]>

---------

Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: Francisco Gamino <[email protected]>
Co-authored-by: rohinisharma <[email protected]>
Co-authored-by: Rohini Sharma <[email protected]>
Co-authored-by: nineela <[email protected]>
Co-authored-by: andrewschuck <[email protected]>
cheukchuen pushed a commit that referenced this pull request Jan 24, 2025
* Release web 2024 04 01 (#28952)

* Copy files from stable/2023-12-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-04-01

Updated the API version from stable/2023-12-01 to stable/2024-04-01.

* Added tag for 2024-04-01 in readme file

* Copy files from stable/2023-12-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-04-01

Updated the API version from stable/2023-12-01 to stable/2024-04-01.

* Added tag for 2024-04-01 in readme file

* Copy files from stable/2023-12-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-04-01

Updated the API version from stable/2023-12-01 to stable/2024-04-01.

* Added tag for 2024-04-01 in readme file

* Fix RP merge issue

* Fix prettier failute

* Fix spellcheck for sitecontainers

* Fix prettier check failures

* Fix ALL prettier check failures

* Add LeastRequestsWithTieBreaker (#29128)

* Add LeastRequestsWithTieBreaker

* Change to target 2024-04-01

---------

Co-authored-by: Chris Rosenblatt <[email protected]>

* Update 2023-12-01 Microsoft.Web functionAppConfig definition (#29226) (#29350)

* Update 2023-12-01 Microsoft.Web functionAppConfig definition (#29226)

* Rename enum to functionsDeploymentStorageType

* Update enum name to camel case

* Update enum names to camel case

* Port changes to 2024-04-01 API version

* Rename storageType to FunctionsDeploymentStorageType
* Update enum name's to use amelcase casing

---------

Co-authored-by: Naveed Aziz <[email protected]>

* Add SKU property to site. Add description for supported values of kin… (#29354)

* Add SKU property to site. Add description for supported values of kind property on app

* Fix typo

* Fix prettier

* User/rohinisharma/update instance info (#29333)

* Adding parameter to Website Instance Info obj

* Prettier

---------

Co-authored-by: Rohini Sharma <[email protected]>
Co-authored-by: Naveed Aziz <[email protected]>

* [AppServices] Add AutoGeneratedDomainNameLabelScope to Websites (#29649)

* [DNL] Add AutoGeneratedDomainNameLabelScope to Websites

* fix casing

* fix prettier

* Add e2e tls to latest releases (#29904)

Co-authored-by: Chris Rosenblatt <[email protected]>

* Add updatemachinekey api (#29730)

* Add updatemachinekey api

* fix json formatting

* Change api version

* Add machinekey to allowed words

* action verb at end of address

* Change post address to conform to arm

---------

Co-authored-by: Naveed Aziz <[email protected]>

* Developer/nineela/autogenerateddomainnamelabelscope edit 2 (#30047)

* [DNL] Add AutoGeneratedDomainNameLabelScope to Websites

* Minor comment update

* Add IP Mode to Websites (#29089)

* Add IP Mode to Websites

* Target 2024-04-01

* Fix linter

---------

Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: Naveed Aziz <[email protected]>

* Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig (#30050)

* Microsft.Web 2023-12-01: Add int32 format to all number types in the scaleAndConcurrency section of the functionAppConfig (#29907)

* Set format to int32 for all number types in the functionAppConfig

* Update types to integer.

---------

Co-authored-by: Naveed Aziz <[email protected]>

* Update types to integer and set format to int32 for all number types in the functionAppConfig

---------

Co-authored-by: Naveed Aziz <[email protected]>

* Add CipherSuites object to support discoverability API (#30067)

Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: Naveed Aziz <[email protected]>

---------

Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: Chris Rosenblatt <[email protected]>
Co-authored-by: Francisco Gamino <[email protected]>
Co-authored-by: rohinisharma <[email protected]>
Co-authored-by: Rohini Sharma <[email protected]>
Co-authored-by: nineela <[email protected]>
Co-authored-by: andrewschuck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants