Skip to content

Conversation

@davidemontanari
Copy link
Member

@davidemontanari davidemontanari commented Jun 11, 2024

Reverts #29319

Data type changes are breaking the API validation.

Sev2 IcM: https://portal.microsofticm.com/imp/v5/incidents/details/512137700/summary

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 11, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 11, 2024

Swagger Validation Report

️❌BreakingChange: 38 Errors, 2 Warnings failed [Detail]
Compared specs (v0.10.9) new version base version
deviceregistry.json 2023-11-01-preview(aa51607) 2023-11-01-preview(main)

Only 30 items are listed, please refer to log for more details.

Rule Message
1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L406:13
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L406:13
1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L953:9
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L858:9
1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L968:9
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L920:9
1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1565:9
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1366:9
1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1569:9
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1370:9
1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L972:9
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L924:9
1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L715:13
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L715:13
1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1171:9
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L827:9
1023 - TypeFormatChanged The new version has a different format '' than the previous one 'uri'.
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1036:9
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L996:9
1023 - TypeFormatChanged The new version has a different format '' than the previous one 'uri'.
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1054:9
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1015:9
1023 - TypeFormatChanged The new version has a different format '' than the previous one 'uri'.
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1074:9
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1036:9
1023 - TypeFormatChanged The new version has a different format '' than the previous one 'uri'.
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1201:9
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1015:9
1023 - TypeFormatChanged The new version has a different format '' than the previous one 'uri'.
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1221:9
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1036:9
1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L962:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L909:7
1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1533:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1334:7
1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1596:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1382:7
1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1623:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1400:7
1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1471:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1317:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'uuid' renamed or removed?
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L962:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L909:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'provisioningState' renamed or removed?
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L962:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L909:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'extendedLocation' renamed or removed?
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L945:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L857:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'location' renamed or removed?
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L945:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L857:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'id' renamed or removed?
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L945:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L857:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'name' renamed or removed?
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L945:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L857:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'type' renamed or removed?
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L945:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L857:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L945:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L857:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'uuid' renamed or removed?
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1180:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L966:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'externalAssetId' renamed or removed?
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1180:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L966:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'assetEndpointProfileUri' renamed or removed?
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1180:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L966:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'version' renamed or removed?
New: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1180:7
Old: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L966:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 1 Errors, 1 Warnings failed [Detail]
Compared specs (v2.2.2) new version base version
package-preview-2023-11 package-preview-2023-11(aa51607) package-preview-2023-11(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1229
RPC-Policy-V1-05, RPC-Put-V1-23
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1185


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:mode.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L406
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L1082
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L65
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L72
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L78
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L101
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L104
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L117
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L140
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L143
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L156
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L179
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L182
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L185
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L188
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L195
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L201
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L221
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L224
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L227
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L240
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L263
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L266
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L269
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L292
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L310
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L313
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L316
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L361
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.DeviceRegistry/preview/2023-11-01-preview/deviceregistry.json#L383
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 11, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 0da621d8ef5845bd01341c6b7802e2bfa3616877. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    warn		specification/deviceregistry/DeviceRegistry.Management/tspconfig.yaml skipped due to azure-sdk-for-go not found in tspconfig.yaml
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/deviceregistry/armdeviceregistry [Preview SDK Changes]
️❌ azure-sdk-for-java failed [Detail]
  • Code Generator Failed in generating from 0da621d8ef5845bd01341c6b7802e2bfa3616877. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-deviceregistry [Preview SDK Changes]
    • pom.xml
    • azure-resourcemanager-deviceregistry-1.0.0-beta.2-sources.jar
    • azure-resourcemanager-deviceregistry-1.0.0-beta.2.jar
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 0da621d8ef5845bd01341c6b7802e2bfa3616877. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] npm notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[automation_init.sh] npm notice To update run: npm install -g [email protected]
    cmderr	[automation_init.sh] npm notice
    warn		specification/deviceregistry/DeviceRegistry.Management/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-deviceregistry [Preview SDK Changes]
    • azure_mgmt_deviceregistry-1.0.0b1-py3-none-any.whl
    • azure-mgmt-deviceregistry-1.0.0b1.zip
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 11, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/deviceregistry/armdeviceregistry There is no API change compared with the previous version
Java azure-resourcemanager-deviceregistry https://apiview.dev/Assemblies/Review/90da387f53324bba89095f644611247c?revisionId=789fa074dfb04bdf83559cb97c225faf
TypeSpec DeviceRegistry.Management https://apiview.dev/Assemblies/Review/8c8020c228c948c5bb66512e800753e8?revisionId=f4d96c8d77214e10841e314a1d615e8a
Swagger Microsoft.DeviceRegistry https://apiview.dev/Assemblies/Review/a84f09ee6eb74e6db3594048924a2f07?revisionId=34a7b417ded243e1b11a7f6fd5178cee

@rkmanda rkmanda added BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed NotReadyForARMReview labels Jun 11, 2024
@rkmanda rkmanda merged commit 4ee6d9f into main Jun 11, 2024
@rkmanda rkmanda deleted the revert-29319-update-device-registry branch June 11, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager RPaaS TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants