-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Batch] Release Microsoft.Batch Data Plane 2024-07-01 #29533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Generation Artifacts
|
Generated ApiView
|
657f0a7 to
e3e1df7
Compare
581782f to
f593020
Compare
dpwatrous
reviewed
Jul 8, 2024
specification/batch/data-plane/Microsoft.Batch/stable/2024-07-01/BatchService.json
Show resolved
Hide resolved
specification/batch/data-plane/Microsoft.Batch/stable/2024-07-01/BatchService.json
Outdated
Show resolved
Hide resolved
f785495 to
045d8e9
Compare
7731e7c to
585de04
Compare
johanste
reviewed
Jul 19, 2024
specification/batch/data-plane/Microsoft.Batch/stable/2024-07-01.20.0/BatchService.json
Show resolved
Hide resolved
wanghoppe
reviewed
Aug 7, 2024
specification/batch/data-plane/Microsoft.Batch/stable/2024-07-01.20.0/BatchService.json
Outdated
Show resolved
Hide resolved
500abfe to
04c1fee
Compare
johanste
approved these changes
Aug 8, 2024
2b4ef5a to
9adcdcd
Compare
Member
Author
|
Suppression Justification: This PR adds a LroExtension suppression because there were two new apis added, /pools/{poolId}/nodes/{nodeId}/start and /pools/{poolId}/nodes/{nodeId}/deallocate, which return 202 without having a x-ms-long-running-operation: true. These 2 new api follow the same pattern as 14 other existing api's in this service so it was a case of this services design forces this behavior. |
3 tasks
wanghoppe
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Aug 30, 2024
### Packages impacted by this PR @azure/batch ### Issues associated with this PR N/A ### Describe the problem that is addressed by this PR Release a new version of JS SDK according to Azure Batch's new API version (2024-07-01) ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? N/A\ ### Are there test cases added in this PR? _(If not, why?)_ Yes ### Provide a list of related PRs _(if any)_ Spec PR: Azure/azure-rest-api-specs#29533 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [ ] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [ ] Added a changelog (if necessary) --------- Co-authored-by: Hoppe Wang <[email protected]>
3 tasks
cheukchuen
pushed a commit
that referenced
this pull request
Jan 24, 2025
* Base commit (data plane) * 2024-07-01 updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
APIStewardshipBoard-SignedOff
The Azure API Stewardship team has reviewed and approved the changes.
Approved-Suppression
Batch
BreakingChange-Approved-UserImpact
Changes are not backward compatible and may cause customer disruption.
BreakingChangeReviewRequired
<valid label in PR review process>add this label when breaking change review is required
data-plane
new-api-version
PipelineBotTrigger
PublishToCustomers
Acknowledgement the changes will be published to Azure customers.
SuppressionReviewRequired
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.