Azure maps resource provider #3007

yuqi2 · 2018-05-03T22:15:16Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

* Change Azure Maps to Maps * Azure Maps to Maps * add examples * change file names * add 2018-05-01 * change api-version to 2018-05-01

AutorestCI · 2018-05-03T22:15:48Z

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

AutorestCI · 2018-05-03T22:15:54Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

AutorestCI · 2018-05-03T22:16:17Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#2526

AutorestCI · 2018-05-03T22:17:40Z

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#1784

marstr · 2018-05-03T22:17:59Z

Commits up to b2a473c have been reviewed and approved in: https://github.com/Azure/azure-rest-api-specs-pr/pull/440

edit: spelling

yuqi2 · 2018-05-03T23:42:45Z

@marstr @jianghaolu Here attach the the Approval from the PR in private branch : https://github.com/Azure/azure-rest-api-specs-pr/pull/440

azuresdkciprbot · 2018-05-04T21:30:41Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/maps/resource-manager/readme.md

⚠️

2 new Warnings.(2 total)

Code	Id	Source	Message
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: 'moveresources' in:'Accounts_Move'. Consider updating the operationId
PutRequestResponseScheme	R2017	Link	A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Accounts_CreateOrUpdate' Request Model: 'MapsAccountCreateParameters' Response Model: 'MapsAccount'

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-04T21:30:41Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/maps/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-04T21:32:07Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/maps/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-04T21:32:07Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/maps/resource-manager/readme.md

⚠️

2 new Warnings.(2 total)

Code	Id	Source	Message
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: 'moveresources' in:'Accounts_Move'. Consider updating the operationId
PutRequestResponseScheme	R2017	Link	A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Accounts_CreateOrUpdate' Request Model: 'MapsAccountCreateParameters' Response Model: 'MapsAccount'

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-04T21:42:08Z

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/maps/resource-manager/readme.md

⚠️

0 new Warnings.(0 total)

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

azuresdkciprbot · 2018-05-04T21:42:08Z

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/maps/resource-manager/readme.md

⚠️

2 new Warnings.(2 total)

Code	Id	Source	Message
PostOperationIdContainsUrlVerb	R2066	Link	OperationId should contain the verb: 'moveresources' in:'Accounts_Move'. Consider updating the operationId
PutRequestResponseScheme	R2017	Link	A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Accounts_CreateOrUpdate' Request Model: 'MapsAccountCreateParameters' Response Model: 'MapsAccount'

❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

Yuqi Zhang and others added 6 commits April 3, 2018 14:27

Rename Azure LBS Management Plane To Azure Maps

af5df6d

Rename Azure LBS Management Plane To Azure Maps

9df27b5

modify readme.nodejs.md

45a0b75

Rectify typo

e6ad85b

Change LBS tp Maps

b101141

Rename Azure Maps to Maps, and adding examples (#440)

b2a473c

* Change Azure Maps to Maps * Azure Maps to Maps * add examples * change file names * add 2018-05-01 * change api-version to 2018-05-01

azuresdkci assigned jianghaolu May 3, 2018

azuresdkci requested a review from jianghaolu May 3, 2018 22:16

AutorestCI mentioned this pull request May 3, 2018

[AutoPR maps/resource-manager] Azure maps resource provider Azure/azure-sdk-for-python#2526

Merged

AutorestCI mentioned this pull request May 3, 2018

[AutoPR maps/resource-manager] Azure maps resource provider Azure/azure-sdk-for-go#1784

Merged

marstr force-pushed the AzureMapsResourceProvider branch from f36b06d to b95d339 Compare May 4, 2018 21:28

marstr force-pushed the AzureMapsResourceProvider branch from b95d339 to b2a473c Compare May 4, 2018 21:32

Merge branch 'AzureMapsResourceProvider'

3d90372

jianghaolu approved these changes May 4, 2018

View reviewed changes

jianghaolu merged commit 10e2389 into master May 4, 2018

jp94 mentioned this pull request May 10, 2018

[SDKs/LBS] Deprecate LocationBasedServices mgmt .NET SDK Azure/azure-sdk-for-net#4307

Merged

9 tasks

vladbarosan deleted the AzureMapsResourceProvider branch November 7, 2018 19:36

Azure maps resource provider #3007

Azure maps resource provider #3007

Uh oh!

Conversation

yuqi2 commented May 3, 2018 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

AutorestCI commented May 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-libraries-for-java

Uh oh!

AutorestCI commented May 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

AutorestCI commented May 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented May 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

marstr commented May 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuqi2 commented May 3, 2018

Uh oh!

azuresdkciprbot commented May 4, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented May 4, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented May 4, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented May 4, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented May 4, 2018

AutoRest linter results for ARM Related Validation Errors/Warnings

Uh oh!

azuresdkciprbot commented May 4, 2018

AutoRest linter results for SDK Related Validation Errors/Warnings

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

yuqi2 commented May 3, 2018 •

edited by azuresdkci

Loading

AutorestCI commented May 3, 2018 •

edited

Loading

AutorestCI commented May 3, 2018 •

edited

Loading

AutorestCI commented May 3, 2018 •

edited

Loading

AutorestCI commented May 3, 2018 •

edited

Loading

marstr commented May 3, 2018 •

edited

Loading