Release sql microsoft.sql 2024 05 01 preview #30510

ravigautam1896 · 2024-09-11T15:15:48Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

…rsion (#29200) * Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview * Updates API version in new specs and examples * Updates readme * addressing comments * resolving spell check errors * resolving LroLocationheader errors * supress errors from DatabaseAdvisiors.json * reverting the supression --------- Co-authored-by: Ravi Gautam <[email protected]>

* Update for Import/Export with Managed Identity * Fix the example reference and update description

…29823) * Set the new additionalProperties type to string * Remove the required type for additionalProperties, just keep them true

* Add instance pool operations swagger and examples * Address prettier check errors * Fix Swagger LintDiff errors * Fix parameter names to match parameter patterns * Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing) * Replace bool with enum (PR review remark) --------- Co-authored-by: Ivan Arandjelovic <[email protected]>

* Adding updated DatabaseOperations.json file * Trying to fix ModelValidation error * Reverting testing change --------- Co-authored-by: Roopesh Manda <[email protected]>

…ft.Sql-2024-05-01-preview (#30030) * taking changes from dsmaindev side * removing further DatabaseAdvisor.json changes * resolving spellcheck validation * resolving ModelValidation errors * resolving avocado errors * resolving LRO Headers Validation and xmsEnum Validation * resolving indentation --------- Co-authored-by: Ravi Gautam <[email protected]>

Co-authored-by: Ravi Gautam <[email protected]>

* reverting cspell.json changes * revert changes2 --------- Co-authored-by: Ravi Gautam <[email protected]>

Co-authored-by: Ivan Arandjelovic <[email protected]>

openapi-pipeline-app · 2024-09-11T15:15:53Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-09-11T15:15:54Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/sql/armsql	https://apiview.dev/Assemblies/Review/ddcdbf3100fb45bbaafb400a9a70d425?revisionId=4fb3350b0027403895b4ba3e9147795c
JavaScript	@azure/arm-sql	https://apiview.dev/Assemblies/Review/129721cd69b541de821b5e7227b49902?revisionId=cefb1ebee5f94be4968b8fd87751aafb
.Net	Azure.ResourceManager.Sql	https://apiview.dev/Assemblies/Review/1e3ea1e2dc2c4679b3acd45b20b81a18?revisionId=436a094f5f214228979a7fca5cc8f011
Swagger	Microsoft.Sql	https://apiview.dev/Assemblies/Review/86f9467cec6a49f899d90b4872280851?revisionId=824553912cd04f22822cc1c24456b9f6

ravigautam1896 · 2024-09-13T05:55:29Z

/azp run

azure-pipelines · 2024-09-13T05:55:48Z

Azure Pipelines successfully started running 3 pipeline(s).

gary-x-li · 2024-09-14T14:17:40Z

In this PR, are you introducing a new API version based off a previous version? If so, you should have added all the files of the base version in the very first commit of your PR. This allows API reviewers to see just the deltas of your new API version. If that's the case, please add your base commit in a new commit (make sure the commit message is clear) and another commit to revert that commit (so that your latest commit always reflects the latest code).

gary-x-li · 2024-09-15T14:53:24Z

In this PR, are you introducing a new API version based off a previous version? If so, you should have added all the files of the base version in the very first commit of your PR. This allows API reviewers to see just the deltas of your new API version. If that's the case, please add your base commit in a new commit (make sure the commit message is clear) and another commit to revert that commit (so that your latest commit always reflects the latest code).

Got the response offline. Pasting it here:

For every API Version we have a separate folder, where we keep all the files related to that version. When we copy all the files from previous Api Version for the base commit, we copy it to the new folder and rename the version in all the files.

That's why you might be seeing them as a new file but indeed they have been copied from previous API Version files only.

gary-x-li · 2024-09-15T15:01:37Z

Based on offline conversations with Ravi Gautam and Ji Wang, The LintDiff and ModelValidation errors were carried over from previous versions. There are previous PRs which were applied the suppressions as well. Hence added the above two labels.

#26289
#27828

ravigautam1896 · 2024-09-15T17:12:41Z

/pr RequestMerge

* Adding folders and examples changes for Version 2024-05-01 preview version (#29200) * Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview * Updates API version in new specs and examples * Updates readme * addressing comments * resolving spell check errors * resolving LroLocationheader errors * supress errors from DatabaseAdvisiors.json * reverting the supression --------- Co-authored-by: Ravi Gautam <[email protected]> * Update for Import/Export with Managed Identity (#29596) * Update for Import/Export with Managed Identity * Fix the example reference and update description * Set the additionalProperties type to string for DatabaseAdvisors API (#29823) * Set the new additionalProperties type to string * Remove the required type for additionalProperties, just keep them true * Dev/ivarandj/instance pool operations api (#29932) * Add instance pool operations swagger and examples * Address prettier check errors * Fix Swagger LintDiff errors * Fix parameter names to match parameter patterns * Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing) * Replace bool with enum (PR review remark) --------- Co-authored-by: Ivan Arandjelovic <[email protected]> * Adding updated DatabaseOperations.json file (#29956) * Adding updated DatabaseOperations.json file * Trying to fix ModelValidation error * Reverting testing change --------- Co-authored-by: Roopesh Manda <[email protected]> * Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview (#30030) * taking changes from dsmaindev side * removing further DatabaseAdvisor.json changes * resolving spellcheck validation * resolving ModelValidation errors * resolving avocado errors * resolving LRO Headers Validation and xmsEnum Validation * resolving indentation --------- Co-authored-by: Ravi Gautam <[email protected]> * resolve merge conflict for cSpell.json (#30179) Co-authored-by: Ravi Gautam <[email protected]> * reverting cspell.json changes (#30285) * reverting cspell.json changes * revert changes2 --------- Co-authored-by: Ravi Gautam <[email protected]> * Fix lintdiff enum errpr (#30383) Co-authored-by: Ivan Arandjelovic <[email protected]> --------- Co-authored-by: Ravi Gautam <[email protected]> Co-authored-by: psong-ms <[email protected]> Co-authored-by: UrosKrsticMIPerf <[email protected]> Co-authored-by: Ivan Arandjelovic <[email protected]> Co-authored-by: Ivan Arandjelovic <[email protected]> Co-authored-by: akromm <[email protected]> Co-authored-by: Roopesh Manda <[email protected]> Co-authored-by: Mike Harder <[email protected]>

ravigautam1896 and others added 10 commits June 13, 2024 16:20

Update for Import/Export with Managed Identity (#29596)

a7cbe56

* Update for Import/Export with Managed Identity * Fix the example reference and update description

Set the additionalProperties type to string for DatabaseAdvisors API (#…

8a9361a

…29823) * Set the new additionalProperties type to string * Remove the required type for additionalProperties, just keep them true

Adding updated DatabaseOperations.json file (#29956)

18937ee

* Adding updated DatabaseOperations.json file * Trying to fix ModelValidation error * Reverting testing change --------- Co-authored-by: Roopesh Manda <[email protected]>

resolve merge conflict for cSpell.json (#30179)

1b38659

Co-authored-by: Ravi Gautam <[email protected]>

reverting cspell.json changes (#30285)

08acca3

* reverting cspell.json changes * revert changes2 --------- Co-authored-by: Ravi Gautam <[email protected]>

Merge branch 'main' into release-sql-Microsoft.Sql-2024-05-01-preview

8e3d118

Fix lintdiff enum errpr (#30383)

f3038a5

Co-authored-by: Ivan Arandjelovic <[email protected]>

microsoft-github-policy-service bot added the SQL label Sep 11, 2024

ravigautam1896 marked this pull request as ready for review September 11, 2024 15:40

ravigautam1896 requested review from ericshape, jamestao and jeremyfrosti as code owners September 11, 2024 15:40

azure-sdk mentioned this pull request Sep 11, 2024

[AutoPR Azure.ResourceManager.Sql] Release sql microsoft.sql 2024 05 01 preview azure-sdk/azure-sdk-for-net#9161

Closed

AzureRestAPISpecReview added ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version NotReadyForARMReview resource-manager labels Sep 11, 2024

ericshape approved these changes Sep 11, 2024

View reviewed changes

JeffreyRichter added the BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR label Sep 11, 2024

ravigautam1896 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Sep 12, 2024

openapi-pipeline-app bot added PipelineBotTrigger and removed PipelineBotTrigger labels Sep 13, 2024

ravigautam1896 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 13, 2024

gary-x-li removed the NotReadyForARMReview label Sep 14, 2024

gary-x-li added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 15, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 15, 2024

gary-x-li added Approved-LintDiff Approved-ModelValidation labels Sep 15, 2024

ravigautam1896 merged commit 4092328 into main Sep 16, 2024

ravigautam1896 deleted the release-sql-Microsoft.Sql-2024-05-01-preview branch September 16, 2024 05:50

achyuth-ms mentioned this pull request Jul 15, 2025

Release sql microsoft.sql 2024 11 01 preview version #35794

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release sql microsoft.sql 2024 05 01 preview #30510

Release sql microsoft.sql 2024 05 01 preview #30510

ravigautam1896 commented Sep 11, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Sep 11, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Sep 11, 2024 •

edited

Loading

Uh oh!

ravigautam1896 commented Sep 13, 2024

Uh oh!

azure-pipelines bot commented Sep 13, 2024

Uh oh!

gary-x-li commented Sep 14, 2024

Uh oh!

gary-x-li commented Sep 15, 2024

Uh oh!

gary-x-li commented Sep 15, 2024 •

edited

Loading

Uh oh!

ravigautam1896 commented Sep 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Release sql microsoft.sql 2024 05 01 preview #30510

Release sql microsoft.sql 2024 05 01 preview #30510

Conversation

ravigautam1896 commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app bot commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

ravigautam1896 commented Sep 13, 2024

Uh oh!

azure-pipelines bot commented Sep 13, 2024

Uh oh!

gary-x-li commented Sep 14, 2024

Uh oh!

gary-x-li commented Sep 15, 2024

Uh oh!

gary-x-li commented Sep 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ravigautam1896 commented Sep 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

ravigautam1896 commented Sep 11, 2024 •

edited

Loading

openapi-pipeline-app bot commented Sep 11, 2024 •

edited

Loading

openapi-pipeline-app bot commented Sep 11, 2024 •

edited

Loading

gary-x-li commented Sep 15, 2024 •

edited

Loading