Added Azure Container Instance API Version 2024-10-01-preview #30569
suppress additionalProperties
- Loading branch information
commit 251baec625cd94a63d03c9c0abc7abc5998f46e8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| suppressions: | ||
| - code: AvoidAdditionalProperties | ||
| from: swagger.yaml | ||
| reason: Keeping it for legacy tooling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this property used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also a dictionary just as 'SecretVolume'. The 'SecretVolume' is a dictionary of customer provided explicit secret values whereas 'SecretReferenceVolume' is a customer provided secret reference value. The value will point to one of the 'SecretReference' object defined in line 839
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to add the additional properties to indicate a dictionary object as stated here https://swagger.io/docs/specification/data-models/dictionaries/
but the PR was giving me Swagger LintDiff validation failures RPC-Policy-V1-05, RPC-Put-V1-23. Please advise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because ARM is trying to reduce instances of unschematized APIs to make it easier for consumers of those APIs to understand them and use them reliably
It is recommended to use arrays with pairs in place of dictionary if defining a schema is not possible.
If it is not possible provide an explanation for why you need this and obtain a suppresion for the Swagger LintDiff validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. Suppressed.