[Microsoft.ConfidentialLedger] Add new ARM API version preview/2024-09-19-preview #30653

andpiccione · 2024-09-19T22:26:58Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

Purpose of this PR: add two new optional enum properties (EnclavePlatform and ApplicationType) to the ARM REST API specifications for Azure Confidential Ledger and Azure Managed CCF.

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.

Updated the API version from preview/2024-07-09-preview to preview/2024-09-19-preview.

openapi-pipeline-app · 2024-09-19T22:27:02Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-09-19T22:27:02Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/confidentialledger/armconfidentialledger	https://apiview.dev/Assemblies/Review/287daa866e6e45cf8fec3bdd308d00e6?revisionId=2286447911bf4110bd0d16f1964bdc26
.Net	Azure.ResourceManager.ConfidentialLedger	https://apiview.dev/Assemblies/Review/01c60ac719654d1aa9a8e0fd5535034e?revisionId=c15ddf3913564cbaa218e401b2db033f
Python	azure-mgmt-confidentialledger	https://apiview.dev/Assemblies/Review/2db4a5f794f54996b1ab478161fe4187?revisionId=7d5774c9a63d453796448ed1f214339c
JavaScript	@azure/arm-confidentialledger	https://apiview.dev/Assemblies/Review/ff8066cd13514e1d8352552be9ff67cf?revisionId=2fc9e69050b248d49a270d0b2aaa0f32
Java	azure-resourcemanager-confidentialledger	https://apiview.dev/Assemblies/Review/60a6c6bcb8174dae8b2440b04b02eee3?revisionId=571e290e326c48d4bedd35e76a4c607e

andpiccione · 2024-09-19T23:21:55Z

The required check Breaking Change(Cross-Version) is failing due to changes that are not related to this new API version (see details).

This new preview API version has been based off the latest preview version (2024-07-09-preview) and the previous PR / preview API version, which also had the same detected breaking changes, was eventually approved. Therefore, I've added the BreakingChange-Approved-Previously label.

andpiccione · 2024-09-19T23:25:36Z

/azp run

azure-pipelines · 2024-09-19T23:25:49Z

Azure Pipelines successfully started running 3 pipeline(s).

…fidentialLedger-2024-09-19-preview

azure-sdk · 2024-12-31T19:04:13Z

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.ConfidentialLedger
Microsoft.CodeTransparency
Microsoft.ManagedCcf

andpiccione · 2024-12-31T19:34:34Z

/azp run

azure-pipelines · 2024-12-31T19:34:49Z

Azure Pipelines successfully started running 4 pipeline(s).

andpiccione · 2025-01-03T01:51:31Z

Waiting for team review before merging the PR

…fidentialLedger-2024-09-19-preview

ryazhang-microsoft

LGTM!

…9-19-preview (Azure#30653) * Copy files from preview/2024-07-09-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-09-19-preview Updated the API version from preview/2024-07-09-preview to preview/2024-09-19-preview. * Added tag for 2024-09-19-preview in readme file * Add enclave platform property * Fix prettier * Add application type property

andpiccione added 4 commits September 19, 2024 15:10

Copy files from preview/2024-07-09-preview

d488fa1

Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.

Update version to preview/2024-09-19-preview

bf390fd

Updated the API version from preview/2024-07-09-preview to preview/2024-09-19-preview.

Added tag for 2024-09-19-preview in readme file

1c01bfd

Add enclave platform property

0fbd9b0

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager RPaaS labels Sep 19, 2024

Fix prettier

4af67fa

andpiccione added the BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR label Sep 19, 2024

andpiccione added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Sep 19, 2024

andpiccione mentioned this pull request Sep 19, 2024

[Microsoft.ConfidentialLedger] Add new version preview/2024-03-07-preview #28133

Closed

7 tasks

andpiccione added 2 commits September 20, 2024 08:11

Merge branch 'main' into andpiccione-confidentialledger-Microsoft.Con…

885165d

…fidentialLedger-2024-09-19-preview

Merge branch 'main' into andpiccione-confidentialledger-Microsoft.Con…

5903a16

…fidentialLedger-2024-09-19-preview

github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Dec 31, 2024

azure-sdk mentioned this pull request Dec 31, 2024

[AutoPR azure-resourcemanager-confidentialledger] [Microsoft.ConfidentialLedger] Add new ARM API version preview/2024-09-19-preview azure-sdk/azure-sdk-for-java#13570

Closed

Add application type property

f773aa1

andpiccione marked this pull request as ready for review December 31, 2024 19:34

andpiccione self-assigned this Dec 31, 2024

AzureRestAPISpecReview added ARMReview new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Dec 31, 2024

raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jan 2, 2025

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 2, 2025

Merge branch 'main' into andpiccione-confidentialledger-Microsoft.Con…

1898dc5

…fidentialLedger-2024-09-19-preview

andpiccione enabled auto-merge (squash) January 8, 2025 21:23

ryazhang-microsoft approved these changes Jan 8, 2025

View reviewed changes

andpiccione merged commit 636f504 into main Jan 8, 2025
29 of 30 checks passed

andpiccione deleted the andpiccione-confidentialledger-Microsoft.ConfidentialLedger-2024-09-19-preview branch January 8, 2025 21:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Microsoft.ConfidentialLedger] Add new ARM API version preview/2024-09-19-preview #30653

[Microsoft.ConfidentialLedger] Add new ARM API version preview/2024-09-19-preview #30653

Uh oh!

andpiccione commented Sep 19, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Sep 19, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Sep 19, 2024 •

edited

Loading

Uh oh!

andpiccione commented Sep 19, 2024

Uh oh!

andpiccione commented Sep 19, 2024

Uh oh!

azure-pipelines bot commented Sep 19, 2024

Uh oh!

azure-sdk commented Dec 31, 2024 •

edited

Loading

Uh oh!

andpiccione commented Dec 31, 2024

Uh oh!

azure-pipelines bot commented Dec 31, 2024

Uh oh!

andpiccione commented Jan 3, 2025

Uh oh!

ryazhang-microsoft left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[Microsoft.ConfidentialLedger] Add new ARM API version preview/2024-09-19-preview #30653

[Microsoft.ConfidentialLedger] Add new ARM API version preview/2024-09-19-preview #30653

Uh oh!

Conversation

andpiccione commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app bot commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

andpiccione commented Sep 19, 2024

Uh oh!

andpiccione commented Sep 19, 2024

Uh oh!

azure-pipelines bot commented Sep 19, 2024

Uh oh!

azure-sdk commented Dec 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andpiccione commented Dec 31, 2024

Uh oh!

azure-pipelines bot commented Dec 31, 2024

Uh oh!

andpiccione commented Jan 3, 2025

Uh oh!

ryazhang-microsoft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

andpiccione commented Sep 19, 2024 •

edited

Loading

openapi-pipeline-app bot commented Sep 19, 2024 •

edited

Loading

openapi-pipeline-app bot commented Sep 19, 2024 •

edited

Loading

azure-sdk commented Dec 31, 2024 •

edited

Loading