Skip to content

Conversation

@minhanh-phan
Copy link
Member

Update the TypeSpec for 2024-08-01-preview and 2024-09-01-preview to mark the property as optional for missing files from #30632 and #30887

@minhanh-phan minhanh-phan requested a review from yangyuan as a code owner October 7, 2024 23:10
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 7, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ The required check named Swagger SemanticValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 7, 2024

Generated ApiView

Language Package Name ApiView Link
Swagger AzureOpenAI https://apiview.dev/Assemblies/Review/6693675ace534d4aa3159f202a195962?revisionId=75244a12fc0c4673aeb0c4c04c58e6b4

@AzureRestAPISpecReview AzureRestAPISpecReview added data-plane TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Oct 7, 2024
@lmazuel lmazuel merged commit 4af4e91 into main Oct 8, 2024
@lmazuel lmazuel deleted the fix/ts-aoai-optional branch October 8, 2024 19:19
cheukchuen pushed a commit that referenced this pull request Jan 24, 2025
pjpatel12 pushed a commit to pjpatel12/azure-rest-api-specs that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cognitive Services data-plane TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants