Skip to content

Adding appRole property to ApplicationCreateParameters and ApplicationUpdateParameters #3165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jillcary wants to merge 3 commits into from
Closed

Adding appRole property to ApplicationCreateParameters and ApplicationUpdateParameters #3165

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8fe1dd
Adding appRole property
jillcary May 31, 2018
b8823f8
Add definition for AppRole object
jillcary May 31, 2018
a411487
Added example values for new types
jillcary Jun 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Adding appRole property 
* Add appRole property to ApplicationCreate and ApplicationUpdate
parameters
* Validated swagger api changes
  • Loading branch information
@jillcary
jillcary committed May 31, 2018
commit f8fe1ddfb4cf2caba8dd42b3b8cc575655531cd6
21 changes: 21 additions & 0 deletions specification/graphrbac/data-plane/stable/1.6/graphrbac.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2027,6 +2027,13 @@
"ApplicationCreateParameters": {
"type": "object",
"properties": {
"appRoles": {
"type": "array",
"items": {
"$ref": "#/definitions/appRole"
},
"description": "The collection of application roles that an application may declare."
},
"availableToOtherTenants": {
"type": "boolean",
"description": "Whether the application is available to other tenants."
Expand Down Expand Up @@ -2092,6 +2099,13 @@
"ApplicationUpdateParameters": {
"type": "object",
"properties": {
"appRoles": {
"type": "array",
"items": {
"$ref": "#/definitions/appRole"
},
"description": "The collection of application roles that an application may declare."
},
"availableToOtherTenants": {
"type": "boolean",
"description": "Whether the application is available to other tenants"
Expand Down Expand Up @@ -2168,6 +2182,13 @@
},
"description": "The application permissions."
},
"appRoles": {
"type": "array",
"items": {
"type": "string"
Copy link
Contributor

@hovsepm hovsepm May 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please doublecheck. your other modification declare "$ref": "#/definitions/appRole" types as array elements but here you have type string. It is kind of inconsistent.

},
"description": "The collection of application roles that an application may declare."
},
"availableToOtherTenants": {
"type": "boolean",
"description": "Whether the application is be available to other tenants."
Expand Down