Skip to content

[ACR] Update nodejs config to use 2018-02-preview api-version #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
annatisch merged 2 commits into from
Jun 18, 2018
Merged

[ACR] Update nodejs config to use 2018-02-preview api-version #3251

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94aaf65
Update default tag to 2018-02-preview
djyou Jun 15, 2018
cfb460c
Use 2018-02-preview for nodejs
djyou Jun 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion specification/containerregistry/resource-manager/readme.nodejs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,12 @@ Please also specify `--node-sdks-folder=<path to root folder of your azure-sdk-f
nodejs:
Copy link
Member

@northtyphoon northtyphoon Jun 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may consider the following solution without updating the default so that you can limit the chagne to nodejs.

nodejs:
  azure-arm: true
  package-name: azure-arm-containerregistry
  package-version: 2.3.0
  output-folder: $(node-sdks-folder)/lib/services/containerRegistryManagement
  generate-license-txt: true
  generate-package-json: true
  generate-readme-md: true

input-file:
- Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json
- Microsoft.ContainerRegistry/preview/2018-02-01-preview/containerregistry_build.json

Copy link
Member

@annatisch annatisch Jun 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djyou - I'm ready to sign-off and merge - let me know if you wish to push this suggested change to the nodejs config before I do so :)

Copy link
Member Author

@djyou djyou Jun 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as suggested. This may however introduce more maintenance confusion though. /cc @daschult

Copy link
Member

@annatisch annatisch Jun 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djyou - does this mean that you only want to publish the Nodejs SDK at this time?

Copy link
Member Author

@djyou djyou Jun 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since it's a preview version, we will publish the SDK when necessary.

azure-arm: true
package-name: azure-arm-containerregistry
package-version: 2.1.0-preview
package-version: 2.3.0
output-folder: $(node-sdks-folder)/lib/services/containerRegistryManagement
generate-license-txt: true
generate-package-json: true
generate-readme-md: true
input-file:
- Microsoft.ContainerRegistry/stable/2017-10-01/containerregistry.json
- Microsoft.ContainerRegistry/preview/2018-02-01-preview/containerregistry_build.json
```