Skip to content

Remove Extraneous Fields from Connection and Deployment #33245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
needuv merged 4 commits into from
Mar 17, 2025
Merged

Remove Extraneous Fields from Connection and Deployment #33245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fa8125
Remove unnecessary deployments contracts
needuv Mar 17, 2025
64e9b06
remove unnecessary connection fields
needuv Mar 17, 2025
4a9b172
Merge branch 'feature/azure-ai-projects-1dp' of https://github.com/Az…
needuv Mar 17, 2025
742b3f0
Run npx tsv .
needuv Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions specification/ai/Azure.AI.Projects/connections/models.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ namespace Azure.AI.Projects;
@doc("Response from the listSecrets operation")
@resource("connections")
model Connection {
@doc("Fully qualified resource identifier")
@visibility("read")
id: string;

@doc("The name of the resource")
@visibility("read")
@key("connectionName")
Expand Down
4 changes: 2 additions & 2 deletions specification/ai/Azure.AI.Projects/connections/routes.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ using Azure.Core.Foundations;
namespace Azure.AI.Projects;

alias ConnectionServiceTraits = SupportsClientRequestId &
SupportsRepeatableRequests &
SupportsConditionalRequests;
NoRepeatableRequests &
NoConditionalRequests;

alias ConnectionOperations = Azure.Core.ResourceOperations<ConnectionServiceTraits>;

Expand Down
26 changes: 9 additions & 17 deletions specification/ai/Azure.AI.Projects/deployments/models.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,42 +18,34 @@ namespace Azure.AI.Projects;
@doc("Model Deployment Definition")
@resource("deployments")
model Deployment {
@doc("Name of the deployment for the model")
@doc("Name of the deployment")
@visibility("read")
@key("deploymentName")
deploymentName: string;
@key("name")
name: string;

@doc("Publisher-specific name of the model")
@doc("Publisher-specific name of the deployed model")
@visibility("read")
modelName: string;

@doc("Publisher-specific version of the model")
@doc("Publisher-specific version of the deployed model")
@visibility("read")
modelVersion: string;

@doc("Name of the model publisher")
@doc("Name of the deployed model's publisher")
@visibility("read")
publisher: string;
modelPublisher: string;

@doc("Capabilities of model")
@doc("Capabilities of deployed model")
@visibility("read")
capabilities: Record<string>;

@doc("RAI policy enabled for model")
@visibility("read")
raiPolicyName: string;

@doc("Sku of the model deployment")
@visibility("read")
sku: Sku;

@doc("Name of the connection the model comes from")
@doc("Name of the connection the deployment comes from")
@visibility("read")
connectionName?: string;

@doc("System data of the resource")
@visibility("read")
systemData: SystemData;
}

#suppress "@azure-tools/typespec-azure-core/composition-over-inheritance"
Expand Down
4 changes: 2 additions & 2 deletions specification/ai/Azure.AI.Projects/deployments/routes.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ using Azure.Core.Foundations;
namespace Azure.AI.Projects;

alias DeploymentServiceTraits = SupportsClientRequestId &
SupportsRepeatableRequests &
SupportsConditionalRequests;
NoRepeatableRequests &
NoConditionalRequests;

alias DeploymentOperations = Azure.Core.ResourceOperations<DeploymentServiceTraits>;

Expand Down
119 changes: 16 additions & 103 deletions ...ion/ai/data-plane/Azure.AI.Projects/preview/2025-05-01-preview/azure-ai-projects-1dp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,18 +455,6 @@
},
{
"$ref": "#/parameters/Azure.Core.ClientRequestIdHeader"
},
{
"$ref": "#/parameters/Azure.Core.ConditionalRequestHeaders.ifMatch"
},
{
"$ref": "#/parameters/Azure.Core.ConditionalRequestHeaders.ifNoneMatch"
},
{
"$ref": "#/parameters/Azure.Core.ConditionalRequestHeaders.ifUnmodifiedSince"
},
{
"$ref": "#/parameters/Azure.Core.ConditionalRequestHeaders.ifModifiedSince"
}
],
"responses": {
Expand All @@ -476,10 +464,6 @@
"$ref": "#/definitions/Connection"
},
"headers": {
"ETag": {
"type": "string",
"description": "The entity tag for the response."
},
"x-ms-client-request-id": {
"type": "string",
"format": "uuid",
Expand Down Expand Up @@ -862,7 +846,7 @@
}
}
},
"/deployments/{deploymentName}": {
"/deployments/{name}": {
"get": {
"operationId": "Deployments_Get",
"description": "Get a deployed model.",
Expand All @@ -871,26 +855,14 @@
"$ref": "#/parameters/Azure.Core.Foundations.ApiVersionParameter"
},
{
"name": "deploymentName",
"name": "name",
"in": "path",
"description": "Name of the deployment for the model",
"description": "Name of the deployment",
"required": true,
"type": "string"
},
{
"$ref": "#/parameters/Azure.Core.ClientRequestIdHeader"
},
{
"$ref": "#/parameters/Azure.Core.ConditionalRequestHeaders.ifMatch"
},
{
"$ref": "#/parameters/Azure.Core.ConditionalRequestHeaders.ifNoneMatch"
},
{
"$ref": "#/parameters/Azure.Core.ConditionalRequestHeaders.ifUnmodifiedSince"
},
{
"$ref": "#/parameters/Azure.Core.ConditionalRequestHeaders.ifModifiedSince"
}
],
"responses": {
Expand All @@ -900,10 +872,6 @@
"$ref": "#/definitions/Deployment"
},
"headers": {
"ETag": {
"type": "string",
"description": "The entity tag for the response."
},
"x-ms-client-request-id": {
"type": "string",
"format": "uuid",
Expand Down Expand Up @@ -9343,11 +9311,6 @@
"type": "object",
"description": "Response from the listSecrets operation",
"properties": {
"id": {
"type": "string",
"description": "Fully qualified resource identifier",
"readOnly": true
},
"name": {
"type": "string",
"description": "The name of the resource",
Expand All @@ -9372,7 +9335,6 @@
}
},
"required": [
"id",
"name",
"type",
"target",
Expand Down Expand Up @@ -9600,64 +9562,52 @@
"type": "object",
"description": "Model Deployment Definition",
"properties": {
"deploymentName": {
"name": {
"type": "string",
"description": "Name of the deployment for the model",
"description": "Name of the deployment",
"readOnly": true
},
"modelName": {
"type": "string",
"description": "Publisher-specific name of the model",
"description": "Publisher-specific name of the deployed model",
"readOnly": true
},
"modelVersion": {
"type": "string",
"description": "Publisher-specific version of the model",
"description": "Publisher-specific version of the deployed model",
"readOnly": true
},
"publisher": {
"modelPublisher": {
"type": "string",
"description": "Name of the model publisher",
"description": "Name of the deployed model's publisher",
"readOnly": true
},
"capabilities": {
"type": "object",
"description": "Capabilities of model",
"description": "Capabilities of deployed model",
"additionalProperties": {
"type": "string"
},
"readOnly": true
},
"raiPolicyName": {
"type": "string",
"description": "RAI policy enabled for model",
"readOnly": true
},
"sku": {
"$ref": "#/definitions/Sku",
"description": "Sku of the model deployment",
"readOnly": true
},
"connectionName": {
"type": "string",
"description": "Name of the connection the model comes from",
"readOnly": true
},
"systemData": {
"$ref": "#/definitions/SystemData",
"description": "System data of the resource",
"description": "Name of the connection the deployment comes from",
"readOnly": true
}
},
"required": [
"deploymentName",
"name",
"modelName",
"modelVersion",
"publisher",
"modelPublisher",
"capabilities",
"raiPolicyName",
"sku",
"systemData"
"sku"
]
},
"EmbeddingConfiguration": {
Expand Down Expand Up @@ -10059,7 +10009,8 @@
"description": "The Connection items on this page",
"items": {
"$ref": "#/definitions/Connection"
}
},
"x-ms-identifiers": []
},
"nextLink": {
"type": "string",
Expand Down Expand Up @@ -10391,44 +10342,6 @@
"x-ms-parameter-location": "method",
"x-ms-client-name": "clientRequestId"
},
"Azure.Core.ConditionalRequestHeaders.ifMatch": {
"name": "If-Match",
"in": "header",
"description": "The request should only proceed if an entity matches this string.",
"required": false,
"type": "string",
"x-ms-parameter-location": "method",
"x-ms-client-name": "ifMatch"
},
"Azure.Core.ConditionalRequestHeaders.ifModifiedSince": {
"name": "If-Modified-Since",
"in": "header",
"description": "The request should only proceed if the entity was modified after this time.",
"required": false,
"type": "string",
"format": "date-time",
"x-ms-parameter-location": "method",
"x-ms-client-name": "ifModifiedSince"
},
"Azure.Core.ConditionalRequestHeaders.ifNoneMatch": {
"name": "If-None-Match",
"in": "header",
"description": "The request should only proceed if no entity matches this string.",
"required": false,
"type": "string",
"x-ms-parameter-location": "method",
"x-ms-client-name": "ifNoneMatch"
},
"Azure.Core.ConditionalRequestHeaders.ifUnmodifiedSince": {
"name": "If-Unmodified-Since",
"in": "header",
"description": "The request should only proceed if the entity was not modified after this time.",
"required": false,
"type": "string",
"format": "date-time",
"x-ms-parameter-location": "method",
"x-ms-client-name": "ifUnmodifiedSince"
},
"Azure.Core.Foundations.ApiVersionParameter": {
"name": "api-version",
"in": "query",
Expand Down
Loading