Skip to content

Conversation

@sarkar-rajarshi
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 10, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Apr 10, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions
Copy link

github-actions bot commented Apr 10, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Language.QuestionAnswering
TypeSpec Language.QuestionAnswering.Authoring
Swagger AnomalyDetector-Language

@heaths
Copy link
Member

heaths commented Apr 10, 2025

Please work through the breaking changes. If you need help, use the TypeSpec Discussions channel internally.

@heaths
Copy link
Member

heaths commented Apr 21, 2025

Can you mark this as a draft until you're ready? I keep seeing updates and not sure how to triage this PR.

@sarkar-rajarshi
Copy link
Member Author

@heaths This is currently under review with the board for typespec migration. There is an active GH issue for it #34045 we are using to track

@sarkar-rajarshi sarkar-rajarshi force-pushed the rsarkar/ai/language/cqa/migrate-to-typespec branch from baf047f to 6014f29 Compare April 23, 2025 23:25
Copy link
Member

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@mikekistler mikekistler added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label Apr 26, 2025
@sarkar-rajarshi
Copy link
Member Author

@heaths This PR is ready to be merged

@sarkar-rajarshi sarkar-rajarshi added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Apr 28, 2025
@sarkar-rajarshi sarkar-rajarshi enabled auto-merge (squash) April 28, 2025 17:41
@kristapratico kristapratico disabled auto-merge April 28, 2025 17:45
@kristapratico kristapratico merged commit 0d82f14 into Azure:main Apr 28, 2025
50 of 51 checks passed
koen-mertens pushed a commit to koen-mertens/azure-rest-api-specs that referenced this pull request May 7, 2025
…uestionAnswering.Authoring spec (Azure#33855)

* Add Language.QuestionAnswering spec

* Add question answering authoring typespec

* run prettier + fix spelling

* add tsv validation fixes

* remove unused common.json specs + remove csharp emitter since its not used

* more changes for lint and model validation

* revert defining auth models

* add pattern for projectName path param

* ProjectMetadata.projectname change visibility to lifecycle read

* address review comments Azure#1

* address review comments Azure#2

* revert change

* more fixes

* minor fixes

* fix examples

* remove FIXME comments

* add custom patch op defintion

* minor fix for custom patch operation

* minor fix
nwnt pushed a commit to nwnt/azure-rest-api-specs that referenced this pull request Jun 10, 2025
…uestionAnswering.Authoring spec (Azure#33855)

* Add Language.QuestionAnswering spec

* Add question answering authoring typespec

* run prettier + fix spelling

* add tsv validation fixes

* remove unused common.json specs + remove csharp emitter since its not used

* more changes for lint and model validation

* revert defining auth models

* add pattern for projectName path param

* ProjectMetadata.projectname change visibility to lifecycle read

* address review comments Azure#1

* address review comments Azure#2

* revert change

* more fixes

* minor fixes

* fix examples

* remove FIXME comments

* add custom patch op defintion

* minor fix for custom patch operation

* minor fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required Cognitive Services data-plane PublishToCustomers Acknowledgement the changes will be published to Azure customers. TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants