Skip to content

Conversation

@haoyingli
Copy link
Contributor

@haoyingli haoyingli commented Jul 13, 2018

…indow Trigger and self-dependent Tumbling Window Trigger
This PR is the same as PR 3356 (#3356) which is already approved. There is some issue in latest AutoRest version and causes build failure, my machine has the old version, so I'm submitting PR again for Alex

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

…indow Trigger and self-dependent Tumbling Window Trigger
@AutorestCI
Copy link

AutorestCI commented Jul 13, 2018

Automation for azure-sdk-for-ruby

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • cognitiveservices/data-plane/WebSearch
  • web/resource-manager
  • alertsmanagement/resource-manager
  • servicefabricmesh/resource-manager
  • containerregistry/resource-manager
  • windowsiot/resource-manager
  • cognitiveservices/data-plane/VisualSearch
  • cognitiveservices/data-plane/AutoSuggest
  • recoveryservicesbackup/resource-manager
  • cognitiveservices/data-plane/EntitySearch
  • cognitiveservices/data-plane/NewsSearch
  • trafficmanager/resource-manager
  • apimanagement/resource-manager
  • cognitiveservices/data-plane/CustomImageSearch
  • datafactory/resource-manager
  • automation/resource-manager
  • hdinsight/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Service
  • iothub/resource-manager
  • cognitiveservices/data-plane/ImageSearch
  • compute/resource-manager
  • cognitiveservices/data-plane/CustomWebSearch
  • managementgroups/resource-manager
  • containerservices/resource-manager
  • cognitiveservices/data-plane/VideoSearch
  • security/resource-manager

@AutorestCI
Copy link

AutorestCI commented Jul 13, 2018

Automation for azure-sdk-for-python

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • managementgroups/resource-manager
  • recoveryservicesbackup/resource-manager
  • cognitiveservices/data-plane/VideoSearch
  • windowsiot/resource-manager
  • cognitiveservices/data-plane/NewsSearch
  • automation/resource-manager
  • cognitiveservices/data-plane/WebSearch
  • cognitiveservices/data-plane/EntitySearch
  • cognitiveservices/data-plane/AutoSuggest
  • apimanagement/resource-manager
  • compute/resource-manager
  • trafficmanager/resource-manager
  • alertsmanagement/resource-manager
  • cognitiveservices/data-plane/ImageSearch
  • security/resource-manager
  • iothub/resource-manager
  • datafactory/resource-manager
  • containerregistry/resource-manager
  • web/resource-manager
  • cognitiveservices/data-plane/CustomImageSearch
  • containerservices/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Service
  • cognitiveservices/data-plane/CustomWebSearch
  • servicefabricmesh/resource-manager
  • cognitiveservices/data-plane/VisualSearch
  • hdinsight/resource-manager

@AutorestCI
Copy link

AutorestCI commented Jul 13, 2018

Automation for azure-sdk-for-node

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • search/data-plane/Microsoft.Azure.Search.Service
  • cognitiveservices/data-plane/VideoSearch
  • apimanagement/resource-manager
  • servicefabricmesh/resource-manager
  • cognitiveservices/data-plane/CustomImageSearch
  • cognitiveservices/data-plane/AutoSuggest
  • web/resource-manager
  • cognitiveservices/data-plane/WebSearch
  • automation/resource-manager
  • cognitiveservices/data-plane/ImageSearch
  • managementgroups/resource-manager
  • cognitiveservices/data-plane/EntitySearch
  • hdinsight/resource-manager
  • containerregistry/resource-manager
  • cognitiveservices/data-plane/VisualSearch
  • security/resource-manager
  • compute/resource-manager
  • containerservices/resource-manager
  • windowsiot/resource-manager
  • datafactory/resource-manager
  • cognitiveservices/data-plane/NewsSearch
  • trafficmanager/resource-manager
  • recoveryservicesbackup/resource-manager
  • iothub/resource-manager
  • cognitiveservices/data-plane/CustomWebSearch
  • alertsmanagement/resource-manager

@AutorestCI
Copy link

AutorestCI commented Jul 13, 2018

Automation for azure-sdk-for-java

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • trafficmanager/resource-manager
  • cognitiveservices/data-plane/VideoSearch
  • cognitiveservices/data-plane/ImageSearch
  • cognitiveservices/data-plane/NewsSearch
  • iothub/resource-manager
  • cognitiveservices/data-plane/AutoSuggest
  • recoveryservicesbackup/resource-manager
  • hdinsight/resource-manager
  • windowsiot/resource-manager
  • managementgroups/resource-manager
  • apimanagement/resource-manager
  • alertsmanagement/resource-manager
  • compute/resource-manager
  • cognitiveservices/data-plane/CustomImageSearch
  • automation/resource-manager
  • servicefabricmesh/resource-manager
  • datafactory/resource-manager
  • web/resource-manager
  • cognitiveservices/data-plane/EntitySearch
  • containerregistry/resource-manager
  • cognitiveservices/data-plane/VisualSearch
  • security/resource-manager
  • containerservices/resource-manager
  • cognitiveservices/data-plane/CustomWebSearch
  • search/data-plane/Microsoft.Azure.Search.Service
  • cognitiveservices/data-plane/WebSearch

@AutorestCI
Copy link

AutorestCI commented Jul 13, 2018

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • apimanagement/resource-manager
  • search/data-plane/Microsoft.Azure.Search.Service
  • security/resource-manager
  • cognitiveservices/data-plane/CustomWebSearch
  • compute/resource-manager
  • iothub/resource-manager
  • servicefabricmesh/resource-manager
  • trafficmanager/resource-manager
  • windowsiot/resource-manager
  • cognitiveservices/data-plane/NewsSearch
  • alertsmanagement/resource-manager
  • managementgroups/resource-manager
  • containerregistry/resource-manager
  • cognitiveservices/data-plane/CustomImageSearch
  • datafactory/resource-manager
  • cognitiveservices/data-plane/VisualSearch
  • hdinsight/resource-manager
  • web/resource-manager
  • cognitiveservices/data-plane/EntitySearch
  • cognitiveservices/data-plane/WebSearch
  • cognitiveservices/data-plane/AutoSuggest
  • automation/resource-manager
  • containerservices/resource-manager
  • cognitiveservices/data-plane/ImageSearch
  • cognitiveservices/data-plane/VideoSearch
  • recoveryservicesbackup/resource-manager

@haoyingli haoyingli changed the title [Datafactory]Add Tumbling Window dependsOn property to Trigger.json for Tumbling W… [Do Not Merge] [Datafactory]Add Tumbling Window dependsOn property to Trigger.json for Tumbling W… Jul 13, 2018
@hovsepm hovsepm added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Jul 13, 2018
@hovsepm hovsepm changed the title [Do Not Merge] [Datafactory]Add Tumbling Window dependsOn property to Trigger.json for Tumbling W… [Datafactory]Add Tumbling Window dependsOn property to Trigger.json for Tumbling W… Jul 13, 2018
Copy link
Contributor

@hvermis hvermis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move your changes to stable/2018-06-01 spec

bfjelds and others added 11 commits July 13, 2018 15:51
…3389)

* Azure Service Fabric Mesh Preview 2018-07-01 REST API specification

* fix the suppression typing error

* updating the go SDK tag and output location based on the review feedback
…ers (#3370)

* Update get entities to include two fields

* Fix a typo
* Suppress Operations API Implemenetation Error

* Suppress RequiredPropertiesMissingInResourceModel linter error
* Fix OAV error log

* remove test/model.js
* Update ReadMe.md by linking the announcements section

* Update README.md

* Update README.md
* add revision description

* fixed missing file reference

* add the missing file
wawon-msft and others added 20 commits July 17, 2018 15:55
…indow Trigger and self-dependent Tumbling Window Trigger
* Added BackupValidateOperation API

* Added BackupValidateOperation API

* Fix casing in validateOperationResponse

* Fix casing in validateOperationResponse

* Fix casing in swagger example file path

* Use ValidateRequest instead of Resource<ValidateRequest>

* Update operationid of validate_Operation to Operation_Validate per feedback

* Update operationid of validate_Operation to Operation_Validate per feedback

* remove additional parameter api-version
* Address CR comments

* Address CR comment

* Address PR comments in C#

* Fix syntax error

* Address CR comments
* Updated webapps swagger with restore deleted site APIs

* Update default package version for WebSiteManagementClient
…indow Trigger and self-dependent Tumbling Window Trigger
…indow Trigger and self-dependent Tumbling Window Trigger
@haoyingli haoyingli closed this Jul 19, 2018
@haoyingli haoyingli deleted the master branch July 19, 2018 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DoNotMerge <valid label in PR review process> use to hold merge after approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.