-
Notifications
You must be signed in to change notification settings - Fork 5.6k
asset contract changes. #34197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dargilco
merged 21 commits into
Azure:feature/azure-ai-projects-1dp
from
adyada:adyada/fix-dataset-contracts
Apr 29, 2025
Merged
asset contract changes. #34197
dargilco
merged 21 commits into
Azure:feature/azure-ai-projects-1dp
from
adyada:adyada/fix-dataset-contracts
Apr 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
adamra-msft
approved these changes
Apr 24, 2025
chaoyu-msft
approved these changes
Apr 25, 2025
andscho-msft
approved these changes
Apr 25, 2025
…ada/azure-rest-api-specs into adyada/fix-dataset-contracts
This was referenced Apr 28, 2025
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
…ada/azure-rest-api-specs into adyada/fix-dataset-contracts
dargilco
approved these changes
Apr 28, 2025
dargilco
requested changes
Apr 28, 2025
|
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
… into adyada/fix-dataset-contracts
dargilco
reviewed
Apr 28, 2025
dargilco
approved these changes
Apr 28, 2025
…ada/azure-rest-api-specs into adyada/fix-dataset-contracts
This was referenced Apr 29, 2025
a1a907a
into
Azure:feature/azure-ai-projects-1dp
36 of 43 checks passed
needuv
added a commit
that referenced
this pull request
May 9, 2025
* Draft of Unified AI Data Plane TypeSpec * fix errors * add indexes to typespec * fix import * fix namespace * clean up dataset and add in connections * fix type discriminator and some bad references * fix a typo in UriFileDatasetVersion * remove body from DatasetContainer * fix import * remove creds from connection * update index to match latest PR * add credentials back to connection * add getWithSecrets * fix thing * update connection based on spec feedback * add fields to model typespec * add query parameters * clean up evals namespace * change evaluations/create to evaluations:create * fix typo * clean up common/models.tsp and add inference APIs * fix some errors and rename file * update with latest PR * make functiondefinition a common model * fix a missing ; * Asset contract changes (#32833) * removed some fields from ResourceBase * dataset contract fixes * cleanup * added start pending upload --------- Co-authored-by: Neehar Duvvuri <[email protected]> * fix some comments * fix some more comments * fix some more comments * fix up pending upload request names * fix dataset route for pending upload * attempt to move to azure core operations for connection only * fix connections based on errors * attempt to fix credentials * fix connections list with secrets route * remove @route decorator * make models into a resource * remove connection paged response * fix up some issues * update index with latest spec * fix duped names * fix thing * connection id is optional for embedding * change index create to POST, add cosmosdb as connection type * fix tsp error * First * Run `npx tsp format **\*.tsp` (#33117) * separate deployments from models * make asset base an alias * fix up some errors in tsp * Run `npx tsp format **\*.tsp` again * Revert change to client.tsp that got in prematurely. I'll send a PR for all client/namespaces changes for review. * Fix all compilation errors (#33143) * Suppress some linter errors. We do the same in the Inference SDK TypeSpec * Use Union with string instead of Enum * Per Johan, okay to suppress this: PUT operations that return 200 should start with 'replace' or 'createOrReplace' * Add missing doc strings * Rename root folder to Azure.AI.Projects * delete azure.ai.unified dir * clean up connections * remove inference routes from tsp * Additional changes to support SDK emitters (#33184) * Rename Azure.AI.Unified to Azure.AI.Projects * Run `npx tsp format **\*.tsp`. Run `npx tsv .` and update swagger * update evaluations operations * fix id being optional * align to old naming * Rename package and folder to azure-ai-projects-dp1 (#33195) * add visibility param to key * Update ConnectionType enum (#33224) * Remove Extraneous Fields from Connection and Deployment (#33245) * Remove unnecessary deployments contracts * remove unnecessary connection fields * Run npx tsv . * Dataset Review Feedback (#33252) * Update dataset with extra fields * update a docstring * add optional version in pendingupload response, and isReference to dataset version * make isreference readonly * add connection name to pendinguploadrequest * add uri_folder * add uri_folder * update swagger file * Add service pattern templates for 1dp azure ai projects (#33235) * Update generated azure-ai-project-1dp.json to match TSP sources (recompiled) * Updated azure ai projects datasets to use common entity templates * Updated indexes to use versioned entity operations for azure ai projects. * Address review feedback/azure ai projects 1dp service patterns * Updated generated azure ai projects 1dp openapi description * Added support for client request id for repeatable creates * Added documentation and appropriate suppressions for operation templates for azure ai 1dp * cspell fixes azure ai projects 1dp * Formatting update * Fix broken merge * fix merge conflicts with datasets/models.tsp --------- Co-authored-by: Neehar Duvvuri <[email protected]> Co-authored-by: Neehar Duvvuri <[email protected]> * Change Name of Autoincrement API (#33353) * Change name of versions post to create * properly hit save this time * Incorporate Index Feedback (#33243) * address index feedback * update swagger file * Change indexType -> index * Version-less Pending Upload API (#33399) * Add version-less startPendingUploadAPI * address feedback * Rename folder and namespace from Agents to Assistants (#33452) * Fix some of the build breaks due to new TypeSpec tools * Fix error due to new tools: `error deprecated: Deprecated: Implicit multipart is deprecated` * Remove $ from query param, remove system data, align list/listLatest query parameters, and add type discriminator for Deployments (#33455) * Remove $ from query param, remove system data, add type discriminator for deployments * rename properties -> metadata * update swagger file * Fix formt after running `npx tsp format **\*.tsp` * Bring over latest Agent typespec files from branch feature/azure-ai-projects (#33490) * Remove all $ from query params (#33512) * Add API key auth via the header `Authorization: Bearer <key>` (#33516) * Add api-key auth * Remove unused `using` statements * Change connectionName to name (#33534) * Fix connectionName to be just name * update swagger --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Fix startPendingUploadAutoIncrement (#33525) * Address some additional TypeSpec issues (#33566) * Azure ai projects eval result asset (#33544) * upload API for remote evals * switch to dictionary of outputs * clean-ups * all evaluations will have some output structure * switch to a separate input dto * modeling where we change the input types for create/upload to unify on return types * make optional * remove upload * parity with service changes * align with the rest of assests: note that startpendinguploadincrement is not supported * fix evaluations * realign eval routes * Remove 'outputs' property from JSON schema * Neehars comments * add route * compile errors * [Eval Service Team] Red Team Cloud 1DP (#33287) * init red teams for 1dp * edits after review meeting * clean-ups * make outputs read-only * clean-ups * review comments * want to align with evaluations * add route to main * compile errors * json * Remove credentials folder and fix some route names (#33587) Co-authored-by: Neehar Duvvuri <[email protected]> * Create a separate TypeSpec project for Assistants (#33586) * Remove Azure.AI.Assistant TypeSpec from this branch * Add API Versions to Projects TypeSpec (#33631) * Add API versions to typespec entities and split swaggers into stable/preview versions * fix doc string --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Fix Spellcheck Gate for Projects TypeSpec (#33636) * Fix spellcheck gate * reanme myproject -> projectName * put changes in ai cspell --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Set the api-version used by emitted SDKs (#33642) * Python SDK version * Set the api-version the SDKs will use * Fix output folder structure in emitted Python code * Fix startPendingUpload path for versioned API (#33710) * Make sure this TypeSpec PR is green with regards to Python SDK emitter (#33712) * Fix C# SdkTspConfigValidation validation failures * remove eval result from public (#33729) * regenerate swagger (#33739) * Another round of updates to /connections, /datasets & /indexes operations (#33829) * Update swagger files * Get download sas API (#33845) * Get download sas API * Update specification/ai/Azure.AI.Projects/datasets/routes.tsp Co-authored-by: Neehar Duvvuri <[email protected]> * Update specification/ai/Azure.AI.Projects/datasets/routes.tsp Co-authored-by: Neehar Duvvuri <[email protected]> --------- Co-authored-by: Neehar Duvvuri <[email protected]> * updated swaggers (#33898) * Users/singankit/evaluation create return 201 (#33946) * Evalaution create is LRO so service returns 201 * Adding updated swagger * 201 for read team run * Add connection operations with credentials (#33929) * Add PATCH for Asset Create/Update (#34021) * Add PATCH for asset create/update * Update specification/ai/Azure.AI.Projects/servicepatterns.tsp Co-authored-by: Johan Stenberg (MSFT) <[email protected]> --------- Co-authored-by: Neehar Duvvuri <[email protected]> Co-authored-by: Johan Stenberg (MSFT) <[email protected]> * RedTeam Updates from implementation (#34023) * updates from implementation * update to match docs: https://learn.microsoft.com/en-us/azure/ai-foundry/concepts/ai-red-teaming-agent#supported-attack-strategies * Remove api-key auth (#34097) * Remove Asset PUT (#34133) * Update servicepatterns.tsp * add swaggers --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Update comment from `Assistants` to `Agents`, since we decided to use `Agents` terminology * API for create agent evaluation run (#34034) * Agent evaluation run request and get agent evaluation run result * Update fields to remove redundant information * Update comments for run Id * Remove API "get agent evaluation results" * Revert "Remove API "get agent evaluation results"" This reverts commit d48b192. * Update to use sync API * Update comments * Address PR feedbacks from Johan * Update long running operation response to the format closer to "runs:run" * Add RedactionConfiguration * Add docs to redactScoreProperties * Update results to result * Update threshold from 10K to 1K * Update names to group agent evaluation related fields * Align status with existing status code from RAISvc * Fix TypeSpec compile errors from previous commit * Red-Team Target API Definition (#34144) * initial idea * update based on comments * updates from comments * casing update * fix spell check gate (#34181) Co-authored-by: Neehar Duvvuri <[email protected]> * Remove listing connections with credentials (#34148) * Switch AppInsights connection string to be mandatory for SDKs and add… (#34198) * Switch AppInsights connection string to be mandatory for SDKs and add top level error field for get agent evaluation results API * Updated generated JSON * Update docs to address PR feedbacks * Update the generated JSON file * Drop the 'onedp' name in emitted Python SDK package and folder * Update swagger * Auto fix to file red-teams/models.tsp after running `npx tsv .` * Add Type Filter to Deployment List (#34247) * add a deployment type query param * Add deploymentType as filter to listing --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Fix SdkTspConfigValidation issues (#34248) * Auto fix to file red-teams/models.tsp after running `npx tsv .` * First * More fixes * More fixes * Add examples and readme.md for Azure.AI.Projects (#34220) * Add examples for Azure.AI.Projects * run npx tsv * fix UUID issue * run prettier on examples * run prettier on examples * fix UUID issues in data-plane examples * add a readme * fix uuid * take bad request id * fix thing * suppress lint diff * fix suppression where * fix suppression * merge and run tsv * random string -> uuid * fix UUID issue * revert red teams change * Auto fix to file red-teams/models.tsp after running `npx tsv .` * Fix SdkTspConfigValidation issues (#34248) * Auto fix to file red-teams/models.tsp after running `npx tsv .` * First * More fixes * More fixes --------- Co-authored-by: Neehar Duvvuri <[email protected]> Co-authored-by: Darren Cohen <[email protected]> * fix spell check (#34253) Co-authored-by: Neehar Duvvuri <[email protected]> * Fix Java language failure * Rename latest api version to v1 (#34288) Co-authored-by: Neehar Duvvuri <[email protected]> * Users/singankit/update evaluation name (#34301) * Update models.tsp * Adding updated swaggers * Fix all Java, Go & Python issues in SdkTspConfigValidation when running "npx tsv ." (#34272) * Suppress JS emitter errors related to package and dir name missing the word `rest` in them. We do not use RLC in JS * Address comments from SDK review meeting (#34273) * asset contract changes. (#34197) * Fix Dataset Swagger Validation (#34339) * Update dataset examples * fix tsp validation * remove unused stage * fix datasetVersion -> version --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Additional round of updates (#34333) * Remove `-1dp` from swagger file name. Update route for get connecitons with credentials * Remove doc string comment `[Required]` * Fix swagger name in data-plane readme.md * Add continuationToken decorator for dataset/index list (#34372) Co-authored-by: Neehar Duvvuri <[email protected]> * Update scope * Usesr/singankit/evaluation review feedback (#34427) * Fixing review comments * Evaluation Review Commnets fixed * Reverting non required change * Fix typo in doc string * Fix Swagger Avocado * Add evaluation Id (#34391) * Add evaluation Id * Update JSON * Add missing connection id (#34434) * [Red Team] clean-up contract details (#34444) * clean-up contract details * update json/compile * scan name optional * remove stable changes * Make PATCH Content-Type Header application/merge-patch+json (#34449) * add content type header for patch * pull from base --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Remove List Query Parameters and Dataset Credentials Body (#34471) * Remove List Query Params, Remove Body from Dataset Get Credentials * clean up unused imports * fix examples for swagger validation * fix samples * add missing evaluatorId * apparently evaluator/evaluator id both exist n the same payload --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Add Index Field Mapping (#34476) * Add FieldMapping to index * update doc string --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Remove pagination query params from the /connection list operation (#34486) * Add optional connectionName to DatasetVersion (#34521) * Fix TypeSpec Validation and Address Minor Feedback (#34536) * Fix TypeSpec Validation * fix examples * fix swagger examples * clean up imports and delete a client file * clean up more unused imports" * fix examples --------- Co-authored-by: Neehar Duvvuri <[email protected]> --------- Co-authored-by: adyada <[email protected]> Co-authored-by: Darren Cohen <[email protected]> Co-authored-by: Johan Stenberg (MSFT) <[email protected]> Co-authored-by: Neehar Duvvuri <[email protected]> Co-authored-by: Kayla Seager <[email protected]> Co-authored-by: Andrew Schonhoffer <[email protected]> Co-authored-by: Ankit Singhal <[email protected]> Co-authored-by: David Wu <[email protected]>
nwnt
pushed a commit
to nwnt/azure-rest-api-specs
that referenced
this pull request
Jun 10, 2025
* Draft of Unified AI Data Plane TypeSpec * fix errors * add indexes to typespec * fix import * fix namespace * clean up dataset and add in connections * fix type discriminator and some bad references * fix a typo in UriFileDatasetVersion * remove body from DatasetContainer * fix import * remove creds from connection * update index to match latest PR * add credentials back to connection * add getWithSecrets * fix thing * update connection based on spec feedback * add fields to model typespec * add query parameters * clean up evals namespace * change evaluations/create to evaluations:create * fix typo * clean up common/models.tsp and add inference APIs * fix some errors and rename file * update with latest PR * make functiondefinition a common model * fix a missing ; * Asset contract changes (Azure#32833) * removed some fields from ResourceBase * dataset contract fixes * cleanup * added start pending upload --------- Co-authored-by: Neehar Duvvuri <[email protected]> * fix some comments * fix some more comments * fix some more comments * fix up pending upload request names * fix dataset route for pending upload * attempt to move to azure core operations for connection only * fix connections based on errors * attempt to fix credentials * fix connections list with secrets route * remove @route decorator * make models into a resource * remove connection paged response * fix up some issues * update index with latest spec * fix duped names * fix thing * connection id is optional for embedding * change index create to POST, add cosmosdb as connection type * fix tsp error * First * Run `npx tsp format **\*.tsp` (Azure#33117) * separate deployments from models * make asset base an alias * fix up some errors in tsp * Run `npx tsp format **\*.tsp` again * Revert change to client.tsp that got in prematurely. I'll send a PR for all client/namespaces changes for review. * Fix all compilation errors (Azure#33143) * Suppress some linter errors. We do the same in the Inference SDK TypeSpec * Use Union with string instead of Enum * Per Johan, okay to suppress this: PUT operations that return 200 should start with 'replace' or 'createOrReplace' * Add missing doc strings * Rename root folder to Azure.AI.Projects * delete azure.ai.unified dir * clean up connections * remove inference routes from tsp * Additional changes to support SDK emitters (Azure#33184) * Rename Azure.AI.Unified to Azure.AI.Projects * Run `npx tsp format **\*.tsp`. Run `npx tsv .` and update swagger * update evaluations operations * fix id being optional * align to old naming * Rename package and folder to azure-ai-projects-dp1 (Azure#33195) * add visibility param to key * Update ConnectionType enum (Azure#33224) * Remove Extraneous Fields from Connection and Deployment (Azure#33245) * Remove unnecessary deployments contracts * remove unnecessary connection fields * Run npx tsv . * Dataset Review Feedback (Azure#33252) * Update dataset with extra fields * update a docstring * add optional version in pendingupload response, and isReference to dataset version * make isreference readonly * add connection name to pendinguploadrequest * add uri_folder * add uri_folder * update swagger file * Add service pattern templates for 1dp azure ai projects (Azure#33235) * Update generated azure-ai-project-1dp.json to match TSP sources (recompiled) * Updated azure ai projects datasets to use common entity templates * Updated indexes to use versioned entity operations for azure ai projects. * Address review feedback/azure ai projects 1dp service patterns * Updated generated azure ai projects 1dp openapi description * Added support for client request id for repeatable creates * Added documentation and appropriate suppressions for operation templates for azure ai 1dp * cspell fixes azure ai projects 1dp * Formatting update * Fix broken merge * fix merge conflicts with datasets/models.tsp --------- Co-authored-by: Neehar Duvvuri <[email protected]> Co-authored-by: Neehar Duvvuri <[email protected]> * Change Name of Autoincrement API (Azure#33353) * Change name of versions post to create * properly hit save this time * Incorporate Index Feedback (Azure#33243) * address index feedback * update swagger file * Change indexType -> index * Version-less Pending Upload API (Azure#33399) * Add version-less startPendingUploadAPI * address feedback * Rename folder and namespace from Agents to Assistants (Azure#33452) * Fix some of the build breaks due to new TypeSpec tools * Fix error due to new tools: `error deprecated: Deprecated: Implicit multipart is deprecated` * Remove $ from query param, remove system data, align list/listLatest query parameters, and add type discriminator for Deployments (Azure#33455) * Remove $ from query param, remove system data, add type discriminator for deployments * rename properties -> metadata * update swagger file * Fix formt after running `npx tsp format **\*.tsp` * Bring over latest Agent typespec files from branch feature/azure-ai-projects (Azure#33490) * Remove all $ from query params (Azure#33512) * Add API key auth via the header `Authorization: Bearer <key>` (Azure#33516) * Add api-key auth * Remove unused `using` statements * Change connectionName to name (Azure#33534) * Fix connectionName to be just name * update swagger --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Fix startPendingUploadAutoIncrement (Azure#33525) * Address some additional TypeSpec issues (Azure#33566) * Azure ai projects eval result asset (Azure#33544) * upload API for remote evals * switch to dictionary of outputs * clean-ups * all evaluations will have some output structure * switch to a separate input dto * modeling where we change the input types for create/upload to unify on return types * make optional * remove upload * parity with service changes * align with the rest of assests: note that startpendinguploadincrement is not supported * fix evaluations * realign eval routes * Remove 'outputs' property from JSON schema * Neehars comments * add route * compile errors * [Eval Service Team] Red Team Cloud 1DP (Azure#33287) * init red teams for 1dp * edits after review meeting * clean-ups * make outputs read-only * clean-ups * review comments * want to align with evaluations * add route to main * compile errors * json * Remove credentials folder and fix some route names (Azure#33587) Co-authored-by: Neehar Duvvuri <[email protected]> * Create a separate TypeSpec project for Assistants (Azure#33586) * Remove Azure.AI.Assistant TypeSpec from this branch * Add API Versions to Projects TypeSpec (Azure#33631) * Add API versions to typespec entities and split swaggers into stable/preview versions * fix doc string --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Fix Spellcheck Gate for Projects TypeSpec (Azure#33636) * Fix spellcheck gate * reanme myproject -> projectName * put changes in ai cspell --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Set the api-version used by emitted SDKs (Azure#33642) * Python SDK version * Set the api-version the SDKs will use * Fix output folder structure in emitted Python code * Fix startPendingUpload path for versioned API (Azure#33710) * Make sure this TypeSpec PR is green with regards to Python SDK emitter (Azure#33712) * Fix C# SdkTspConfigValidation validation failures * remove eval result from public (Azure#33729) * regenerate swagger (Azure#33739) * Another round of updates to /connections, /datasets & /indexes operations (Azure#33829) * Update swagger files * Get download sas API (Azure#33845) * Get download sas API * Update specification/ai/Azure.AI.Projects/datasets/routes.tsp Co-authored-by: Neehar Duvvuri <[email protected]> * Update specification/ai/Azure.AI.Projects/datasets/routes.tsp Co-authored-by: Neehar Duvvuri <[email protected]> --------- Co-authored-by: Neehar Duvvuri <[email protected]> * updated swaggers (Azure#33898) * Users/singankit/evaluation create return 201 (Azure#33946) * Evalaution create is LRO so service returns 201 * Adding updated swagger * 201 for read team run * Add connection operations with credentials (Azure#33929) * Add PATCH for Asset Create/Update (Azure#34021) * Add PATCH for asset create/update * Update specification/ai/Azure.AI.Projects/servicepatterns.tsp Co-authored-by: Johan Stenberg (MSFT) <[email protected]> --------- Co-authored-by: Neehar Duvvuri <[email protected]> Co-authored-by: Johan Stenberg (MSFT) <[email protected]> * RedTeam Updates from implementation (Azure#34023) * updates from implementation * update to match docs: https://learn.microsoft.com/en-us/azure/ai-foundry/concepts/ai-red-teaming-agent#supported-attack-strategies * Remove api-key auth (Azure#34097) * Remove Asset PUT (Azure#34133) * Update servicepatterns.tsp * add swaggers --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Update comment from `Assistants` to `Agents`, since we decided to use `Agents` terminology * API for create agent evaluation run (Azure#34034) * Agent evaluation run request and get agent evaluation run result * Update fields to remove redundant information * Update comments for run Id * Remove API "get agent evaluation results" * Revert "Remove API "get agent evaluation results"" This reverts commit d48b192. * Update to use sync API * Update comments * Address PR feedbacks from Johan * Update long running operation response to the format closer to "runs:run" * Add RedactionConfiguration * Add docs to redactScoreProperties * Update results to result * Update threshold from 10K to 1K * Update names to group agent evaluation related fields * Align status with existing status code from RAISvc * Fix TypeSpec compile errors from previous commit * Red-Team Target API Definition (Azure#34144) * initial idea * update based on comments * updates from comments * casing update * fix spell check gate (Azure#34181) Co-authored-by: Neehar Duvvuri <[email protected]> * Remove listing connections with credentials (Azure#34148) * Switch AppInsights connection string to be mandatory for SDKs and add… (Azure#34198) * Switch AppInsights connection string to be mandatory for SDKs and add top level error field for get agent evaluation results API * Updated generated JSON * Update docs to address PR feedbacks * Update the generated JSON file * Drop the 'onedp' name in emitted Python SDK package and folder * Update swagger * Auto fix to file red-teams/models.tsp after running `npx tsv .` * Add Type Filter to Deployment List (Azure#34247) * add a deployment type query param * Add deploymentType as filter to listing --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Fix SdkTspConfigValidation issues (Azure#34248) * Auto fix to file red-teams/models.tsp after running `npx tsv .` * First * More fixes * More fixes * Add examples and readme.md for Azure.AI.Projects (Azure#34220) * Add examples for Azure.AI.Projects * run npx tsv * fix UUID issue * run prettier on examples * run prettier on examples * fix UUID issues in data-plane examples * add a readme * fix uuid * take bad request id * fix thing * suppress lint diff * fix suppression where * fix suppression * merge and run tsv * random string -> uuid * fix UUID issue * revert red teams change * Auto fix to file red-teams/models.tsp after running `npx tsv .` * Fix SdkTspConfigValidation issues (Azure#34248) * Auto fix to file red-teams/models.tsp after running `npx tsv .` * First * More fixes * More fixes --------- Co-authored-by: Neehar Duvvuri <[email protected]> Co-authored-by: Darren Cohen <[email protected]> * fix spell check (Azure#34253) Co-authored-by: Neehar Duvvuri <[email protected]> * Fix Java language failure * Rename latest api version to v1 (Azure#34288) Co-authored-by: Neehar Duvvuri <[email protected]> * Users/singankit/update evaluation name (Azure#34301) * Update models.tsp * Adding updated swaggers * Fix all Java, Go & Python issues in SdkTspConfigValidation when running "npx tsv ." (Azure#34272) * Suppress JS emitter errors related to package and dir name missing the word `rest` in them. We do not use RLC in JS * Address comments from SDK review meeting (Azure#34273) * asset contract changes. (Azure#34197) * Fix Dataset Swagger Validation (Azure#34339) * Update dataset examples * fix tsp validation * remove unused stage * fix datasetVersion -> version --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Additional round of updates (Azure#34333) * Remove `-1dp` from swagger file name. Update route for get connecitons with credentials * Remove doc string comment `[Required]` * Fix swagger name in data-plane readme.md * Add continuationToken decorator for dataset/index list (Azure#34372) Co-authored-by: Neehar Duvvuri <[email protected]> * Update scope * Usesr/singankit/evaluation review feedback (Azure#34427) * Fixing review comments * Evaluation Review Commnets fixed * Reverting non required change * Fix typo in doc string * Fix Swagger Avocado * Add evaluation Id (Azure#34391) * Add evaluation Id * Update JSON * Add missing connection id (Azure#34434) * [Red Team] clean-up contract details (Azure#34444) * clean-up contract details * update json/compile * scan name optional * remove stable changes * Make PATCH Content-Type Header application/merge-patch+json (Azure#34449) * add content type header for patch * pull from base --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Remove List Query Parameters and Dataset Credentials Body (Azure#34471) * Remove List Query Params, Remove Body from Dataset Get Credentials * clean up unused imports * fix examples for swagger validation * fix samples * add missing evaluatorId * apparently evaluator/evaluator id both exist n the same payload --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Add Index Field Mapping (Azure#34476) * Add FieldMapping to index * update doc string --------- Co-authored-by: Neehar Duvvuri <[email protected]> * Remove pagination query params from the /connection list operation (Azure#34486) * Add optional connectionName to DatasetVersion (Azure#34521) * Fix TypeSpec Validation and Address Minor Feedback (Azure#34536) * Fix TypeSpec Validation * fix examples * fix swagger examples * clean up imports and delete a client file * clean up more unused imports" * fix examples --------- Co-authored-by: Neehar Duvvuri <[email protected]> --------- Co-authored-by: adyada <[email protected]> Co-authored-by: Darren Cohen <[email protected]> Co-authored-by: Johan Stenberg (MSFT) <[email protected]> Co-authored-by: Neehar Duvvuri <[email protected]> Co-authored-by: Kayla Seager <[email protected]> Co-authored-by: Andrew Schonhoffer <[email protected]> Co-authored-by: Ankit Singhal <[email protected]> Co-authored-by: David Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Release planner
A release plan should have been created. If not, please create one as it will help guide you through the REST API and SDK creation process.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.