Skip to content

Address comments from SDK review meeting #34273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dargilco merged 12 commits into from
Apr 29, 2025
Merged

Address comments from SDK review meeting #34273

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3636f5d
First
dargilco Apr 27, 2025
aa13a28
Auto format fix
dargilco Apr 27, 2025
a0265a8
More
dargilco Apr 27, 2025
33a99c9
Update comment
dargilco Apr 27, 2025
d51244c
Revert ServicePatterns change
dargilco Apr 27, 2025
6c8d028
Do not auto-gen samples for Python
dargilco Apr 27, 2025
c66bd6d
Update docs string for dataset getCredentials
dargilco Apr 28, 2025
6471f8e
More updates to the same doc string
dargilco Apr 28, 2025
4cbed09
Comment out unused alias
dargilco Apr 28, 2025
dbcecbb
Merge remote-tracking branch 'origin/feature/azure-ai-projects-1dp' i…
dargilco Apr 29, 2025
d0d073d
Merge remote-tracking branch 'origin/feature/azure-ai-projects-1dp' i…
dargilco Apr 29, 2025
bd51239
Suppress error related to not generating python samples
dargilco Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More
  • Loading branch information
@dargilco
dargilco committed Apr 27, 2025
commit a0265a8e4fee8ea7ee3e7991fd38311d81a911d1
18 changes: 18 additions & 0 deletions specification/ai/Azure.AI.Projects/client.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ using Azure.ClientGenerator.Core;

@@clientName(Azure.AI.Projects, "AIProjectClient");

// Shorter method names for SDK datasets operations
@@clientName(Azure.AI.Projects.Datasets.listLatest, "list");
@@clientName(Azure.AI.Projects.Datasets.getVersion, "get");
@@clientName(Azure.AI.Projects.Datasets.deleteVersion, "delete");
Expand All @@ -15,7 +16,24 @@ using Azure.ClientGenerator.Core;
"pendingUpload"
);

// Shorter method names for SDK Index operations
@@clientName(Azure.AI.Projects.Indexes.listLatest, "list");
@@clientName(Azure.AI.Projects.Indexes.getVersion, "get");
@@clientName(Azure.AI.Projects.Indexes.deleteVersion, "delete");
@@clientName(Azure.AI.Projects.Indexes.createOrUpdateVersion, "createOrUpdate");

// In Python, the emitter changes "keys" to "keys_property", since there is already
// a "keys" method in the generated code due to usage of MutableMapping. Call it credential_keys instead.
@@clientName(Azure.AI.Projects.CustomCredential.keys,
"credential_keys",
"python"
);

// All SDKs hand-write a single public method with boolean "includeCredentials" input parameters
// that calls either on of the internal methods below
@@access(Azure.AI.Projects.Connections.get, Access.internal);
@@access(Azure.AI.Projects.Connections.getWithCredentials, Access.internal);

// For some reason for Python the emitter creates an empty ServicePatternsOperations operation
// class. Mark it as internal here. Apply to all languages just in case.
@@access(Azure.AI.Projects.ServicePatterns, Access.internal);
2 changes: 1 addition & 1 deletion specification/ai/Azure.AI.Projects/connections/models.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ model EntraIDCredentials extends BaseCredentials {
type: CredentialType.entraId;
}

@doc("Custom credential defintion")
@doc("Custom credential definition")
model CustomCredential extends BaseCredentials {
@doc("The credential type")
@visibility(Lifecycle.Read)
Expand Down
2 changes: 1 addition & 1 deletion ...ion/ai/data-plane/Azure.AI.Projects/preview/2025-05-15-preview/azure-ai-projects-1dp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2379,7 +2379,7 @@
},
"CustomCredential": {
"type": "object",
"description": "Custom credential defintion",
"description": "Custom credential definition",
"properties": {
"keys": {
"type": "object",
Expand Down
2 changes: 1 addition & 1 deletion specification/ai/data-plane/Azure.AI.Projects/stable/2025-05-01/azure-ai-projects-1dp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1683,7 +1683,7 @@
},
"CustomCredential": {
"type": "object",
"description": "Custom credential defintion",
"description": "Custom credential definition",
"properties": {
"keys": {
"type": "object",
Expand Down
2 changes: 1 addition & 1 deletion specification/ai/data-plane/Azure.AI.Projects/stable/latest/azure-ai-projects-1dp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1683,7 +1683,7 @@
},
"CustomCredential": {
"type": "object",
"description": "Custom credential defintion",
"description": "Custom credential definition",
"properties": {
"keys": {
"type": "object",
Expand Down
Loading